Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034807Retail ModulesStoreServerpublic2016-12-22 10:352016-12-29 13:22
Reportermtaal 
Assigned ToSandrahuguet 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q1Fixed in VersionRR17Q1 
Merge Request Status
Review Assigned Tomtaal
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034807: [API change] Remove the trigger state field from mobile server definition as the server type (main) provides enough information
DescriptionThe trigger state field (of the Mobile Server Definition table) flag was intended to define that a server's unavailability would trigger going offline or online. However in practice the server type is enough. All the relevant code already uses the utility method [1] checking both the servertype and trigger state.

The idea was to support that new server types could trigger offline. But this should be re-implemented whenever this becomes relevant as we then have better knowledge on how it will be used. Also there is already some extension possible for offline checking [2].


[1]
https://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/file/ef3722f7a2bd/src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java#l41 [^]

[2]
http://wiki.openbravo.com/wiki/How_to_implement_custom_offline_checking [^]
Steps To ReproduceInstall multi-server
Proposed SolutionRemove the trigger state column and all its usages. Check if the column is used anywhere else than in the above utils method.
Additional Information
TagsApproved
Relationships
related to defect 0035292 closed AugustoMauch API Change: Ping Service and Trigger State columns should be deleted 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-12-22 10:35mtaalNew Issue
2016-12-22 10:35mtaalAssigned To => Sandrahuguet
2016-12-22 10:35mtaalOBNetwork customer => No
2016-12-22 10:35mtaalTriggers an Emergency Pack => No
2016-12-22 10:38mtaalReview Assigned To => mtaal
2016-12-22 10:38mtaalDescription Updatedbug_revision_view_page.php?rev_id=14112#r14112
2016-12-27 11:19SandrahuguetSummaryRemove the trigger state field from mobile server definition as the server type (main) provides enough information => [API change] Remove the trigger state field from mobile server definition as the server type (main) provides enough information
2016-12-27 11:24SandrahuguetStatusnew => scheduled
2016-12-27 19:42dmitry_mezentsevTag Attached: Approved
2016-12-28 09:59hgbotCheckin
2016-12-28 09:59hgbotNote Added: 0093036
2016-12-28 09:59hgbotStatusscheduled => resolved
2016-12-28 09:59hgbotResolutionopen => fixed
2016-12-28 09:59hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/727ec6dd252256acce4935d1d69654e5339e100c [^]
2016-12-29 13:22mtaalNote Added: 0093052
2016-12-29 13:22mtaalStatusresolved => closed
2016-12-29 13:22mtaalFixed in Version => RR17Q1
2017-03-09 10:28mtaalRelationship addedrelated to 0035292

Notes
(0093036)
hgbot   
2016-12-28 09:59   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 727ec6dd252256acce4935d1d69654e5339e100c
Author: Sandra Huguet <sandra.huguet <at> openbravo.com>
Date: Wed Dec 28 09:59:01 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/727ec6dd252256acce4935d1d69654e5339e100c [^]

Fixed issue 34807 Remove triggerstate field from mobile server definition

---
M src-db/database/model/tables/OBMOBC_SERVER_DEFINITION.xml
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src/org/openbravo/mobile/core/servercontroller/MobileMainServerCheck.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerRequestExecutor.java
M src/org/openbravo/mobile/core/servercontroller/MobileServerUtils.java
---
(0093052)
mtaal   
2016-12-29 13:22   
Reviewed and tested