Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034329
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] StoreServermajorhave not tried2016-10-28 09:312017-01-27 12:25
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR17Q2
StatusclosedFix in branchFixed in SCM revisiond373a0c59bde
ProjectionnoneETAnoneTarget VersionRR17Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034329: Support manually decrease of next assigned ad_sequence and replication to store servers

DescriptionContext from the related issue:
- the ad_sequence table is now replicated bi-directional from central to store and vice versa
- when store is not connected to central it is possible that the same ad_sequence has different next assigned numbers in store versus central
- this happens when the ad_sequence is shared/used by different stores
- this is not a problem as long as document numbers of documents have a store-specific prefix
- still 'holes' will exist between document numbers of one store, but afaik this is okay
- when a store connects again to central it was possible that the replication would lower the next assigned number in either direction
- to prevent this the replication logic ignores updates which would lower the document number. This was implemented in the related issue.
- this replication logic and prevent-decrease-next-assigned-number logic is all done in the store server module, so the standard retail-erp is not changed

However:
- there are functional cases where people want to reset the next assigned number manually on purpose
- this would now not be replicated to the stores (as the replication logic ignores these decrease-next-assigned-number updates)

To solve this, this issue proposes:
- add a flag in ad_sequence: Update assigned number in stores
- show the flag in the window/tab, editable
- add an event handler which prevents lowering the next assigned number if this flag is not checked
- when this flag is set then the decrease of next assigned number is replicated from central to store
- the stores when receiving the update will set the flag back to unchecked
- this flag/logic will be implemented in the store server module, no change in core/central
Steps To ReproduceSee related issue
Proposed SolutionSee Description
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0034253 closedmtaal [STORE SERVER 1985] Document sequence of invoices is not synchronized so invoices doc number can be duplicated. 
blocks defect 0034530 closedmtaal Invoice document number does not get synced to the central server in offline mode 

-  Notes
(0093294)
eduardo_Argal (developer)
2017-01-10 11:04

 I like the flag approach to be able to manually decrease the sequence number. This reset of sequence use to happen every year (both sequence prefix and sequence number can be updated manually)
(0093562)
hgbot (developer)
2017-01-14 16:01

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: d373a0c59bde890c3e48a420d19ecdc062da83d0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Jan 14 16:01:03 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d373a0c59bde890c3e48a420d19ecdc062da83d0 [^]

Fixes issue 34329: Support manually decrease of next assigned ad_sequence and replication to store servers
Add new button and internal column to replicate sequence number also when it decreases

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/retail/storeserver/synchronization/DocumentSequenceWriterFilterAdapter.java
A src-db/database/model/modifiedTables/AD_SEQUENCE.xml
A src/org/openbravo/retail/storeserver/synchronization/process/DocumentSequenceReplicateNextNumber.java
---
(0093563)
mtaal (manager)
2017-01-14 16:33

 The solution is not a flag but a button to be pressed:
http://wiki.openbravo.com/wiki/Retail:Store_Server#Replicating_Document_Sequence_Number_Changes [^]
(0093815)
mtaal (manager)
2017-01-25 11:12

 To test the solution:
1- install multi-server
2- check that replication works
3- go to document number sequence table, find a document sequence which is also present in a store
4- increase the next assigned number
5- check that it gets replicated to the store
6- decrease the next assigned number
7- check that it does not get replicated to the store
8- press the replicate document sequence number button
9- check that the document sequence number change is replicated to the store
(0093846)
mtaal (manager)
2017-01-26 15:49

 Note that for the document numbers maintained internally in the pos terminal there is already code to prevent decrease of the next assigned number:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/c3696ff1abb8/src/org/openbravo/retail/storeserver/synchronization/OrderDocumentNoWriterFilterAdapter.java#l85 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/7f1ed45fd251/src/org/openbravo/retail/posterminal/OrderLoader.java#l1558 [^]
(0093879)
Sandrahuguet (developer)
2017-01-27 12:25

 reviewed and tested

- Issue History
Date Modified Username Field Change
2016-10-28 09:31 mtaal New Issue
2016-10-28 09:31 mtaal Assigned To => mtaal
2016-10-28 09:31 mtaal Triggers an Emergency Pack => No
2016-10-28 09:31 mtaal Relationship added related to 0034253
2016-11-18 09:00 mtaal Summary Support manually decrease of next assigned module and replication to store servers => Support manually decrease of next assigned ad_sequence and replication to store servers
2016-11-18 09:00 mtaal Description Updated View Revisions
2016-11-18 09:04 mtaal Relationship added blocks 0034530
2016-12-29 11:51 mtaal Target Version RR17Q1 => RR17Q2
2017-01-10 11:04 eduardo_Argal Note Added: 0093294
2017-01-14 16:01 hgbot Checkin
2017-01-14 16:01 hgbot Note Added: 0093562
2017-01-14 16:01 hgbot Status new => resolved
2017-01-14 16:01 hgbot Resolution open => fixed
2017-01-14 16:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d373a0c59bde890c3e48a420d19ecdc062da83d0 [^]
2017-01-14 16:33 mtaal Review Assigned To => Sandrahuguet
2017-01-14 16:33 mtaal Note Added: 0093563
2017-01-25 11:12 mtaal Note Added: 0093815
2017-01-26 15:49 mtaal Note Added: 0093846
2017-01-27 12:25 Sandrahuguet Note Added: 0093879
2017-01-27 12:25 Sandrahuguet Status resolved => closed
2017-01-27 12:25 Sandrahuguet Fixed in Version => RR17Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker