Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0034253
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-10-20 17:352016-11-12 18:56
ReporterdaniOpenbravoView Statuspublic 
Assigned Tomtaal 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisiona859a140bf37
ProjectionnoneETAnoneTarget Version
OSLinux 64 bitDatabasePostgreSQLJava version
OS Version14.04Database version9.3Ant version
Product VersionSCM revision 
Review Assigned ToAugustoMauch
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0034253: [STORE SERVER 1985] Document sequence of invoices is not synchronized so invoices doc number can be duplicated.

DescriptionNext assign number of Document sequence (invoices) is not synchronized when CS turns from offline to online, so invoices doc number can be duplicated in orders flows and pickings can not be created in online mode.
Steps To Reproduce** CS ONLINE & SS ONLINE: [CS=52.17.253.61 ; SS=52.31.227.242]
1. Log in Backend: check that Document Sequence "214 AR Invoice" has the same "Next Assigned number" in both CS and SS. Imagine that this next number is: 1000291.

** CS OFFLINE & SS ONLINE:
1. Log in Web POS: (52.31.227.242)
2. Layaway this receipt.
3. Select product "Victor" and add it to the ticket with delivery condition: "Deferred carried away".
4. Pay the ticket.
5. Click on "Prepare" in order preparation.
6. Select the order that has just been created and click on "Prepare selected".
7. Go to dropdown menu and select "Pickings" option.
8. Assign user.
9. Confirm All.
10. Deliver.
11. Close the picking. At this point, check that the order has been created with its shipment and invoice (invoice number is 1000291, so Next Assign Number in document sequence is: 1000292).

** CS ONLINE & SS ONLINE:
1. Log in backend of CS.
2. Go to Document Sequence "214 AR Invoice" and take a look at "Next Assigned number": it will be: 1000291 (It has not been synchronized!!), so there are several consequences:
- Try to repeat all steps from 1 to 11: realize that an error is raised at step 11 when trying to close the picking as the invoice that is going to be created would have the same document number: 1000291.
- However, try to create a ticket (invoicing it): the invoice will be created with duplicated document number: 1000291.
TagsSER-QA
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to design defect 0034329RR17Q2 closedmtaal Support manually decrease of next assigned ad_sequence and replication to store servers 

-  Notes
(0090751)
hgbot (developer)
2016-10-21 10:45

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: 4d6e4701609906247ef43a42c629b8aa5fb67b31
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Fri Oct 21 10:45:39 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/4d6e4701609906247ef43a42c629b8aa5fb67b31 [^]

Fixes issue 34253: [STORE SERVER 1985] Document sequence of invoices is not synchronized so invoices doc number can be duplicated.
Make document sequence bidirectional and when synchronizing prevent updating next nummer to lower value

---
M src-db/database/sourcedata/STRSYNC_SYNCHRONIZEDTABLE.xml
A src/org/openbravo/retail/storeserver/synchronization/DocumentSequenceWriterFilterAdapter.java
---
(0090867)
AugustoMauch (manager)
2016-10-25 15:20

 Two things to review:
- The DatabaseWriterFilterAdapter should be NO-OP when the data event type is an insertion
- It is not clear whether it should be allowed to modify the Next Assigned Number field (currentnext column) of AD_COLUMN. If it is not allowed, than an event handler should be implemented to prevent this change in the ERP. If it is allowed, then the DatabaseWriterFilterAdapter should be modified, because the change would not be synchronized.
(0090868)
mtaal (manager)
2016-10-25 15:21

 Additional comment:
To support a reset of document number to the start we should allow a large decrease when updating the store from central. But not the other way around.
(0090979)
mtaal (manager)
2016-10-28 09:32

 The support for resetting next assigned number in this case is covered in the related issue.
(0091010)
hgbot (developer)
2016-10-29 20:15

 Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: a859a140bf377f926e9e6bb6dc4270bbfb2eeaf4
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Oct 29 20:11:03 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/a859a140bf377f926e9e6bb6dc4270bbfb2eeaf4 [^]

Fixes issue 34253: [STORE SERVER 1985] Document sequence of invoices is not synchronized so invoices doc number can be duplicated.
Skip inserts data replication requests

---
M src/org/openbravo/retail/storeserver/synchronization/DocumentSequenceWriterFilterAdapter.java
---
(0091414)
AugustoMauch (manager)
2016-11-12 18:56

 Code reviewed and verified in [1]@a1311dd247c9

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization [^]

- Issue History
Date Modified Username Field Change
2016-10-20 17:35 daniOpenbravo New Issue
2016-10-20 17:35 daniOpenbravo Assigned To => mtaal
2016-10-20 17:35 daniOpenbravo Resolution time => 1477519200
2016-10-20 17:35 daniOpenbravo Triggers an Emergency Pack => No
2016-10-20 17:35 daniOpenbravo Issue Monitored: daniOpenbravo
2016-10-20 17:35 daniOpenbravo Tag Attached: SER-QA
2016-10-20 17:47 daniOpenbravo Summary [STORE SERVER] Document sequence of invoices is not synchronized so invoices doc number can be duplicated. => [STORE SERVER 1985] Document sequence of invoices is not synchronized so invoices doc number can be duplicated.
2016-10-21 10:45 hgbot Checkin
2016-10-21 10:45 hgbot Note Added: 0090751
2016-10-21 10:45 hgbot Status new => resolved
2016-10-21 10:45 hgbot Resolution open => fixed
2016-10-21 10:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/4d6e4701609906247ef43a42c629b8aa5fb67b31 [^]
2016-10-22 15:57 mtaal Review Assigned To => AugustoMauch
2016-10-25 15:20 AugustoMauch Note Added: 0090867
2016-10-25 15:20 AugustoMauch Status resolved => new
2016-10-25 15:20 AugustoMauch Resolution fixed => open
2016-10-25 15:21 mtaal Note Added: 0090868
2016-10-28 09:31 mtaal Relationship added related to 0034329
2016-10-28 09:32 mtaal Note Added: 0090979
2016-10-29 20:15 hgbot Checkin
2016-10-29 20:15 hgbot Note Added: 0091010
2016-10-29 20:15 hgbot Status new => resolved
2016-10-29 20:15 hgbot Resolution open => fixed
2016-10-29 20:15 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/4d6e4701609906247ef43a42c629b8aa5fb67b31 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/a859a140bf377f926e9e6bb6dc4270bbfb2eeaf4 [^]
2016-11-12 18:56 AugustoMauch Note Added: 0091414
2016-11-12 18:56 AugustoMauch Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker