Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0034329Retail ModulesStoreServerpublic2016-10-28 09:312017-01-27 12:25
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR17Q2Fixed in VersionRR17Q2 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0034329: Support manually decrease of next assigned ad_sequence and replication to store servers
DescriptionContext from the related issue:
- the ad_sequence table is now replicated bi-directional from central to store and vice versa
- when store is not connected to central it is possible that the same ad_sequence has different next assigned numbers in store versus central
- this happens when the ad_sequence is shared/used by different stores
- this is not a problem as long as document numbers of documents have a store-specific prefix
- still 'holes' will exist between document numbers of one store, but afaik this is okay
- when a store connects again to central it was possible that the replication would lower the next assigned number in either direction
- to prevent this the replication logic ignores updates which would lower the document number. This was implemented in the related issue.
- this replication logic and prevent-decrease-next-assigned-number logic is all done in the store server module, so the standard retail-erp is not changed

However:
- there are functional cases where people want to reset the next assigned number manually on purpose
- this would now not be replicated to the stores (as the replication logic ignores these decrease-next-assigned-number updates)

To solve this, this issue proposes:
- add a flag in ad_sequence: Update assigned number in stores
- show the flag in the window/tab, editable
- add an event handler which prevents lowering the next assigned number if this flag is not checked
- when this flag is set then the decrease of next assigned number is replicated from central to store
- the stores when receiving the update will set the flag back to unchecked
- this flag/logic will be implemented in the store server module, no change in core/central
Steps To ReproduceSee related issue
Proposed SolutionSee Description
Additional Information
TagsNo tags attached.
Relationships
related to defect 0034253 closed mtaal [STORE SERVER 1985] Document sequence of invoices is not synchronized so invoices doc number can be duplicated. 
blocks defect 0034530 closed mtaal Invoice document number does not get synced to the central server in offline mode 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2016-10-28 09:31mtaalNew Issue
2016-10-28 09:31mtaalAssigned To => mtaal
2016-10-28 09:31mtaalOBNetwork customer => No
2016-10-28 09:31mtaalTriggers an Emergency Pack => No
2016-10-28 09:31mtaalRelationship addedrelated to 0034253
2016-11-18 09:00mtaalSummarySupport manually decrease of next assigned module and replication to store servers => Support manually decrease of next assigned ad_sequence and replication to store servers
2016-11-18 09:00mtaalDescription Updatedbug_revision_view_page.php?rev_id=13808#r13808
2016-11-18 09:04mtaalRelationship addedblocks 0034530
2016-12-29 11:51mtaalTarget VersionRR17Q1 => RR17Q2
2017-01-10 11:04eduardo_ArgalNote Added: 0093294
2017-01-14 16:01hgbotCheckin
2017-01-14 16:01hgbotNote Added: 0093562
2017-01-14 16:01hgbotStatusnew => resolved
2017-01-14 16:01hgbotResolutionopen => fixed
2017-01-14 16:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d373a0c59bde890c3e48a420d19ecdc062da83d0 [^]
2017-01-14 16:33mtaalReview Assigned To => Sandrahuguet
2017-01-14 16:33mtaalNote Added: 0093563
2017-01-25 11:12mtaalNote Added: 0093815
2017-01-26 15:49mtaalNote Added: 0093846
2017-01-27 12:25SandrahuguetNote Added: 0093879
2017-01-27 12:25SandrahuguetStatusresolved => closed
2017-01-27 12:25SandrahuguetFixed in Version => RR17Q2

Notes
(0093294)
eduardo_Argal   
2017-01-10 11:04   
I like the flag approach to be able to manually decrease the sequence number. This reset of sequence use to happen every year (both sequence prefix and sequence number can be updated manually)
(0093562)
hgbot   
2017-01-14 16:01   
Repository: erp/pmods/org.openbravo.retail.storeserver.synchronization
Changeset: d373a0c59bde890c3e48a420d19ecdc062da83d0
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Sat Jan 14 16:01:03 2017 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/rev/d373a0c59bde890c3e48a420d19ecdc062da83d0 [^]

Fixes issue 34329: Support manually decrease of next assigned ad_sequence and replication to store servers
Add new button and internal column to replicate sequence number also when it decreases

---
M src-db/database/sourcedata/AD_COLUMN.xml
M src-db/database/sourcedata/AD_ELEMENT.xml
M src-db/database/sourcedata/AD_FIELD.xml
M src-db/database/sourcedata/OBUIAPP_PROCESS.xml
M src/org/openbravo/retail/storeserver/synchronization/DocumentSequenceWriterFilterAdapter.java
A src-db/database/model/modifiedTables/AD_SEQUENCE.xml
A src/org/openbravo/retail/storeserver/synchronization/process/DocumentSequenceReplicateNextNumber.java
---
(0093563)
mtaal   
2017-01-14 16:33   
The solution is not a flag but a button to be pressed:
http://wiki.openbravo.com/wiki/Retail:Store_Server#Replicating_Document_Sequence_Number_Changes [^]
(0093815)
mtaal   
2017-01-25 11:12   
To test the solution:
1- install multi-server
2- check that replication works
3- go to document number sequence table, find a document sequence which is also present in a store
4- increase the next assigned number
5- check that it gets replicated to the store
6- decrease the next assigned number
7- check that it does not get replicated to the store
8- press the replicate document sequence number button
9- check that the document sequence number change is replicated to the store
(0093846)
mtaal   
2017-01-26 15:49   
Note that for the document numbers maintained internally in the pos terminal there is already code to prevent decrease of the next assigned number:

https://code.openbravo.com/erp/pmods/org.openbravo.retail.storeserver.synchronization/file/c3696ff1abb8/src/org/openbravo/retail/storeserver/synchronization/OrderDocumentNoWriterFilterAdapter.java#l85 [^]

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/7f1ed45fd251/src/org/openbravo/retail/posterminal/OrderLoader.java#l1558 [^]
(0093879)
Sandrahuguet   
2017-01-27 12:25   
reviewed and tested