Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033555
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSminorhave not tried2016-07-28 13:062016-08-17 09:40
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR16Q4
StatusclosedFix in branchFixed in SCM revision8b8fcaec12a9
ProjectionnoneETAnoneTarget VersionRR16Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToSandrahuguet
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033555: Prevent query for posterminal in POSImportEntryProcessor

DescriptionThe POSImportEntryProcessor sets the organization of the import entry from the posterminal ([1]). This causes the system to do an extra query (for posterminal). This should preferably be prevented.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/89c3e6d2156c/src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java#l81 [^]
Steps To ReproduceLogin into webpos
Create and submit ticket
Check POSImportEntryProcessor (by putting breakpoint there and enable logging for sql queries)
Proposed SolutionUse the orgid present in the json. Do this for the cases where the organization can be found.

Be also backward compatible by supporting current approach if there is no organization in the json.

Attached diff can not be used completely, it needs to be adapted to also support other data types.
TagsNo tags attached.
Attached Filesdiff file icon 33555.diff [^] (3,272 bytes) 2016-08-07 11:59 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0033694RR16Q4 closedmtaal POSImportEntryProcessor: log the json in case not all relevant information can be extracted from it 
related to backport 0033701RR16Q3.1 closedmtaal NPE in POSImportEntryProcessor when the posterminal json property has an illegal value 

-  Notes
(0088909)
hgbot (developer)
2016-08-09 06:37

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8b8fcaec12a9f507eef432ed2d6d75bfda7fbe6f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 09 06:36:51 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8fcaec12a9f507eef432ed2d6d75bfda7fbe6f [^]

Fixes issue 33555: Prevent query for posterminal in POSImportEntryProcessor
Use proxy to prevent early load and read the organization id from the json if present.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---
(0089098)
hgbot (developer)
2016-08-15 19:01

Repository: retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal
Changeset: 93c00036438813a470c2399a012067f3efdeffa8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 19:01:22 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal/rev/93c00036438813a470c2399a012067f3efdeffa8 [^]

Fixes issue 33701: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value
If no posterminal id can be found then still create the import entry but with status error.
Also use static finals were appropriate.
The changeset for issue 33555 has been included in the commit as it seemed better to keep than to rework the
code to a new version.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---
(0089100)
hgbot (developer)
2016-08-15 19:39

Repository: retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal
Changeset: 0eadefd4c5c3e835e70a2873c04b6615e871509a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 19:39:08 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/0eadefd4c5c3e835e70a2873c04b6615e871509a [^]

Fixes issue 33702: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value
If no posterminal id can be found then still create the import entry but with status error.
Also use static finals were appropriate.
The changeset for issue 33555 has been included in the commit as it seemed better to keep than to rework the
code to a new version.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---
(0089170)
Sandrahuguet (developer)
2016-08-17 09:40

reviewed and tested

- Issue History
Date Modified Username Field Change
2016-07-28 13:06 mtaal New Issue
2016-07-28 13:06 mtaal Assigned To => mtaal
2016-07-28 13:06 mtaal File Added: posimportentryprocessor-1.diff
2016-07-28 13:06 mtaal Triggers an Emergency Pack => No
2016-08-01 16:09 shuehner Issue Monitored: shuehner
2016-08-07 11:59 mtaal File Deleted: posimportentryprocessor-1.diff
2016-08-07 11:59 mtaal File Added: 33555.diff
2016-08-09 06:37 hgbot Checkin
2016-08-09 06:37 hgbot Note Added: 0088909
2016-08-09 06:37 hgbot Status new => resolved
2016-08-09 06:37 hgbot Resolution open => fixed
2016-08-09 06:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8fcaec12a9f507eef432ed2d6d75bfda7fbe6f [^]
2016-08-12 09:47 shuehner Relationship added related to 0033694
2016-08-15 19:00 mtaal Relationship added related to 0033701
2016-08-15 19:01 hgbot Checkin
2016-08-15 19:01 hgbot Note Added: 0089098
2016-08-15 19:39 hgbot Checkin
2016-08-15 19:39 hgbot Note Added: 0089100
2016-08-16 10:29 mtaal Review Assigned To => Sandrahuguet
2016-08-17 09:40 Sandrahuguet Note Added: 0089170
2016-08-17 09:40 Sandrahuguet Status resolved => closed
2016-08-17 09:40 Sandrahuguet Fixed in Version => RR16Q4


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker