Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0033701
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajorhave not tried2016-08-12 09:552016-08-30 11:22
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR16Q3.1
StatusclosedFix in branchFixed in SCM revision93c000364388
ProjectionnoneETAnoneTarget VersionRR16Q3.1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033701: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value

DescriptionSee stacktrace [1], this causes the import entry from not being saved at all. Change the code [2] to set the status to error and a warning messages.

[1]
Caused by: org.openbravo.base.exception.OBException: java.lang.NullPointerException
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.createImportEntry(DataSynchronizationProcess.java:89)
        at org.openbravo.mobile.core.process.DataSynchronizationProcess.executeCreateImportEntry(DataSynchronizationProcess.java:115)
        ... 41 more
Caused by: java.lang.NullPointerException
        at org.openbravo.retail.posterminal.importprocess.POSImportEntryProcessor.onSave(POSImportEntryProcessor.java:79)
        at sun.reflect.GeneratedMethodAccessor445.invoke(Unknown Source)

[2]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/060b566c4098/src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java [^]
Steps To ReproduceRun retail
Put breakpoint in java code in POSImportEntryProcessor
Login to webpos
Do some actions
At breakpoint change the json to set the posTerminalId to the value "null" (note use the string value "null" so not NULL or null)
Proposed Solutionlog warning
set status to Error if no posterminal can be found
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
related to design defect 0033555RR16Q4 closedmtaal Prevent query for posterminal in POSImportEntryProcessor 
blocks defect 0033696RR16Q4 closedmtaal NPE in POSImportEntryProcessor when the posterminal json property has an illegal value 

-  Notes
(0089099)
hgbot (developer)
2016-08-15 19:01

Repository: retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal
Changeset: 93c00036438813a470c2399a012067f3efdeffa8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 19:01:22 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal/rev/93c00036438813a470c2399a012067f3efdeffa8 [^]

Fixes issue 33701: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value
If no posterminal id can be found then still create the import entry but with status error.
Also use static finals were appropriate.
The changeset for issue 33555 has been included in the commit as it seemed better to keep than to rework the
code to a new version.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---

- Issue History
Date Modified Username Field Change
2016-08-12 12:46 Orekaria Type defect => backport
2016-08-12 12:46 Orekaria Target Version RR16Q4 => RR16Q3.2
2016-08-15 19:00 mtaal Relationship added related to 0033555
2016-08-15 19:01 hgbot Checkin
2016-08-15 19:01 hgbot Note Added: 0089099
2016-08-15 19:01 hgbot Status scheduled => resolved
2016-08-15 19:01 hgbot Resolution open => fixed
2016-08-15 19:01 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/77435e4a7b40ba41925cf9d53712db38b242675c [^] => http://code.openbravo.com/retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal/rev/93c00036438813a470c2399a012067f3efdeffa8 [^]
2016-08-29 13:09 mtaal Target Version RR16Q3.2 => RR16Q3.1
2016-08-30 11:22 guilleaer Review Assigned To migueldejuana => guilleaer
2016-08-30 11:22 guilleaer Status resolved => closed
2016-08-30 11:22 guilleaer Fixed in Version => RR16Q3.1


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker