Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033555Retail ModulesWeb POSpublic2016-07-28 13:062016-08-17 09:40
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR16Q4Fixed in VersionRR16Q4 
Merge Request Status
Review Assigned ToSandrahuguet
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033555: Prevent query for posterminal in POSImportEntryProcessor
DescriptionThe POSImportEntryProcessor sets the organization of the import entry from the posterminal ([1]). This causes the system to do an extra query (for posterminal). This should preferably be prevented.

[1]
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/89c3e6d2156c/src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java#l81 [^]
Steps To ReproduceLogin into webpos
Create and submit ticket
Check POSImportEntryProcessor (by putting breakpoint there and enable logging for sql queries)
Proposed SolutionUse the orgid present in the json. Do this for the cases where the organization can be found.

Be also backward compatible by supporting current approach if there is no organization in the json.

Attached diff can not be used completely, it needs to be adapted to also support other data types.
Additional Information
TagsNo tags attached.
Relationships
related to design defect 0033694RR16Q4 closed mtaal POSImportEntryProcessor: log the json in case not all relevant information can be extracted from it 
related to backport 0033701RR16Q3.1 closed mtaal NPE in POSImportEntryProcessor when the posterminal json property has an illegal value 
Attached Filesdiff 33555.diff (3,272) 2016-08-07 11:59
https://issues.openbravo.com/file_download.php?file_id=9687&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-07-28 13:06mtaalNew Issue
2016-07-28 13:06mtaalAssigned To => mtaal
2016-07-28 13:06mtaalFile Added: posimportentryprocessor-1.diff
2016-07-28 13:06mtaalTriggers an Emergency Pack => No
2016-08-01 16:09shuehnerIssue Monitored: shuehner
2016-08-07 11:59mtaalFile Deleted: posimportentryprocessor-1.diff
2016-08-07 11:59mtaalFile Added: 33555.diff
2016-08-09 06:37hgbotCheckin
2016-08-09 06:37hgbotNote Added: 0088909
2016-08-09 06:37hgbotStatusnew => resolved
2016-08-09 06:37hgbotResolutionopen => fixed
2016-08-09 06:37hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8fcaec12a9f507eef432ed2d6d75bfda7fbe6f [^]
2016-08-12 09:47shuehnerRelationship addedrelated to 0033694
2016-08-15 19:00mtaalRelationship addedrelated to 0033701
2016-08-15 19:01hgbotCheckin
2016-08-15 19:01hgbotNote Added: 0089098
2016-08-15 19:39hgbotCheckin
2016-08-15 19:39hgbotNote Added: 0089100
2016-08-16 10:29mtaalReview Assigned To => Sandrahuguet
2016-08-17 09:40SandrahuguetNote Added: 0089170
2016-08-17 09:40SandrahuguetStatusresolved => closed
2016-08-17 09:40SandrahuguetFixed in Version => RR16Q4

Notes
(0088909)
hgbot   
2016-08-09 06:37   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 8b8fcaec12a9f507eef432ed2d6d75bfda7fbe6f
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Aug 09 06:36:51 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/8b8fcaec12a9f507eef432ed2d6d75bfda7fbe6f [^]

Fixes issue 33555: Prevent query for posterminal in POSImportEntryProcessor
Use proxy to prevent early load and read the organization id from the json if present.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---
(0089098)
hgbot   
2016-08-15 19:01   
Repository: retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal
Changeset: 93c00036438813a470c2399a012067f3efdeffa8
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 19:01:22 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q3.1/org.openbravo.retail.posterminal/rev/93c00036438813a470c2399a012067f3efdeffa8 [^]

Fixes issue 33701: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value
If no posterminal id can be found then still create the import entry but with status error.
Also use static finals were appropriate.
The changeset for issue 33555 has been included in the commit as it seemed better to keep than to rework the
code to a new version.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---
(0089100)
hgbot   
2016-08-15 19:39   
Repository: retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal
Changeset: 0eadefd4c5c3e835e70a2873c04b6615e871509a
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Mon Aug 15 19:39:08 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2.2/org.openbravo.retail.posterminal/rev/0eadefd4c5c3e835e70a2873c04b6615e871509a [^]

Fixes issue 33702: NPE in POSImportEntryProcessor when the posterminal json property has an illegal value
If no posterminal id can be found then still create the import entry but with status error.
Also use static finals were appropriate.
The changeset for issue 33555 has been included in the commit as it seemed better to keep than to rework the
code to a new version.

---
M src/org/openbravo/retail/posterminal/importprocess/POSImportEntryProcessor.java
---
(0089170)
Sandrahuguet   
2016-08-17 09:40   
reviewed and tested