Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033379
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Modules] FIFO Costing Algorithmmajoralways2016-06-29 18:572016-07-14 14:16
ReporterngarciaView Statuspublic 
Assigned Tomarkmm82 
PriorityurgentResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7d5b2828e4d1
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Regression date
Regression introduced by commit
Regression level
Review Assigned Toaferraz
Support ticket42645
OBNetwork customerOBPS
Regression introduced in release
Summary

0033379: Cannot validate a new Costing Rule after validating a costing rule with FIFO algorithm

DescriptionCannot validate a new Costing Rule after validating a costing rule with FIFO algorithm
Steps To ReproduceAs system admin role:
   Install FIFO Costing Algorithm module
As group admin role:
   Check there exists stock for an organization
   Validate a costing rule with FIFO Costing Algorithm for that organization
   Launch the Costing Background process and check it finishes successfully
   Validate a new costing rule for the same organization with Average Algorithm
   The following error message is shown: Session is closed!
   The log shows:
      ERROR org.openbravo.costing.CostingUtils -
org.openbravo.base.exception.OBException: @OBWFA_NotOutgoingTransaction@ @Organization@: F&B US, Inc., @Product@: Orange Juice bio, @Date@: 29-06-2016
    at org.openbravo.costing.algorithm.fifo.FifoAlgorithm.getOutgoingTransactionCost(FifoAlgorithm.java:152)
    at org.openbravo.costing.CostingAlgorithm.getInventoryDecreaseCost(CostingAlgorithm.java:363)
    at org.openbravo.costing.CostingAlgorithm.getInventoryClosingCost(CostingAlgorithm.java:397)
    at org.openbravo.costing.CostingAlgorithm.getTransactionCost(CostingAlgorithm.java:127)
    at org.openbravo.costing.algorithm.fifo.FifoAlgorithm.getTransactionCost(FifoAlgorithm.java:123)
    at org.openbravo.costing.CostingServer.process(CostingServer.java:106)
    at org.openbravo.costing.CostingUtils.getTransactionCost(CostingUtils.java:113)
    at org.openbravo.costing.CostingRuleProcess.updateInventoriesCostAndProcessInitInventories(CostingRuleProcess.java:582)
    at org.openbravo.costing.CostingRuleProcess.execute(CostingRuleProcess.java:133)
    at org.openbravo.costing.CostingRuleProcessActionHandler.doExecute(CostingRuleProcessActionHandler.java:66)
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
has duplicate defect 0034671 closedTriage Omni OMS Modules "InventoryClosing" transaction type needs to be included in "isOutgoingTrx" method in FifoAlgorithm,java 
related to defect 0033599 closednonofrancisco Openbravo ERP Cannot validate a new Costing Rule after validating a costing rule with FIFO algorithm if there exists negative stock 

-  Notes
(0088486)
hgbot (developer)
2016-07-14 14:13

 Repository: erp/pmods/org.openbravo.costing.algorithm.fifo
Changeset: 7d5b2828e4d1f6dac01421189bae77298d5b3514
Author: Mark <markmm82 <at> gmail.com>
Date: Wed Jul 13 14:29:59 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.costing.algorithm.fifo/rev/7d5b2828e4d1f6dac01421189bae77298d5b3514 [^]

Fixes issue 33379: Allow to validate new Costing Rule after run FIFO algorithm

Now is possible to validate a new Costing Rule after validating a costing rule with FIFO algorithm. The InventoryOpening type was added to the list checked by the isIncomingTrx method, and similar to InventoryClosing to the isOutcomingTrx. This way when a new costing rule run after validate previous costing rule with fifo algorithm, transactions of InventoryOpening creates entries inside OBWFA_Input_Stack. Then when the average costing rule is validated the transactions of type = InventoryClosing will use these entries and the process finishes well.

---
M src/org/openbravo/costing/algorithm/fifo/FifoAlgorithm.java
---
(0088487)
hgbot (developer)
2016-07-14 14:13

 Repository: erp/pmods/org.openbravo.costing.algorithm.fifo
Changeset: b88be31b1dfcc622ea5318bf85daa9b41ba08573
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Thu Jul 14 14:03:26 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.costing.algorithm.fifo/rev/b88be31b1dfcc622ea5318bf85daa9b41ba08573 [^]

Related to issue 33379: Update module version

---
M src-db/database/sourcedata/AD_MODULE.xml
---
(0088488)
aferraz (viewer)
2016-07-14 14:16

 Code review + Testing OK

- Issue History
Date Modified Username Field Change
2016-06-29 18:57 ngarcia New Issue
2016-06-29 18:57 ngarcia Assigned To => Triage Finance
2016-06-29 18:57 ngarcia OBNetwork customer => Yes
2016-06-29 18:57 ngarcia Modules => Core
2016-06-29 18:57 ngarcia Support ticket => 42645
2016-06-29 18:57 ngarcia Resolution time => 1468965600
2016-06-29 18:57 ngarcia Triggers an Emergency Pack => No
2016-06-29 18:59 ngarcia Issue Monitored: networkb
2016-06-30 14:56 aferraz Assigned To Triage Finance => markmm82
2016-07-11 21:04 markmm82 Status new => scheduled
2016-07-13 18:11 ngarcia Priority immediate => urgent
2016-07-14 14:13 hgbot Checkin
2016-07-14 14:13 hgbot Note Added: 0088486
2016-07-14 14:13 hgbot Status scheduled => resolved
2016-07-14 14:13 hgbot Resolution open => fixed
2016-07-14 14:13 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.costing.algorithm.fifo/rev/7d5b2828e4d1f6dac01421189bae77298d5b3514 [^]
2016-07-14 14:13 hgbot Checkin
2016-07-14 14:13 hgbot Note Added: 0088487
2016-07-14 14:15 aferraz Project Openbravo ERP => Modules
2016-07-14 14:16 aferraz Category 04. Warehouse management => FIFO Costing Algorithm
2016-07-14 14:16 aferraz Review Assigned To => aferraz
2016-07-14 14:16 aferraz Note Added: 0088488
2016-07-14 14:16 aferraz Status resolved => closed
2016-08-02 14:19 ngarcia Relationship added related to 0033599
2016-12-01 19:51 aferraz Relationship added related to 0034671
2016-12-02 15:06 aferraz Relationship deleted related to 0034671
2016-12-02 15:06 aferraz Relationship added has duplicate 0034671

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker