0034671: "InventoryClosing" transaction type needs to be included in "isOutgoingTrx" method in FifoAlgorithm,java

Description

When using FIFO algorithm and trying to validate a different costing rule, following error is raised in the log : @OBWFA_NotOutgoingTransaction@ (by getOutgoingTransactionCost method). Problem is that "InventoryClosing" transaction type is not considering as outgoing transaction

Steps To Reproduce

1. In an instance using FIFO algorithm
2. Access Costing Rule window and create new rule for Average algorithm
3. Run "Validate costing rule" process and realize that error is raised
4. Check the log and you will find '@OBWFA_NotOutgoingTransaction@'

Proposed Solution

private boolean isOutgoingTrx() {
    switch (trxType) {
    case Shipment:
    case ReceiptReturn:
    case ReceiptNegative:
    case InventoryDecrease:
    case IntMovementFrom:
    case InternalCons:
    case BOMPart:
    case ManufacturingConsumed:
    case InventoryClosing:
      return true;
    default:
      return false;
    }
  }

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

duplicate of	defect	0033379		closed	markmm82	Cannot validate a new Costing Rule after validating a costing rule with FIFO algorithm
blocks	defect	0034670		closed	Triage Omni OMS	CostingServer should check if current algorithm supports adjustments, when trying to adjust remainder value in inventory closing

Notes
There are no notes attached to this issue.

Issue History
Date Modified	Username	Field	Change
2016-12-01 18:14	maite	New Issue
2016-12-01 18:14	maite	Assigned To	=> Triage Finance
2016-12-01 18:14	maite	Resolution time	=> 1482361200
2016-12-01 18:14	maite	Relationship added	blocks 0034670
2016-12-01 19:51	aferraz	Relationship added	related to 0033379
2016-12-02 11:56	aferraz	Review Assigned To	=> aferraz
2016-12-02 11:56	aferraz	Status	new => closed
2016-12-02 11:56	aferraz	Resolution	open => fixed
2016-12-02 15:06	aferraz	Relationship deleted	related to 0033379
2016-12-02 15:06	aferraz	Relationship added	duplicate of 0033379