Anonymous | Login

Project:

News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ]

[ Issue History ] [ Print ]

ID

0033136

Type

Category

Severity

Reproducibility

Date Submitted

Last Update

defect

[Retail Modules] Web POS

minor

have not tried

2016-06-05 13:51

2017-11-30 10:15

Reporter

shuehner

View Status

public

Assigned To

shuehner

Priority

normal

Resolution

fixed

Fixed in Version

RR16Q3

Status

closed

Fix in branch

Fixed in SCM revision

Projection

none

ETA

none

Target Version

OS

Any

Database

Any

Java version

OS Version

Database version

Ant version

Product Version

SCM revision

Review Assigned To

marvintm

Regression level

Regression date

Regression introduced in release

Regression introduced by commit

Triggers an Emergency Pack

No

Summary

0033136: Useless read from c_bpartner_location in Orderloader -> should use Proxy instead

Description

OrderLoader.java in its createOrder method uses following code:

    order.setPartnerAddress(OBDal.getInstance().get(Location.class,
        jsonorder.getJSONObject("bp").getString("locId")));

Reading from c_bp_location here is not required a Proxy should be used instead to pass on the id.

2nd case of same bug later in createShipment function:
    shipment.setPartnerAddress(OBDal.getInstance().get(Location.class,
        jsonorder.getJSONObject("bp").getString("locId")));

Steps To Reproduce

Trace sql's done during OrderLoader.

Tags

33136.diff [^] (701 bytes) 2016-06-05 13:53 [Show Content] [Hide Content]

diff -r cad0c61deb64 src/org/openbravo/retail/posterminal/OrderLoader.java
--- a/src/org/openbravo/retail/posterminal/OrderLoader.java	Fri Jun 03 13:45:51 2016 +0200
+++ b/src/org/openbravo/retail/posterminal/OrderLoader.java	Sun Jun 05 13:52:53 2016 +0200
@@ -1441,7 +1441,7 @@
         jsonorder.getString("documentType")));
     order.setAccountingDate(order.getOrderDate());
     order.setScheduledDeliveryDate(order.getOrderDate());
-    order.setPartnerAddress(OBDal.getInstance().get(Location.class,
+    order.setPartnerAddress(OBDal.getInstance().getProxy(Location.class,
         jsonorder.getJSONObject("bp").getString("locId")));
     order.setInvoiceAddress(order.getPartnerAddress());

33136_part2.diff [^] (680 bytes) 2016-06-05 14:34 [Show Content] [Hide Content]

diff -u b/src/org/openbravo/retail/posterminal/OrderLoader.java b/src/org/openbravo/retail/posterminal/OrderLoader.java
--- b/src/org/openbravo/retail/posterminal/OrderLoader.java	Sun Jun 05 14:33:52 2016 +0200
+++ b/src/org/openbravo/retail/posterminal/OrderLoader.java	Sun Jun 05 14:34:00 2016 +0200
@@ -1246,7 +1246,7 @@
       shipment.setAccountingDate(order.getOrderDate());
     }
 
-    shipment.setPartnerAddress(OBDal.getInstance().get(Location.class,
+    shipment.setPartnerAddress(OBDal.getInstance().getProxy(Location.class,
         jsonorder.getJSONObject("bp").getString("locId")));
     shipment.setSalesTransaction(true);
     shipment.setDocumentStatus("CO");

33136_part3.diff [^] (735 bytes) 2016-06-05 15:39 [Show Content] [Hide Content]

diff -u b/src/org/openbravo/retail/posterminal/OrderLoader.java b/src/org/openbravo/retail/posterminal/OrderLoader.java
--- b/src/org/openbravo/retail/posterminal/OrderLoader.java	Sun Jun 05 15:38:47 2016 +0200
+++ b/src/org/openbravo/retail/posterminal/OrderLoader.java	Sun Jun 05 15:39:12 2016 +0200
@@ -925,7 +925,7 @@
     invoice.setDocumentAction("RE");
     invoice.setAPRMProcessinvoice("RE");
     invoice.setSalesOrder(order);
-    invoice.setPartnerAddress(OBDal.getInstance().get(Location.class,
+    invoice.setPartnerAddress(OBDal.getInstance().getProxy(Location.class,
         jsonorder.getJSONObject("bp").getString("locId")));
     invoice.setProcessed(true);
     invoice.setPaymentMethod(order.getPaymentMethod());

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

closed

LogClientLoader does useless select to ad_user (and indirectly ad_language) on every insert

Notes
(0087125) hgbot (developer) 2016-06-09 15:47	Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: e19a0fea772752d11f0921ef5db809f142b314ff Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Tue Jun 07 17:04:42 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e19a0fea772752d11f0921ef5db809f142b314ff [^] Fixed 33136. Avoid read from c_bpartner_location by using Proxy Don't read 3 times from c_bpartner_location but use Proxy instead to avoid select to database which is not needed here. --- M src/org/openbravo/retail/posterminal/OrderLoader.java ---

Issue History
Date Modified	Username	Field	Change
2016-06-05 13:51	shuehner	New Issue
2016-06-05 13:51	shuehner	Assigned To	=> Retail
2016-06-05 13:51	shuehner	Triggers an Emergency Pack	=> No
2016-06-05 13:51	shuehner	Relationship added	related to 0033135
2016-06-05 13:52	shuehner	Tag Attached: Performance
2016-06-05 13:53	shuehner	File Added: 33136.diff
2016-06-05 14:34	shuehner	Description Updated	View Revisions
2016-06-05 14:34	shuehner	File Added: 33136_part2.diff
2016-06-05 15:39	shuehner	File Added: 33136_part3.diff
2016-06-09 15:47	hgbot	Checkin
2016-06-09 15:47	hgbot	Note Added: 0087125
2016-06-09 15:47	hgbot	Status	new => resolved
2016-06-09 15:47	hgbot	Resolution	open => fixed
2016-06-09 15:47	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e19a0fea772752d11f0921ef5db809f142b314ff [^]
2016-06-09 15:51	shuehner	Assigned To	Retail => shuehner
2016-06-09 15:51	shuehner	Review Assigned To	=> marvintm
2016-06-10 09:07	marvintm	Status	resolved => closed
2017-11-30 10:15	shuehner	Fixed in Version	=> RR16Q3

Copyright © 2000 - 2009 MantisBT Group