Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0033135
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSminorhave not tried2016-06-05 13:402017-11-30 10:36
ReportershuehnerView Statuspublic 
Assigned Toshuehner 
PrioritynormalResolutionfixedFixed in VersionRR16Q3
StatusclosedFix in branchFixed in SCM revision5d366c012ee8
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0033135: LogClientLoader does useless select to ad_user (and indirectly ad_language) on every insert

DescriptionThe updateAuditInfo method in LogClientLoader.java uses OBDal.getInstance().get instead of a Proxy triggering 1 select to ad_user (and dal indirectly a 2nd select to ad_language).

Using a proxy avoid both useless reads from the database.
Steps To ReproduceTrace sql's done by i.e. setting log_min_duration_statement = 0 and trigger LogClientLoader
TagsPerformance
Attached Filesdiff file icon 33135.diff [^] (621 bytes) 2016-06-05 13:44 [Show Content]

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0033136 closedshuehner Useless read from c_bpartner_location in Orderloader -> should use Proxy instead 

-  Notes
(0087122)
hgbot (developer)
2016-06-09 15:40

 Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5d366c012ee83ae67b51853d55240aabf9dff19b
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 07 16:59:46 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d366c012ee83ae67b51853d55240aabf9dff19b [^]

Fixed 33135. Avoid reading ad_user by using Proxy object.

Use Proxy for ad_user when saving in LogClientLoader to avoid unnecessary read
from ad_user table.

---
M src/org/openbravo/mobile/core/utils/LogClientLoader.java
---
(0087123)
shuehner (administrator)
2016-06-09 15:41

 This change relies on getting valid ad_user_id as parameters and not some bad wrong values.

- Issue History
Date Modified Username Field Change
2016-06-05 13:40 shuehner New Issue
2016-06-05 13:40 shuehner Assigned To => Retail
2016-06-05 13:40 shuehner OBNetwork customer => No
2016-06-05 13:40 shuehner Triggers an Emergency Pack => No
2016-06-05 13:40 shuehner Tag Attached: Performance
2016-06-05 13:44 shuehner File Added: 33135.diff
2016-06-05 13:51 shuehner Relationship added related to 0033136
2016-06-09 15:40 hgbot Checkin
2016-06-09 15:40 hgbot Note Added: 0087122
2016-06-09 15:40 hgbot Status new => resolved
2016-06-09 15:40 hgbot Resolution open => fixed
2016-06-09 15:40 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d366c012ee83ae67b51853d55240aabf9dff19b [^]
2016-06-09 15:40 shuehner Assigned To Retail => shuehner
2016-06-09 15:41 shuehner Review Assigned To => marvintm
2016-06-09 15:41 shuehner Note Added: 0087123
2016-06-10 09:05 marvintm Status resolved => closed
2017-11-30 10:36 shuehner Fixed in Version => RR16Q3

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker