0033135: LogClientLoader does useless select to ad_user (and indirectly ad_language) on every insert

Description

The updateAuditInfo method in LogClientLoader.java uses OBDal.getInstance().get instead of a Proxy triggering 1 select to ad_user (and dal indirectly a 2nd select to ad_language).

Using a proxy avoid both useless reads from the database.

Steps To Reproduce

Trace sql's done by i.e. setting log_min_duration_statement = 0 and trigger LogClientLoader

Tags

Performance

Attached Files

33135.diff [^] (621 bytes) 2016-06-05 13:44 [Show Content] [Hide Content]

diff -r 9c1b56b5ed2c src/org/openbravo/mobile/core/utils/LogClientLoader.java
--- a/src/org/openbravo/mobile/core/utils/LogClientLoader.java	Fri Jun 03 13:44:23 2016 +0200
+++ b/src/org/openbravo/mobile/core/utils/LogClientLoader.java	Sun Jun 05 13:44:35 2016 +0200
@@ -141,7 +141,7 @@
     if (jsonorder.optString("createdby", null) != null) {
       strUserId = jsonorder.getString("createdby");
     }
-    User createdby = OBDal.getInstance().get(User.class, strUserId);
+    User createdby = OBDal.getInstance().getProxy(User.class, strUserId);
     lc.setCreatedBy(createdby);
     lc.setUpdatedBy(createdby);
   }

Relationships [ Relation Graph ] [ Dependency Graph ]

related to

defect

0033136

closed

shuehner

Useless read from c_bpartner_location in Orderloader -> should use Proxy instead

Notes
(0087122) hgbot (developer) 2016-06-09 15:40	Repository: erp/pmods/org.openbravo.mobile.core Changeset: 5d366c012ee83ae67b51853d55240aabf9dff19b Author: Stefan Hühner <stefan.huehner <at> openbravo.com> Date: Tue Jun 07 16:59:46 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d366c012ee83ae67b51853d55240aabf9dff19b [^] Fixed 33135. Avoid reading ad_user by using Proxy object. Use Proxy for ad_user when saving in LogClientLoader to avoid unnecessary read from ad_user table. --- M src/org/openbravo/mobile/core/utils/LogClientLoader.java ---

(0087123) shuehner (administrator) 2016-06-09 15:41	This change relies on getting valid ad_user_id as parameters and not some bad wrong values.

Issue History
Date Modified	Username	Field	Change
2016-06-05 13:40	shuehner	New Issue
2016-06-05 13:40	shuehner	Assigned To	=> Retail
2016-06-05 13:40	shuehner	Triggers an Emergency Pack	=> No
2016-06-05 13:40	shuehner	Tag Attached: Performance
2016-06-05 13:44	shuehner	File Added: 33135.diff
2016-06-05 13:51	shuehner	Relationship added	related to 0033136
2016-06-09 15:40	hgbot	Checkin
2016-06-09 15:40	hgbot	Note Added: 0087122
2016-06-09 15:40	hgbot	Status	new => resolved
2016-06-09 15:40	hgbot	Resolution	open => fixed
2016-06-09 15:40	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d366c012ee83ae67b51853d55240aabf9dff19b [^]
2016-06-09 15:40	shuehner	Assigned To	Retail => shuehner
2016-06-09 15:41	shuehner	Review Assigned To	=> marvintm
2016-06-09 15:41	shuehner	Note Added: 0087123
2016-06-10 09:05	marvintm	Status	resolved => closed
2017-11-30 10:36	shuehner	Fixed in Version	=> RR16Q3