Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033135Retail ModulesWeb POSpublic2016-06-05 13:402017-11-30 10:36
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033135: LogClientLoader does useless select to ad_user (and indirectly ad_language) on every insert
DescriptionThe updateAuditInfo method in LogClientLoader.java uses OBDal.getInstance().get instead of a Proxy triggering 1 select to ad_user (and dal indirectly a 2nd select to ad_language).

Using a proxy avoid both useless reads from the database.
Steps To ReproduceTrace sql's done by i.e. setting log_min_duration_statement = 0 and trigger LogClientLoader
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0033136 closed shuehner Useless read from c_bpartner_location in Orderloader -> should use Proxy instead 
Attached Filesdiff 33135.diff (621) 2016-06-05 13:44
https://issues.openbravo.com/file_download.php?file_id=9482&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-06-05 13:40shuehnerNew Issue
2016-06-05 13:40shuehnerAssigned To => Retail
2016-06-05 13:40shuehnerOBNetwork customer => No
2016-06-05 13:40shuehnerTriggers an Emergency Pack => No
2016-06-05 13:40shuehnerTag Attached: Performance
2016-06-05 13:44shuehnerFile Added: 33135.diff
2016-06-05 13:51shuehnerRelationship addedrelated to 0033136
2016-06-09 15:40hgbotCheckin
2016-06-09 15:40hgbotNote Added: 0087122
2016-06-09 15:40hgbotStatusnew => resolved
2016-06-09 15:40hgbotResolutionopen => fixed
2016-06-09 15:40hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d366c012ee83ae67b51853d55240aabf9dff19b [^]
2016-06-09 15:40shuehnerAssigned ToRetail => shuehner
2016-06-09 15:41shuehnerReview Assigned To => marvintm
2016-06-09 15:41shuehnerNote Added: 0087123
2016-06-10 09:05marvintmStatusresolved => closed
2017-11-30 10:36shuehnerFixed in Version => RR16Q3

Notes
(0087122)
hgbot   
2016-06-09 15:40   
Repository: erp/pmods/org.openbravo.mobile.core
Changeset: 5d366c012ee83ae67b51853d55240aabf9dff19b
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 07 16:59:46 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.mobile.core/rev/5d366c012ee83ae67b51853d55240aabf9dff19b [^]

Fixed 33135. Avoid reading ad_user by using Proxy object.

Use Proxy for ad_user when saving in LogClientLoader to avoid unnecessary read
from ad_user table.

---
M src/org/openbravo/mobile/core/utils/LogClientLoader.java
---
(0087123)
shuehner   
2016-06-09 15:41   
This change relies on getting valid ad_user_id as parameters and not some bad wrong values.