Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0033136Retail ModulesWeb POSpublic2016-06-05 13:512017-11-30 10:15
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR16Q3 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0033136: Useless read from c_bpartner_location in Orderloader -> should use Proxy instead
DescriptionOrderLoader.java in its createOrder method uses following code:

    order.setPartnerAddress(OBDal.getInstance().get(Location.class,
        jsonorder.getJSONObject("bp").getString("locId")));

Reading from c_bp_location here is not required a Proxy should be used instead to pass on the id.

2nd case of same bug later in createShipment function:
    shipment.setPartnerAddress(OBDal.getInstance().get(Location.class,
        jsonorder.getJSONObject("bp").getString("locId")));
Steps To ReproduceTrace sql's done during OrderLoader.
Proposed Solution
Additional Information
TagsPerformance
Relationships
related to defect 0033135 closed shuehner LogClientLoader does useless select to ad_user (and indirectly ad_language) on every insert 
Attached Filesdiff 33136.diff (701) 2016-06-05 13:53
https://issues.openbravo.com/file_download.php?file_id=9483&type=bug
diff 33136_part2.diff (680) 2016-06-05 14:34
https://issues.openbravo.com/file_download.php?file_id=9486&type=bug
diff 33136_part3.diff (735) 2016-06-05 15:39
https://issues.openbravo.com/file_download.php?file_id=9488&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-06-05 13:51shuehnerNew Issue
2016-06-05 13:51shuehnerAssigned To => Retail
2016-06-05 13:51shuehnerTriggers an Emergency Pack => No
2016-06-05 13:51shuehnerRelationship addedrelated to 0033135
2016-06-05 13:52shuehnerTag Attached: Performance
2016-06-05 13:53shuehnerFile Added: 33136.diff
2016-06-05 14:34shuehnerDescription Updatedbug_revision_view_page.php?rev_id=12314#r12314
2016-06-05 14:34shuehnerFile Added: 33136_part2.diff
2016-06-05 15:39shuehnerFile Added: 33136_part3.diff
2016-06-09 15:47hgbotCheckin
2016-06-09 15:47hgbotNote Added: 0087125
2016-06-09 15:47hgbotStatusnew => resolved
2016-06-09 15:47hgbotResolutionopen => fixed
2016-06-09 15:47hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e19a0fea772752d11f0921ef5db809f142b314ff [^]
2016-06-09 15:51shuehnerAssigned ToRetail => shuehner
2016-06-09 15:51shuehnerReview Assigned To => marvintm
2016-06-10 09:07marvintmStatusresolved => closed
2017-11-30 10:15shuehnerFixed in Version => RR16Q3

Notes
(0087125)
hgbot   
2016-06-09 15:47   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e19a0fea772752d11f0921ef5db809f142b314ff
Author: Stefan Hühner <stefan.huehner <at> openbravo.com>
Date: Tue Jun 07 17:04:42 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e19a0fea772752d11f0921ef5db809f142b314ff [^]

Fixed 33136. Avoid read from c_bpartner_location by using Proxy

Don't read 3 times from c_bpartner_location but use Proxy instead
to avoid select to database which is not needed here.

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---