Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0032886
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Return Receiptmajoralways2016-04-26 15:482016-06-07 17:30
ReporterlorenzofidalgoView Statuspublic 
Assigned Toshivum039 
PriorityimmediateResolutionfixedFixed in VersionRR16Q2
StatusclosedFix in branchFixed in SCM revisiondf01001acab8
ProjectionnoneETAnoneTarget VersionRR16Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Review Assigned Toguilleaer
Regression levelPackaging and release
Regression date
Regression introduced in releasemain
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032886: [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown

DescriptionIn documentation it is written "Since 15Q4 It will NOT be possible to have positive lines in return tickets". In RR16Q2 is still possible to use the "Return Line" button in Return Receipts due to "Return Line" button is not hidden. Only clicking in EDIT tab hides the "Return Line" button.
Using the following "Steps To Reproduce", "Return Line" button does not appear in RR16Q1 or RR15Q4.
Steps To ReproduceA) Can only be reproduced in Q2, not in tip
0-Login POS as vallblanca.
1-In dropdown menu, click "Return this Receipt".
2-Add 1x "Adhesive body warmers".
3-Click the just added product. DEFECT: Check "Return Line" button is still shown. It must not be shown. It is still clickable, so, currently, it is possible to create positive lines in a Return Receipt.

B)
Add product
Select line
Menu > Return this receipt
Verify that the 'Return line' option is shown in the right menu

Note that there is a test called 'I30075_NoPositiveLinesInReturnTickets'
Proposed Solution1) Create a function called 'rearrangeEditButtonBar' (if it does not exists) that decides which buttons should be shown in the buttons' bar and paints them

2) The 'rearrangeEditButtonBar' should be called when:
- A menu option like "Return this receipt" or "Layaway this receipt" is selected
- A line of the receipt is tapped
- The EDIT tab is shown

3) Create 2 tests with the following flows (Note that there is a test called 'I30075_NoPositiveLinesInReturnTickets')

test 1:

1-In the menu, select "Return this Receipt"
2-Add 1x "Adhesive body warmers"
3-Click the just added product
4-Verify "Return Line" button is hidden
4-Click in the EDIT tab button
5-Verify "Return Line" button is hidden

test 2:

1-Add product
2-Select the line of the product
3-In the menu, select "Return this Receipt"
4-Verify "Return Line" button is hidden
5-Clicking again in product line
6-Verify "Return Line" button is hidden

TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
blocks defect 0032787 closedshivum039 [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown 

-  Notes
(0086987)
hgbot (developer)
2016-06-03 14:02

Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: df01001acab8b2a19358872aa4540b15fb8a93d1
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Jun 03 14:02:11 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/df01001acab8b2a19358872aa4540b15fb8a93d1 [^]

Fixed issue 32886. Logic Has Been Added to Hide the ReturnLine Button When Its Return Receipt or LayAway .

---
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0087069)
hgbot (developer)
2016-06-07 16:50

Repository: retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal
Changeset: a635b375b8befe69e2170c5ee8dbcf537aca3669
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Jun 07 16:49:36 2016 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/a635b375b8befe69e2170c5ee8dbcf537aca3669 [^]

Related to issue 0032886: Return line button is now hidden when a receipt is changed to a return

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---

- Issue History
Date Modified Username Field Change
2016-05-06 10:35 Orekaria Type defect => backport
2016-05-06 10:35 Orekaria Target Version => RR16Q2
2016-06-03 14:02 hgbot Checkin
2016-06-03 14:02 hgbot Note Added: 0086987
2016-06-03 14:02 hgbot Status scheduled => resolved
2016-06-03 14:02 hgbot Resolution open => fixed
2016-06-03 14:02 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79d8beaf34f6db33e23ba5d02336d7797728c6e2 [^] => http://code.openbravo.com/retail/backports/3.0RR16Q2/org.openbravo.retail.posterminal/rev/df01001acab8b2a19358872aa4540b15fb8a93d1 [^]
2016-06-07 16:50 hgbot Checkin
2016-06-07 16:50 hgbot Note Added: 0087069
2016-06-07 17:30 guilleaer Review Assigned To => guilleaer
2016-06-07 17:30 guilleaer Status resolved => closed
2016-06-07 17:30 guilleaer Fixed in Version => RR16Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker