Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032787
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Return Receiptmajoralways2016-04-26 15:482016-06-07 17:32
ReporterlorenzofidalgoView Statuspublic 
Assigned Toshivum039 
PriorityimmediateResolutionfixedFixed in VersionRR16Q3
StatusclosedFix in branchFixed in SCM revision79d8beaf34f6
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionmainSCM revision 
Review Assigned Toguilleaer
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0032787: [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown

DescriptionIn documentation it is written "Since 15Q4 It will NOT be possible to have positive lines in return tickets". In RR16Q2 is still possible to use the "Return Line" button in Return Receipts due to "Return Line" button is not hidden. Only clicking in EDIT tab hides the "Return Line" button.
Using the following "Steps To Reproduce", "Return Line" button does not appear in RR16Q1 or RR15Q4.
Steps To ReproduceA) Can only be reproduced in Q2, not in tip
0-Login POS as vallblanca.
1-In dropdown menu, click "Return this Receipt".
2-Add 1x "Adhesive body warmers".
3-Click the just added product. DEFECT: Check "Return Line" button is still shown. It must not be shown. It is still clickable, so, currently, it is possible to create positive lines in a Return Receipt.

B)
Add product
Select line
Menu > Return this receipt
Verify that the 'Return line' option is shown in the right menu

Note that there is a test called 'I30075_NoPositiveLinesInReturnTickets'
Proposed Solution1) Create a function called 'rearrangeEditButtonBar' (if it does not exists) that decides which buttons should be shown in the buttons' bar and paints them

2) The 'rearrangeEditButtonBar' should be called when:
- A menu option like "Return this receipt" or "Layaway this receipt" is selected
- A line of the receipt is tapped
- The EDIT tab is shown

3) Create 2 tests with the following flows (Note that there is a test called 'I30075_NoPositiveLinesInReturnTickets')

test 1:

1-In the menu, select "Return this Receipt"
2-Add 1x "Adhesive body warmers"
3-Click the just added product
4-Verify "Return Line" button is hidden
4-Click in the EDIT tab button
5-Verify "Return Line" button is hidden

test 2:

1-Add product
2-Select the line of the product
3-In the menu, select "Return this Receipt"
4-Verify "Return Line" button is hidden
5-Clicking again in product line
6-Verify "Return Line" button is hidden

TagsNo tags attached.
Attached Filespng file icon ReturnLineIsShownInReturnTickets.png [^] (293,263 bytes) 2016-04-26 15:48
png file icon PositiveLineInReturnReceipt.png [^] (158,120 bytes) 2016-04-26 15:48

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0032557 closedmario_castello Return Line button is displayed even "Switch from positive to return line" preference is set to "N" 
depends on backport 0032886RR16Q2 closedshivum039 [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown 
related to defect 0032789 closedRetail It is still shown (and clickable) "Return Line" button in certain flow when the receipt is marked as "To be Returned" 

-  Notes
(0086003)
Orekaria (administrator)
2016-04-26 17:57

 The issue as reported in A) cannot be reproduced
(0086008)
lorenzofidalgo (developer)
2016-04-27 08:59

 I have just reproduced again this issue in RR16Q2
(0086097)
shivum039 (developer)
2016-04-30 13:02
edited on: 2016-04-30 13:03

 General Observation After Code Analysis .

1)Yes, There is a defect ,But it Only when you click on " return this receipt",
Option from menu When After You Add a product and Edit Tool Bar Still Being Shown.

2) The Reason For the Above defect is ,Code which does the Arrangement Of action Buttons of Edit Mode (Edit Bar) is Not Reachable when you Choose it From Menu Option . But its Reachable When You tap on Added product and Click on Edit Bar ,Hence All Buttons are in the Arranged properly .

3)To Resolve the Defect : Facing Only Problem With Return Line So ,To Resolve the Problem we need to Implement the All Logic in a Single Function and Make that in Such a way that It Should get Call When You Click Return Receipt Option From Menu Also.
(0086193)
hgbot (developer)
2016-05-05 06:37

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 79d8beaf34f6db33e23ba5d02336d7797728c6e2
Author: Shivanand Madiwalar <shivanand.madiwalar <at> promantia.com>
Date: Thu May 05 10:05:01 2016 +0530
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79d8beaf34f6db33e23ba5d02336d7797728c6e2 [^]

Fixes Issue 32787 : Logic Has Been Added to Hide the ReturnLine Button When Its Return Receipt or LayAway .

---
M web/org.openbravo.retail.posterminal/js/components/menu.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
M web/org.openbravo.retail.posterminal/js/pointofsale/view/pointofsale.js
---
(0086194)
hgbot (developer)
2016-05-05 06:37

 Repository: tools/automation/pi-mobile
Changeset: 8371eeea084450da61ddc5c2c584627e1d12e329
Author: Shivanand Madiwalar <shivanand.madiwalar <at> promantia.com>
Date: Thu May 05 10:05:57 2016 +0530
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/8371eeea084450da61ddc5c2c584627e1d12e329 [^]

Verifies Issue 32787 : Automated Test Has Been Created which will hide the ReturnLine Button When Its Return Receipt or LayAway .

---
A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/receipts/I32787_HideReturnLine_Button.java
---
(0086876)
dmitry_mezentsev (developer)
2016-06-01 10:28

 Not closed for 26 days!!!
Please react ASAP.
(0086980)
jorge-garcia (reporter)
2016-06-03 11:43

 It's necessary to beautify this code[1] to have a clean code. Use JsBeautifier plugin of Eclipse.

[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79d8beaf34f6db33e23ba5d02336d7797728c6e2 [^]
(0087072)
guilleaer (manager)
2016-06-07 17:32

 closed. It is true that jsbeauty was needed, but a commit done after that one has fixed this format problem.
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/f3cdfee595c1 [^]

- Issue History
Date Modified Username Field Change
2016-04-26 15:48 lorenzofidalgo New Issue
2016-04-26 15:48 lorenzofidalgo Assigned To => Retail
2016-04-26 15:48 lorenzofidalgo File Added: ReturnLineIsShownInReturnTickets.png
2016-04-26 15:48 lorenzofidalgo Regression level => Packaging and release
2016-04-26 15:48 lorenzofidalgo Regression introduced in release => main
2016-04-26 15:48 lorenzofidalgo Triggers an Emergency Pack => No
2016-04-26 15:48 lorenzofidalgo File Added: PositiveLineInReturnReceipt.png
2016-04-26 15:49 lorenzofidalgo Description Updated View Revisions
2016-04-26 16:04 lorenzofidalgo Relationship added related to 0032789
2016-04-26 16:14 lorenzofidalgo Summary [RR16Q2] "Return Line" button should be disabled when receipt is marked as "To be Returned", but that button is shown => [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown
2016-04-26 17:48 Orekaria Steps to Reproduce Updated View Revisions
2016-04-26 17:48 Orekaria Proposed Solution updated
2016-04-26 17:56 Orekaria Steps to Reproduce Updated View Revisions
2016-04-26 17:57 Orekaria Note Added: 0086003
2016-04-26 17:57 Orekaria Status new => feedback
2016-04-27 08:59 lorenzofidalgo Note Added: 0086008
2016-04-27 09:13 lorenzofidalgo Status feedback => new
2016-04-27 10:17 Orekaria Status new => acknowledged
2016-04-27 10:17 Orekaria Steps to Reproduce Updated View Revisions
2016-04-27 10:54 Orekaria Relationship added related to 0032557
2016-04-27 11:44 Orekaria Proposed Solution updated
2016-04-27 12:02 Orekaria Proposed Solution updated
2016-04-27 17:18 Orekaria Status acknowledged => scheduled
2016-04-27 17:18 Orekaria Assigned To Retail => shivum039
2016-04-30 13:02 shivum039 Note Added: 0086097
2016-04-30 13:03 shivum039 Note Edited: 0086097 View Revisions
2016-05-05 06:37 hgbot Checkin
2016-05-05 06:37 hgbot Note Added: 0086193
2016-05-05 06:37 hgbot Status scheduled => resolved
2016-05-05 06:37 hgbot Resolution open => fixed
2016-05-05 06:37 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/79d8beaf34f6db33e23ba5d02336d7797728c6e2 [^]
2016-05-05 06:37 hgbot Checkin
2016-05-05 06:37 hgbot Note Added: 0086194
2016-05-06 10:34 Orekaria Status resolved => new
2016-05-06 10:34 Orekaria Resolution fixed => open
2016-05-06 10:35 Orekaria Status new => scheduled
2016-05-06 10:35 Orekaria Status scheduled => resolved
2016-05-06 10:35 Orekaria Resolution open => fixed
2016-06-01 10:28 dmitry_mezentsev Note Added: 0086876
2016-06-03 10:35 guilleaer Review Assigned To => guilleaer
2016-06-03 10:35 guilleaer Status resolved => closed
2016-06-03 10:35 guilleaer Fixed in Version => RR16Q3
2016-06-03 11:12 guilleaer Regression level Packaging and release =>
2016-06-03 11:12 guilleaer Regression introduced in release main =>
2016-06-03 11:43 jorge-garcia Note Added: 0086980
2016-06-03 11:43 jorge-garcia Status closed => new
2016-06-03 11:43 jorge-garcia Resolution fixed => open
2016-06-03 11:43 jorge-garcia Fixed in Version RR16Q3 =>
2016-06-07 17:30 guilleaer Status new => scheduled
2016-06-07 17:31 guilleaer Status scheduled => resolved
2016-06-07 17:31 guilleaer Fixed in Version => RR16Q3
2016-06-07 17:31 guilleaer Resolution open => fixed
2016-06-07 17:32 guilleaer Note Added: 0087072
2016-06-07 17:32 guilleaer Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker