Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0032557 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Gift cards and gift vouchers | major | always | 2016-03-30 12:46 | 2016-04-20 17:38 | |||
| Reporter | umartirena | View Status | public | |||||
| Assigned To | mario_castello | |||||||
| Priority | urgent | Resolution | fixed | Fixed in Version | ||||
| Status | closed | Fix in branch | Fixed in SCM revision | 4bec6e2763ea | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Review Assigned To | migueldejuana | |||||||
| Regression level | Production - QA Approved | |||||||
| Regression date | 2015-10-09 | |||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^] | |||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0032557: Return Line button is displayed even "Switch from positive to return line" preference is set to "N" | |||||||
| Description | Return Line button is displayed even "Switch from positive to return line" preference is set to "N". This issue happens only when gift cards and vouchers module is installed. | |||||||
| Steps To Reproduce | Having gift cards and vouchers module installed. In ERP Backend: - Preference: Enable switch from positive line to return line - value N In Webpos: - Create a receipt - Select the line of the product - Expected result: The button Return line should be hidden using the preference Enable switch from positive line to return line, but it is not hided. | |||||||
| Proposed Solution | Find proposed solution attached. | |||||||
| Tags | No tags attached. | |||||||
| Attached Files |  hideReturnLine.diff [^] (670 bytes) 2016-03-30 12:46 [Show Content]
| |||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||
|
||||||||
 Relationships |
|
Notes |
|
|
(0085451) hgbot (developer) 2016-04-05 17:28 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 1db053b68f1c288b757f7d33ad06fa5b333fbacd Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Mon Apr 04 08:48:04 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1db053b68f1c288b757f7d33ad06fa5b333fbacd [^] Fixed issue 32557: Added validation to show return line button --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js --- |
|
(0085490) hgbot (developer) 2016-04-07 15:35 |
Repository: erp/pmods/org.openbravo.retail.sampledata Changeset: 88426d3b9334227bd2f0b8a7ffa4544951492432 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Apr 05 10:31:53 2016 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/88426d3b9334227bd2f0b8a7ffa4544951492432 [^] Related to issue 32557: Added new preference --- M referencedata/sampledata/The_White_Valley_Group/AD_PREFERENCE.xml --- |
|
(0085491) hgbot (developer) 2016-04-07 15:41 |
Repository: tools/automation/pi-mobile Changeset: b590a15eede2fa98b6786f196438d8cbbd0a6b64 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Thu Apr 07 07:40:41 2016 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b590a15eede2fa98b6786f196438d8cbbd0a6b64 [^] Related to issue 32557: Added new automated test --- A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32557_SwitchPositiveReturnlinePermission.java --- |
|
(0085750) migueldejuana (developer) 2016-04-19 16:53 |
We shouldn't add a preference to the sampledata just to use it in a test. Instead of adding a preference to sampledata and update the value in the test, create and remove the needed preference in the test. When pushing the commit, please, add a message explaining the change. Why it only happens with giftcards module installed? |
|
(0085755) mario_castello (developer) 2016-04-19 17:53 edited on: 2016-04-19 18:54 |
The gift card module implements the hook OBPOS_LineSelected to validate whether the product is a gift card or not. Then throws the onHideReturnLineButton event to hide or show the button to return lines. Although the preference "Enable switch from positive line to return line" is set to N if it is a normal product the return line button remains visible because when the gift card module executes the validation sends this button to show. |
|
(0085782) hgbot (developer) 2016-04-20 15:57 |
Repository: tools/automation/pi-mobile Changeset: a20effdaa03197acf56a8b70ac23ff8ac5b84642 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Apr 19 13:12:20 2016 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a20effdaa03197acf56a8b70ac23ff8ac5b84642 [^] Related to issue 32557: Added somes changes to automated test --- M src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32557_SwitchPositiveReturnlinePermission.java --- |
|
(0085783) hgbot (developer) 2016-04-20 16:02 |
Repository: erp/pmods/org.openbravo.retail.sampledata Changeset: 4bec6e2763eafe1ad69a77b3df608879859184cd Author: Rafa Alonso <ral <at> openbravo.com> Date: Tue Apr 19 17:55:27 2016 +0200 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/4bec6e2763eafe1ad69a77b3df608879859184cd [^] Fixed issue 32557: Removed new preference --- M referencedata/sampledata/The_White_Valley_Group/AD_PREFERENCE.xml --- |
|
(0085785) migueldejuana (developer) 2016-04-20 17:38 |
Tested and reviewed |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2016-03-30 12:46 | umartirena | New Issue | |
| 2016-03-30 12:46 | umartirena | Assigned To | => Retail |
| 2016-03-30 12:46 | umartirena | File Added: hideReturnLine.diff | |
| 2016-03-30 12:46 | umartirena | Regression level | => Production - QA Approved |
| 2016-03-30 12:46 | umartirena | Regression date | => 2015-10-09 |
| 2016-03-30 12:46 | umartirena | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^] |
| 2016-03-30 12:46 | umartirena | Triggers an Emergency Pack | => No |
| 2016-03-30 13:07 | Orekaria | Status | new => acknowledged |
| 2016-03-31 16:15 | mario_castello | Assigned To | Retail => mario_castello |
| 2016-04-04 12:50 | umartirena | Resolution time | => 1460498400 |
| 2016-04-04 16:47 | mario_castello | Status | acknowledged => scheduled |
| 2016-04-05 17:28 | hgbot | Checkin | |
| 2016-04-05 17:28 | hgbot | Note Added: 0085451 | |
| 2016-04-05 17:28 | hgbot | Status | scheduled => resolved |
| 2016-04-05 17:28 | hgbot | Resolution | open => fixed |
| 2016-04-05 17:28 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1db053b68f1c288b757f7d33ad06fa5b333fbacd [^] |
| 2016-04-07 15:35 | hgbot | Checkin | |
| 2016-04-07 15:35 | hgbot | Note Added: 0085490 | |
| 2016-04-07 15:41 | hgbot | Checkin | |
| 2016-04-07 15:41 | hgbot | Note Added: 0085491 | |
| 2016-04-19 16:53 | migueldejuana | Note Added: 0085750 | |
| 2016-04-19 16:53 | migueldejuana | Status | resolved => new |
| 2016-04-19 16:53 | migueldejuana | Resolution | fixed => open |
| 2016-04-19 17:16 | mario_castello | Status | new => acknowledged |
| 2016-04-19 17:16 | mario_castello | Status | acknowledged => scheduled |
| 2016-04-19 17:53 | mario_castello | Note Added: 0085755 | |
| 2016-04-19 17:54 | mario_castello | Note Edited: 0085755 | View Revisions |
| 2016-04-19 18:54 | mario_castello | Note Edited: 0085755 | View Revisions |
| 2016-04-19 18:54 | mario_castello | Note Edited: 0085755 | View Revisions |
| 2016-04-20 15:57 | hgbot | Checkin | |
| 2016-04-20 15:57 | hgbot | Note Added: 0085782 | |
| 2016-04-20 16:02 | hgbot | Checkin | |
| 2016-04-20 16:02 | hgbot | Note Added: 0085783 | |
| 2016-04-20 16:02 | hgbot | Status | scheduled => resolved |
| 2016-04-20 16:02 | hgbot | Resolution | open => fixed |
| 2016-04-20 16:02 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1db053b68f1c288b757f7d33ad06fa5b333fbacd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/4bec6e2763eafe1ad69a77b3df608879859184cd [^] |
| 2016-04-20 17:38 | migueldejuana | Review Assigned To | => migueldejuana |
| 2016-04-20 17:38 | migueldejuana | Note Added: 0085785 | |
| 2016-04-20 17:38 | migueldejuana | Status | resolved => closed |
| 2016-04-27 10:54 | Orekaria | Relationship added | related to 0032787 |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |