Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0032557Retail ModulesGift cards and gift voucherspublic2016-03-30 12:462016-04-20 17:38
Reporterumartirena 
Assigned Tomario_castello 
PriorityurgentSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Tomigueldejuana
OBNetwork customerOBPS
Support ticket
Regression levelProduction - QA Approved
Regression date2015-10-09
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^]
Triggers an Emergency PackNo
Summary0032557: Return Line button is displayed even "Switch from positive to return line" preference is set to "N"
DescriptionReturn Line button is displayed even "Switch from positive to return line" preference is set to "N".

This issue happens only when gift cards and vouchers module is installed.
Steps To ReproduceHaving gift cards and vouchers module installed.

In ERP Backend:
- Preference: Enable switch from positive line to return line - value N

In Webpos:
- Create a receipt
- Select the line of the product
- Expected result: The button Return line should be hidden using the preference Enable switch from positive line to return line, but it is not hided.

Proposed SolutionFind proposed solution attached.
Additional Information
TagsNo tags attached.
Relationships
related to defect 0032787 closed shivum039 [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown 
Attached Filesdiff hideReturnLine.diff (670) 2016-03-30 12:46
https://issues.openbravo.com/file_download.php?file_id=9217&type=bug
Issue History
Date ModifiedUsernameFieldChange
2016-03-30 12:46umartirenaNew Issue
2016-03-30 12:46umartirenaAssigned To => Retail
2016-03-30 12:46umartirenaFile Added: hideReturnLine.diff
2016-03-30 12:46umartirenaOBNetwork customer => Yes
2016-03-30 12:46umartirenaRegression level => Production - QA Approved
2016-03-30 12:46umartirenaRegression date => 2015-10-09
2016-03-30 12:46umartirenaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/067080dd7985832d8b1ef85cf2a16b79d894dec0 [^]
2016-03-30 12:46umartirenaTriggers an Emergency Pack => No
2016-03-30 13:07OrekariaStatusnew => acknowledged
2016-03-31 16:15mario_castelloAssigned ToRetail => mario_castello
2016-04-04 12:50umartirenaResolution time => 1460498400
2016-04-04 16:47mario_castelloStatusacknowledged => scheduled
2016-04-05 17:28hgbotCheckin
2016-04-05 17:28hgbotNote Added: 0085451
2016-04-05 17:28hgbotStatusscheduled => resolved
2016-04-05 17:28hgbotResolutionopen => fixed
2016-04-05 17:28hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1db053b68f1c288b757f7d33ad06fa5b333fbacd [^]
2016-04-07 15:35hgbotCheckin
2016-04-07 15:35hgbotNote Added: 0085490
2016-04-07 15:41hgbotCheckin
2016-04-07 15:41hgbotNote Added: 0085491
2016-04-19 16:53migueldejuanaNote Added: 0085750
2016-04-19 16:53migueldejuanaStatusresolved => new
2016-04-19 16:53migueldejuanaResolutionfixed => open
2016-04-19 17:16mario_castelloStatusnew => acknowledged
2016-04-19 17:16mario_castelloStatusacknowledged => scheduled
2016-04-19 17:53mario_castelloNote Added: 0085755
2016-04-19 17:54mario_castelloNote Edited: 0085755bug_revision_view_page.php?bugnote_id=0085755#r11800
2016-04-19 18:54mario_castelloNote Edited: 0085755bug_revision_view_page.php?bugnote_id=0085755#r11801
2016-04-19 18:54mario_castelloNote Edited: 0085755bug_revision_view_page.php?bugnote_id=0085755#r11802
2016-04-20 15:57hgbotCheckin
2016-04-20 15:57hgbotNote Added: 0085782
2016-04-20 16:02hgbotCheckin
2016-04-20 16:02hgbotNote Added: 0085783
2016-04-20 16:02hgbotStatusscheduled => resolved
2016-04-20 16:02hgbotResolutionopen => fixed
2016-04-20 16:02hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1db053b68f1c288b757f7d33ad06fa5b333fbacd [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/4bec6e2763eafe1ad69a77b3df608879859184cd [^]
2016-04-20 17:38migueldejuanaReview Assigned To => migueldejuana
2016-04-20 17:38migueldejuanaNote Added: 0085785
2016-04-20 17:38migueldejuanaStatusresolved => closed
2016-04-27 10:54OrekariaRelationship addedrelated to 0032787

Notes
(0085451)
hgbot   
2016-04-05 17:28   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 1db053b68f1c288b757f7d33ad06fa5b333fbacd
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Mon Apr 04 08:48:04 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/1db053b68f1c288b757f7d33ad06fa5b333fbacd [^]

Fixed issue 32557: Added validation to show return line button

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---
(0085490)
hgbot   
2016-04-07 15:35   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 88426d3b9334227bd2f0b8a7ffa4544951492432
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Apr 05 10:31:53 2016 -0600
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/88426d3b9334227bd2f0b8a7ffa4544951492432 [^]

Related to issue 32557: Added new preference

---
M referencedata/sampledata/The_White_Valley_Group/AD_PREFERENCE.xml
---
(0085491)
hgbot   
2016-04-07 15:41   
Repository: tools/automation/pi-mobile
Changeset: b590a15eede2fa98b6786f196438d8cbbd0a6b64
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Thu Apr 07 07:40:41 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/b590a15eede2fa98b6786f196438d8cbbd0a6b64 [^]

Related to issue 32557: Added new automated test

---
A src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32557_SwitchPositiveReturnlinePermission.java
---
(0085750)
migueldejuana   
2016-04-19 16:53   
We shouldn't add a preference to the sampledata just to use it in a test.

Instead of adding a preference to sampledata and update the value in the test, create and remove the needed preference in the test.

When pushing the commit, please, add a message explaining the change. Why it only happens with giftcards module installed?
(0085755)
mario_castello   
2016-04-19 17:53   
(edited on: 2016-04-19 18:54)
The gift card module implements the hook OBPOS_LineSelected to validate whether the product is a gift card or not.

Then throws the onHideReturnLineButton event to hide or show the button to return lines.

Although the preference "Enable switch from positive line to return line" is set to N if it is a normal product the return line button remains visible
because when the gift card module executes the validation sends this button to show.
(0085782)
hgbot   
2016-04-20 15:57   
Repository: tools/automation/pi-mobile
Changeset: a20effdaa03197acf56a8b70ac23ff8ac5b84642
Author: Mario Castello <mario.castello <at> peoplewalking.com>
Date: Tue Apr 19 13:12:20 2016 -0600
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/a20effdaa03197acf56a8b70ac23ff8ac5b84642 [^]

Related to issue 32557: Added somes changes to automated test

---
M src-test/org/openbravo/test/mobile/quarantine/pack/MCA/returns/I32557_SwitchPositiveReturnlinePermission.java
---
(0085783)
hgbot   
2016-04-20 16:02   
Repository: erp/pmods/org.openbravo.retail.sampledata
Changeset: 4bec6e2763eafe1ad69a77b3df608879859184cd
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Tue Apr 19 17:55:27 2016 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.sampledata/rev/4bec6e2763eafe1ad69a77b3df608879859184cd [^]

Fixed issue 32557: Removed new preference

---
M referencedata/sampledata/The_White_Valley_Group/AD_PREFERENCE.xml
---
(0085785)
migueldejuana   
2016-04-20 17:38   
Tested and reviewed