0032886: [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0032886

Retail Modules

Return Receipt

public

2016-04-26 15:48

2016-06-07 17:30

Reporter

lorenzofidalgo

Assigned To

shivum039

Priority

immediate

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

main

Target Version

RR16Q2

Fixed in Version

RR16Q2

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Packaging and release

Regression date

Regression introduced in release

main

Regression introduced by commit

Triggers an Emergency Pack

Summary

0032886: [RR16Q2] "Return Line" button should be hidden when receipt is marked as "To be Returned", but that button is shown

Description

In documentation it is written "Since 15Q4 It will NOT be possible to have positive lines in return tickets". In RR16Q2 is still possible to use the "Return Line" button in Return Receipts due to "Return Line" button is not hidden. Only clicking in EDIT tab hides the "Return Line" button.
Using the following "Steps To Reproduce", "Return Line" button does not appear in RR16Q1 or RR15Q4.

Steps To Reproduce

A) Can only be reproduced in Q2, not in tip
0-Login POS as vallblanca.
1-In dropdown menu, click "Return this Receipt".
2-Add 1x "Adhesive body warmers".
3-Click the just added product. DEFECT: Check "Return Line" button is still shown. It must not be shown. It is still clickable, so, currently, it is possible to create positive lines in a Return Receipt.

B)
Add product
Select line
Menu > Return this receipt
Verify that the 'Return line' option is shown in the right menu

Note that there is a test called 'I30075_NoPositiveLinesInReturnTickets'

Proposed Solution

1) Create a function called 'rearrangeEditButtonBar' (if it does not exists) that decides which buttons should be shown in the buttons' bar and paints them

2) The 'rearrangeEditButtonBar' should be called when:
- A menu option like "Return this receipt" or "Layaway this receipt" is selected
- A line of the receipt is tapped
- The EDIT tab is shown

3) Create 2 tests with the following flows (Note that there is a test called 'I30075_NoPositiveLinesInReturnTickets')

test 1:

1-In the menu, select "Return this Receipt"
2-Add 1x "Adhesive body warmers"
3-Click the just added product
4-Verify "Return Line" button is hidden
4-Click in the EDIT tab button
5-Verify "Return Line" button is hidden

test 2:

1-Add product
2-Select the line of the product
3-In the menu, select "Return this Receipt"
4-Verify "Return Line" button is hidden
5-Clicking again in product line
6-Verify "Return Line" button is hidden

Additional Information