0032278: When a discretionary discount is removed, the total amount of the ticket is not computed

Description

When a discretionary discount is added to a line, the total amount of the ticket is correctly calculated. However, when this discount is removed, the total doesn't change, and this is wrong.

Steps To Reproduce

- Add a line to a ticket
- Add a discretionary discount (using Receipt discounts)
- Select the line, and in the Edit panel, click on "Remove discount" button
- Verify that the discount is correctly removed from the line, but the total amount of the ticket hasn't changed.

Proposed Solution

This problem comes from the removal of these two lines in editline.js:

+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js Tue Dec 15 13:23:54 2015 +0100
@@ -263,8 +263,6 @@
     tap: function () {
       if (this.owner.owner && this.owner.owner.line && this.owner.owner.line.get('promotions')) {
         this.owner.owner.line.unset('promotions');
- OB.Model.Discounts.applyPromotions(this.model.get('order'));
- this.model.get('order').calculateGross();
         this.hide();
       }
     },

The solution is to replace them by a call to the new calculateReceipt() function.

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

defect

0032277

closed

jorge-garcia

When a discretionary discount is removed, the total amount of the ticket is not computed

Notes
(0084501) hgbot (developer) 2016-02-25 13:55	Repository: retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal Changeset: c54d56ef22fc24cc7bbf4730c16bc38eb13913cf Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com> Date: Thu Feb 25 13:54:21 2016 +0100 URL: http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/c54d56ef22fc24cc7bbf4730c16bc38eb13913cf [^] Fixed issue 32278, Backport of 32277: Receipr is recalculated when a discount is removed from an specific line --- M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js ---

Issue History
Date Modified	Username	Field	Change
2016-02-18 16:37	marvintm	Type	defect => backport
2016-02-18 16:37	marvintm	Target Version	pi => RR16Q1
2016-02-25 13:55	hgbot	Checkin
2016-02-25 13:55	hgbot	Note Added: 0084501
2016-02-25 13:55	hgbot	Status	scheduled => resolved
2016-02-25 13:55	hgbot	Resolution	open => fixed
2016-02-25 13:55	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR16Q1/org.openbravo.retail.posterminal/rev/c54d56ef22fc24cc7bbf4730c16bc38eb13913cf [^]
2016-02-25 13:56	guilleaer	Assigned To	jorge-garcia => guilleaer
2016-03-03 16:10	marvintm	Review Assigned To	=> marvintm
2016-03-03 16:10	marvintm	Status	resolved => closed
2016-03-03 16:10	marvintm	Fixed in Version	=> RR16Q1