Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0032277
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2016-02-18 16:352016-02-25 13:53
ReportermarvintmView Statuspublic 
Assigned Tojorge-garcia 
PrioritynormalResolutionfixedFixed in VersionRR16Q2
StatusclosedFix in branchFixed in SCM revision4f3983e69d7f
ProjectionnoneETAnoneTarget Versionpi
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toguilleaer
Regression levelPackaging and release
Regression date2015-12-15
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5521 [^]
Triggers an Emergency PackNo
Summary

0032277: When a discretionary discount is removed, the total amount of the ticket is not computed

DescriptionWhen a discretionary discount is added to a line, the total amount of the ticket is correctly calculated. However, when this discount is removed, the total doesn't change, and this is wrong.
Steps To Reproduce- Add a line to a ticket
- Add a discretionary discount (using Receipt discounts)
- Select the line, and in the Edit panel, click on "Remove discount" button
- Verify that the discount is correctly removed from the line, but the total amount of the ticket hasn't changed.
Proposed SolutionThis problem comes from the removal of these two lines in editline.js:

+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js Tue Dec 15 13:23:54 2015 +0100
@@ -263,8 +263,6 @@
     tap: function () {
       if (this.owner.owner && this.owner.owner.line && this.owner.owner.line.get('promotions')) {
         this.owner.owner.line.unset('promotions');
- OB.Model.Discounts.applyPromotions(this.model.get('order'));
- this.model.get('order').calculateGross();
         this.hide();
       }
     },


The solution is to replace them by a call to the new calculateReceipt() function.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0032278RR16Q1 closedguilleaer When a discretionary discount is removed, the total amount of the ticket is not computed 
has duplicate defect 0032271 closedranjith_qualiantech_com [SERQA 712] When deleting a % discount already applied in a line the amount is not updated 

-  Notes
(0084436)
hgbot (developer)
2016-02-23 15:38

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 4f3983e69d7f656bd5c8b58e975b999f5d089cd6
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Mon Feb 22 11:33:26 2016 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4f3983e69d7f656bd5c8b58e975b999f5d089cd6 [^]

Fixed issue 32277: When a discretionary discount is removed, the total amount
of the ticket is not computed

The problem was to not recalculate the receipt valueswhen the discount is
removed.

Now the problem is fixed.

---
M web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js
---
(0084437)
hgbot (developer)
2016-02-23 15:38

 Repository: tools/automation/pi-mobile
Changeset: ce29cbf075bd1686a9fece6cacf88e72aba1bb99
Author: Jorge Garcia <jorge.garcia <at> openbravo.com>
Date: Tue Feb 23 15:35:22 2016 +0100
URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/ce29cbf075bd1686a9fece6cacf88e72aba1bb99 [^]

Verifies issue 32277: When a discretionary discount is removed, the total amount
of the ticket is not computed

Added test I32277_DeleteDiscretionaryDiscount.

---
A src-test/org/openbravo/test/mobile/quarantine/pack/JGA/receipts/I32277_DeleteDiscretionaryDiscount.java
---

- Issue History
Date Modified Username Field Change
2016-02-18 16:35 marvintm New Issue
2016-02-18 16:35 marvintm Assigned To => jorge-garcia
2016-02-18 16:35 marvintm Regression level => Packaging and release
2016-02-18 16:35 marvintm Regression date => 2015-12-15
2016-02-18 16:35 marvintm Regression introduced in release => pi
2016-02-18 16:35 marvintm Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5521 [^]
2016-02-18 16:35 marvintm Triggers an Emergency Pack => No
2016-02-18 16:37 marvintm Status new => scheduled
2016-02-19 10:04 ranjith_qualiantech_com Relationship added has duplicate 0032271
2016-02-23 15:38 hgbot Checkin
2016-02-23 15:38 hgbot Note Added: 0084436
2016-02-23 15:38 hgbot Status scheduled => resolved
2016-02-23 15:38 hgbot Resolution open => fixed
2016-02-23 15:38 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/4f3983e69d7f656bd5c8b58e975b999f5d089cd6 [^]
2016-02-23 15:38 hgbot Checkin
2016-02-23 15:38 hgbot Note Added: 0084437
2016-02-25 13:53 guilleaer Review Assigned To => guilleaer
2016-02-25 13:53 guilleaer Status resolved => closed
2016-02-25 13:53 guilleaer Fixed in Version => RR16Q2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker