0032278: When a discretionary discount is removed, the total amount of the ticket is not computed

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0032278

Retail Modules

Web POS

public

2016-02-18 16:35

2016-03-03 16:10

Reporter

marvintm

Assigned To

guilleaer

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

RR16Q1

Fixed in Version

RR16Q1

Merge Request Status

Review Assigned To

marvintm

OBNetwork customer

Support ticket

Regression level

Packaging and release

Regression date

2015-12-15

Regression introduced in release

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/5521 [^]

Triggers an Emergency Pack

Summary

0032278: When a discretionary discount is removed, the total amount of the ticket is not computed

Description

When a discretionary discount is added to a line, the total amount of the ticket is correctly calculated. However, when this discount is removed, the total doesn't change, and this is wrong.

Steps To Reproduce

- Add a line to a ticket
- Add a discretionary discount (using Receipt discounts)
- Select the line, and in the Edit panel, click on "Remove discount" button
- Verify that the discount is correctly removed from the line, but the total amount of the ticket hasn't changed.

Proposed Solution

This problem comes from the removal of these two lines in editline.js:

+++ b/web/org.openbravo.retail.posterminal/js/pointofsale/view/editline.js Tue Dec 15 13:23:54 2015 +0100
@@ -263,8 +263,6 @@
     tap: function () {
       if (this.owner.owner && this.owner.owner.line && this.owner.owner.line.get('promotions')) {
         this.owner.owner.line.unset('promotions');
- OB.Model.Discounts.applyPromotions(this.model.get('order'));
- this.model.get('order').calculateGross();
         this.hide();
       }
     },

The solution is to replace them by a call to the new calculateReceipt() function.

Additional Information