|View Issue Details|
|Type||Category||Severity||Reproducibility||Date Submitted||Last Update|
|defect||[Openbravo ERP] A. Platform||major||always||2016-02-10 19:20||2016-03-17 10:56|
|Priority||normal||Resolution||fixed||Fixed in Version||3.0PR16Q2|
|Status||closed||Fix in branch||Fixed in SCM revision||7bf022753248|
|OS Version||Database version||Ant version|
|Product Version||SCM revision|
|Review Assigned To||alostale|
|Regression introduced in release|
|Regression introduced by commit|
|Triggers an Emergency Pack||No|
0032193: Selection is not working properly in P&E grids having filter on change option set to N
|Description||Selection is not working properly in P&E grids having filter on change option set to N|
This problem is happening because the onblur event of the filter is firing the filtering without having the selection updated.
|Steps To Reproduce||1. As System Administrator, access Grid Configuration at Window/Tab/Field Level and configure: |
* tab= Order Invoices - Order Invoice P&E
* Filter on change= no
2. Logout and login
3. Access Payment In window
4. Remove all filters. Add a new filter in the Invoice No. field and press enter to show a few records.
5. Select one record.
5. Put the focus in the filter of the Invoice No. again, change the criteria but do not press enter
6. Without pressing any key, try to click one or several records quickly. Notice that after that the following error appears in the log: "Uncaught BigDecimal(): Not a number: n,u,l,l"
|Tags||No tags attached.|
edited on: 2016-02-18 08:53
The problem is caused because the OB.APRM.AddPayment.doSelectionChanged is launching some methods (for example updateInvOrderTotal) to calculate the values of the window.
Having filter on change option set to N, the onblur event can launch a filtering request, if at the same time we select some records when the selectionChange is fired it is possible that the local data of the grid is not ready.
Author: Carlos Aristu <carlos.aristu <at> openbravo.com>
Date: Fri Feb 19 10:44:55 2016 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7bf02275324819d0340fd907ba6795c0143b699c [^]
fixes issue 32193: Fix selection in P&E grids having filter on change disabled
Having filter on change disabled, the filtering is not performed until enter is pressed or the focus is moved out of the text filter. In this second case, there could be problems if the focus is lost when checking a pick and edit grid record: the filtering request is performed and at the same time the actions related to the record selection are fired. This can cause the selection actions not work as expected.
This problem also affects to numeric and date filters, because they always perform the filtering after losing the focus.
To avoid this problem a new mechanism has been included for pick and edit grids, the blur method for the filter elements is overridden to prevent the selection immediately after losing the focus.
|code reviewed + tested|
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.
Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/b22fb0500156 [^]
Maturity status: Test
|2016-02-10 19:20||caristu||New Issue|
|2016-02-10 19:20||caristu||Assigned To||=> platform|
|2016-02-10 19:20||caristu||Modules||=> Core|
|2016-02-10 19:20||caristu||Triggers an Emergency Pack||=> No|
|2016-02-11 09:30||caristu||Severity||minor => major|
|2016-02-11 09:30||caristu||Assigned To||platform => caristu|
|2016-02-11 09:31||caristu||Status||new => scheduled|
|2016-02-11 11:16||caristu||Steps to Reproduce Updated||View Revisions|
|2016-02-11 11:53||caristu||Note Added: 0084099|
|2016-02-11 11:54||caristu||Relationship added||related to 0032091|
|2016-02-11 11:55||caristu||Relationship added||related to 0031989|
|2016-02-18 08:53||caristu||Steps to Reproduce Updated||View Revisions|
|2016-02-18 08:53||caristu||Note Edited: 0084099||View Revisions|
|2016-02-19 10:48||hgbot||Note Added: 0084348|
|2016-02-19 10:48||hgbot||Status||scheduled => resolved|
|2016-02-19 10:48||hgbot||Resolution||open => fixed|
|2016-02-19 10:48||hgbot||Fixed in SCM revision||=> http://code.openbravo.com/erp/devel/pi/rev/7bf02275324819d0340fd907ba6795c0143b699c [^]|
|2016-02-19 11:23||caristu||Relationship added||related to 0032287|
|2016-02-19 11:27||caristu||Review Assigned To||=> alostale|
|2016-02-19 11:27||caristu||Issue Monitored: alostale|
|2016-02-26 09:43||alostale||Note Added: 0084546|
|2016-02-26 09:43||alostale||Status||resolved => closed|
|2016-02-26 09:43||alostale||Fixed in Version||=> 3.0PR16Q2|
|2016-03-17 10:56||hudsonbot||Note Added: 0085151|
|Copyright © 2000 - 2009 MantisBT Group|