Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0031515
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 09. Financial managementmajoralways2015-11-17 13:322015-11-23 21:17
ReporteraferrazView Statuspublic 
Assigned Toaferraz 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revisionaaf78ab227d5
ProjectionnoneETAnoneTarget Version3.0PR16Q1
OSLinux 64 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionProfessional ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Tovmromanos
Web browser
ModulesCore
Regression levelPackaging and release
Regression date2015-11-11
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712b [^]
Triggers an Emergency PackNo
Summary

0031515: Empty matched document when running Match Statement pocess

DescriptionMatched Document keeps empty in Match Statement grid although record is matched.
Steps To ReproduceAs FB Admin:

- Go to Financial Account windonw and select Cuenta de Banco
  Move to Imported Bank Statements tab and create a record.
  Move to Bank Statement Lines tab and create a record with payment in = 10.
  Click on Process button.

- Click on Match Statement button.
  Click Cancel in Confirm popup.
  Select the record shown in the grid and click + button (Add new transaction).
  Select any gl item in Add Transaction popup and click Done.
  Clear filter is necessary to show matched bank statements.
  Realize record appears as matched but Matched Document column is empty.
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 00315163.0PR15Q4 closedaferraz Empty matched document when running Match Statement pocess 
depends on backport 00315173.0PR15Q3.4 closedaferraz Empty matched document when running Match Statement pocess 
caused by defect 00313893.0PR16Q1 closedaferraz Hover over Matched Document does not show document details information as before, in Match Statement pop-up 

-  Notes
(0081931)
aferraz (manager)
2015-11-17 16:40
edited on: 2015-11-17 18:50

Test plan:

As FB Admin:

- Go to Financial Account windonw and select Cuenta de Banco
  Move to Imported Bank Statements tab and create a record.
  Move to Bank Statement Lines tab and create a record with payment in = 10. Fill also reference no, business partner name, business partner, gl item and description fields with any value.
  Click on Process button.

- Click on Match Statement button.
  Click Cancel in Confirm popup.
  Select the record shown in the grid and click + button (Add new transaction).
  Click Done.
  Clear filter is necessary to show matched bank statements.
  Show all the available columns but audit ones in the grid.
  Realize record appears as matched and all fields but affinity and transaction reference no. are filled.
  Realize you can filter and order by any column.

(0081951)
hgbot (developer)
2015-11-18 14:01

Repository: erp/devel/pi
Changeset: aaf78ab227d58ecf4e53622a1ec48b90e99d33e5
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Nov 17 18:03:25 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aaf78ab227d58ecf4e53622a1ec48b90e99d33e5 [^]

Fixes issue 31515: Empty matched document in Match Statement

The problem was that two new columns were added in aprm_matchstatement hql query in the middle of the select clause, while they were added as two new columns at the end of ad_column. As the columns order was not the same between the hql query and the ad_column and some columns did not have an alias in hql query and some others did not have an entity alias in ad_column, some column values were lost.
To fix it, we added an alias to all columns in aprm_matchstatement hql query (matchedDocument had no alias) and an entity alias to all ad_columns in aprm_matchstatement table (Transaction, bslUpdated and matchedDocument columns had no entity alias and Affinity column had a wrong entity alias).
With this, all columns of aprm_matchstatement will be correctly filled with their values in Match Statement grid.
If new columns are added to the hql query, they can go in any order in the select clause and in the ad_column, but they will need to have both an alias in the hql query and an entity alias in the ad_column, following this documentation: http://wiki.openbravo.com/wiki/How_to_create_a_HQL_Based_Table#Column_Definition [^]

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081953)
vmromanos (manager)
2015-11-18 14:03

Code review + testing OK
(0082032)
aferraz (manager)
2015-11-20 15:13

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8627 [^]
(0082254)
hudsonbot (developer)
2015-11-23 21:17

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-11-17 13:32 aferraz New Issue
2015-11-17 13:32 aferraz Assigned To => Triage Finance
2015-11-17 13:32 aferraz Modules => Core
2015-11-17 13:32 aferraz Triggers an Emergency Pack => No
2015-11-17 15:23 aferraz Relationship added caused by 0031389
2015-11-17 15:24 aferraz Assigned To Triage Finance => aferraz
2015-11-17 15:25 aferraz Regression level => Packaging and release
2015-11-17 15:25 aferraz Regression date => 2015-11-11
2015-11-17 15:25 aferraz Regression introduced in release => pi
2015-11-17 15:25 aferraz Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712b [^]
2015-11-17 15:29 aferraz Status new => scheduled
2015-11-17 16:40 aferraz Note Added: 0081931
2015-11-17 18:50 aferraz Note Edited: 0081931 View Revisions
2015-11-18 14:01 hgbot Checkin
2015-11-18 14:01 hgbot Note Added: 0081951
2015-11-18 14:01 hgbot Status scheduled => resolved
2015-11-18 14:01 hgbot Resolution open => fixed
2015-11-18 14:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aaf78ab227d58ecf4e53622a1ec48b90e99d33e5 [^]
2015-11-18 14:03 vmromanos Review Assigned To => vmromanos
2015-11-18 14:03 vmromanos Note Added: 0081953
2015-11-18 14:03 vmromanos Status resolved => closed
2015-11-20 15:13 aferraz Note Added: 0082032
2015-11-23 21:17 hudsonbot Checkin
2015-11-23 21:17 hudsonbot Note Added: 0082254


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker