Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0031515Openbravo ERP09. Financial managementpublic2015-11-17 13:322015-11-23 21:17
Reporteraferraz 
Assigned Toaferraz 
PriorityimmediateSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS30OS VersionProfessional Appliance
Product Version 
Target Version3.0PR16Q1Fixed in Version 
Merge Request Status
Review Assigned Tovmromanos
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelPackaging and release
Regression date2015-11-11
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712b [^]
Triggers an Emergency PackNo
Summary0031515: Empty matched document when running Match Statement pocess
DescriptionMatched Document keeps empty in Match Statement grid although record is matched.
Steps To ReproduceAs FB Admin:

- Go to Financial Account windonw and select Cuenta de Banco
  Move to Imported Bank Statements tab and create a record.
  Move to Bank Statement Lines tab and create a record with payment in = 10.
  Click on Process button.

- Click on Match Statement button.
  Click Cancel in Confirm popup.
  Select the record shown in the grid and click + button (Add new transaction).
  Select any gl item in Add Transaction popup and click Done.
  Clear filter is necessary to show matched bank statements.
  Realize record appears as matched but Matched Document column is empty.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 00315163.0PR15Q4 closed aferraz Empty matched document when running Match Statement pocess 
depends on backport 00315173.0PR15Q3.4 closed aferraz Empty matched document when running Match Statement pocess 
caused by defect 00313893.0PR16Q1 closed aferraz Hover over Matched Document does not show document details information as before, in Match Statement pop-up 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-11-17 13:32aferrazNew Issue
2015-11-17 13:32aferrazAssigned To => Triage Finance
2015-11-17 13:32aferrazModules => Core
2015-11-17 13:32aferrazTriggers an Emergency Pack => No
2015-11-17 15:23aferrazRelationship addedcaused by 0031389
2015-11-17 15:24aferrazAssigned ToTriage Finance => aferraz
2015-11-17 15:25aferrazRegression level => Packaging and release
2015-11-17 15:25aferrazRegression date => 2015-11-11
2015-11-17 15:25aferrazRegression introduced in release => pi
2015-11-17 15:25aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/fe7e7c17712b [^]
2015-11-17 15:29aferrazStatusnew => scheduled
2015-11-17 16:40aferrazNote Added: 0081931
2015-11-17 18:50aferrazNote Edited: 0081931bug_revision_view_page.php?bugnote_id=0081931#r10268
2015-11-18 14:01hgbotCheckin
2015-11-18 14:01hgbotNote Added: 0081951
2015-11-18 14:01hgbotStatusscheduled => resolved
2015-11-18 14:01hgbotResolutionopen => fixed
2015-11-18 14:01hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/aaf78ab227d58ecf4e53622a1ec48b90e99d33e5 [^]
2015-11-18 14:03vmromanosReview Assigned To => vmromanos
2015-11-18 14:03vmromanosNote Added: 0081953
2015-11-18 14:03vmromanosStatusresolved => closed
2015-11-20 15:13aferrazNote Added: 0082032
2015-11-23 21:17hudsonbotCheckin
2015-11-23 21:17hudsonbotNote Added: 0082254

Notes
(0081931)
aferraz   
2015-11-17 16:40   
(edited on: 2015-11-17 18:50)
Test plan:

As FB Admin:

- Go to Financial Account windonw and select Cuenta de Banco
  Move to Imported Bank Statements tab and create a record.
  Move to Bank Statement Lines tab and create a record with payment in = 10. Fill also reference no, business partner name, business partner, gl item and description fields with any value.
  Click on Process button.

- Click on Match Statement button.
  Click Cancel in Confirm popup.
  Select the record shown in the grid and click + button (Add new transaction).
  Click Done.
  Clear filter is necessary to show matched bank statements.
  Show all the available columns but audit ones in the grid.
  Realize record appears as matched and all fields but affinity and transaction reference no. are filled.
  Realize you can filter and order by any column.
(0081951)
hgbot   
2015-11-18 14:01   
Repository: erp/devel/pi
Changeset: aaf78ab227d58ecf4e53622a1ec48b90e99d33e5
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Tue Nov 17 18:03:25 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/aaf78ab227d58ecf4e53622a1ec48b90e99d33e5 [^]

Fixes issue 31515: Empty matched document in Match Statement

The problem was that two new columns were added in aprm_matchstatement hql query in the middle of the select clause, while they were added as two new columns at the end of ad_column. As the columns order was not the same between the hql query and the ad_column and some columns did not have an alias in hql query and some others did not have an entity alias in ad_column, some column values were lost.
To fix it, we added an alias to all columns in aprm_matchstatement hql query (matchedDocument had no alias) and an entity alias to all ad_columns in aprm_matchstatement table (Transaction, bslUpdated and matchedDocument columns had no entity alias and Affinity column had a wrong entity alias).
With this, all columns of aprm_matchstatement will be correctly filled with their values in Match Statement grid.
If new columns are added to the hql query, they can go in any order in the select clause and in the ad_column, but they will need to have both an alias in the hql query and an entity alias in the ad_column, following this documentation: http://wiki.openbravo.com/wiki/How_to_create_a_HQL_Based_Table#Column_Definition [^]

---
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_COLUMN.xml
M modules/org.openbravo.advpaymentmngt/src-db/database/sourcedata/AD_TABLE.xml
---
(0081953)
vmromanos   
2015-11-18 14:03   
Code review + testing OK
(0082032)
aferraz   
2015-11-20 15:13   
https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8627 [^]
(0082254)
hudsonbot   
2015-11-23 21:17   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7b56bebaaa88 [^]
Maturity status: Test