Project:
View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
ID | ||||||||
0031378 | ||||||||
Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
defect | [Retail Modules] Web POS | major | always | 2015-11-05 17:46 | 2015-11-10 16:38 | |||
Reporter | guilleaer | View Status | public | |||||
Assigned To | marvintm | |||||||
Priority | normal | Resolution | fixed | Fixed in Version | RR16Q1 | |||
Status | closed | Fix in branch | Fixed in SCM revision | be5581998427 | ||||
Projection | none | ETA | none | Target Version | ||||
OS | Any | Database | Any | Java version | ||||
OS Version | Database version | Ant version | ||||||
Product Version | SCM revision | |||||||
Merge Request Status | ||||||||
Review Assigned To | guilleaer | |||||||
OBNetwork customer | No | |||||||
Support ticket | ||||||||
Regression level | Production - QA Approved | |||||||
Regression date | 2015-06-25 | |||||||
Regression introduced in release | RR15Q3 | |||||||
Regression introduced by commit | https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fc607f588049 [^] | |||||||
Triggers an Emergency Pack | No | |||||||
Summary | 0031378: Cashup Date is not taken into account. Instead current date is used | |||||||
Description | Cashup date is not taken into account by ProcessCashClose because when the value is readed an exception is raised: String strCashUpDate = (String) jsonCashup.getString("cashUpDate"); cashUpDate = (Date) JsonToDataConverter.convertJsonToPropertyValue(PropertyByType.DATETIME, ((String) strCashUpDate).subSequence(0, ((String) strCashUpDate).lastIndexOf("."))); The value of strCashUpDate is 05-11-2015 but the value that we are trying to parse in the next line of code is expecting a different value. Fortunately this piece of code is located between try/catch and we manage the exception in catch assigning new date to the cashup date. The main issue will be when a cashup get stucked because an error an it is processed later. In this case the cashup date will not be the real date | |||||||
Steps To Reproduce | 1. set the laptop date as 02-nov 2. create an order and make it fail (e.g. remove obposcashupid field from the order) 3. ensure that order is in "errors while importing" 4. do a cashup 5. the cashup will go also to errors while importing. 6. fix laptop date 7. go to error window an fix the order adding de field that we removed 8. process the order 9. process the cashup -> cashup date will be 05-nov(today) instead of 02-nov(date when the cashup was processed | |||||||
Proposed Solution | parse the value received from the client side properly. | |||||||
Tags | No tags attached. | |||||||
Attached Files | ||||||||
![]() |
|||||||||||||||
|
![]() |
|
(0081536) hgbot (developer) 2015-11-05 18:34 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 64c142b106f0317f152bb05055b9c87cbcc012da Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com> Date: Thu Nov 05 18:34:03 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/64c142b106f0317f152bb05055b9c87cbcc012da [^] Fixed issue 31378. Now the date will be set and sent in the correct format. --- M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js --- |
(0081541) hgbot (developer) 2015-11-05 21:58 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: be5581998427406700d93c1c3959e957ce235485 Author: Rafa Alonso <ral <at> openbravo.com> Date: Thu Nov 05 20:40:40 2015 +0100 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/be5581998427406700d93c1c3959e957ce235485 [^] Fixed issue 31378. Now the date will be set and sent in the correct format (II) --- M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js --- |
![]() |
|||
Date Modified | Username | Field | Change |
2015-11-05 17:46 | guilleaer | New Issue | |
2015-11-05 17:46 | guilleaer | Assigned To | => Retail |
2015-11-05 17:46 | guilleaer | OBNetwork customer | => No |
2015-11-05 17:46 | guilleaer | Triggers an Emergency Pack | => No |
2015-11-05 18:26 | marvintm | Regression level | => Production - QA Approved |
2015-11-05 18:26 | marvintm | Regression date | => 2015-06-25 |
2015-11-05 18:26 | marvintm | Regression introduced in release | => RR15Q3 |
2015-11-05 18:26 | marvintm | Regression introduced by commit | => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fc607f588049 [^] |
2015-11-05 18:30 | marvintm | Status | new => scheduled |
2015-11-05 18:34 | hgbot | Checkin | |
2015-11-05 18:34 | hgbot | Note Added: 0081536 | |
2015-11-05 18:34 | hgbot | Status | scheduled => resolved |
2015-11-05 18:34 | hgbot | Resolution | open => fixed |
2015-11-05 18:34 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/64c142b106f0317f152bb05055b9c87cbcc012da [^] |
2015-11-05 20:27 | Orekaria | Assigned To | Retail => marvintm |
2015-11-05 21:58 | hgbot | Checkin | |
2015-11-05 21:58 | hgbot | Note Added: 0081541 | |
2015-11-05 21:58 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/64c142b106f0317f152bb05055b9c87cbcc012da [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/be5581998427406700d93c1c3959e957ce235485 [^] |
2015-11-10 16:38 | guilleaer | Review Assigned To | => guilleaer |
2015-11-10 16:38 | guilleaer | Status | resolved => closed |
2015-11-10 16:38 | guilleaer | Fixed in Version | => RR16Q1 |
Copyright © 2000 - 2009 MantisBT Group |