Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0031380
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Web POSmajoralways2015-11-05 17:462015-11-11 09:58
ReporterguilleaerView Statuspublic 
Assigned ToRetail 
PrioritynormalResolutionfixedFixed in VersionRR15Q4
StatusclosedFix in branchFixed in SCM revision7d9eebff4858
ProjectionnoneETAnoneTarget VersionRR15Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned ToOrekaria
Regression levelProduction - QA Approved
Regression date2015-06-25
Regression introduced in releaseRR15Q3
Regression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fc607f588049 [^]
Triggers an Emergency PackNo
Summary

0031380: Cashup Date is not taken into account. Instead current date is used

DescriptionCashup date is not taken into account by ProcessCashClose because when the value is readed an exception is raised:

        String strCashUpDate = (String) jsonCashup.getString("cashUpDate");
        cashUpDate = (Date) JsonToDataConverter.convertJsonToPropertyValue(PropertyByType.DATETIME,
            ((String) strCashUpDate).subSequence(0, ((String) strCashUpDate).lastIndexOf(".")));

The value of strCashUpDate is 05-11-2015 but the value that we are trying to parse in the next line of code is expecting a different value.

Fortunately this piece of code is located between try/catch and we manage the exception in catch assigning new date to the cashup date.

The main issue will be when a cashup get stucked because an error an it is processed later. In this case the cashup date will not be the real date
Steps To Reproduce1. set the laptop date as 02-nov
2. create an order and make it fail (e.g. remove obposcashupid field from the order)
3. ensure that order is in "errors while importing"
4. do a cashup
5. the cashup will go also to errors while importing.
6. fix laptop date
7. go to error window an fix the order adding de field that we removed
8. process the order
9. process the cashup -> cashup date will be 05-nov(today) instead of 02-nov(date when the cashup was processed
Proposed Solutionparse the value received from the client side properly.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0031378 closedmarvintm Cashup Date is not taken into account. Instead current date is used 

-  Notes
(0081538)
hgbot (developer)
2015-11-05 18:36

 Repository: retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal
Changeset: 3e9c055f9ec7958067c7c088d2ed17cc254f4de7
Author: Antonio Moreno Perez <antonio.moreno <at> openbravo.com>
Date: Thu Nov 05 18:36:09 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/3e9c055f9ec7958067c7c088d2ed17cc254f4de7 [^]

Fixed issue 31380. Now the date will be set and sent in the correct format.

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---
(0081664)
hgbot (developer)
2015-11-10 16:43

 Repository: retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal
Changeset: 7d9eebff4858d2c8e607e9318563a44abc70cda8
Author: Guillermo Alvarez de Eulate <guillermo.alvarez <at> openbravo.com>
Date: Tue Nov 10 16:42:49 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/7d9eebff4858d2c8e607e9318563a44abc70cda8 [^]

Fixed issue 31380. Now the date will be set and sent in the correct format. - 2nd fix

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---

- Issue History
Date Modified Username Field Change
2015-11-05 18:30 marvintm Type defect => backport
2015-11-05 18:30 marvintm Target Version => RR15Q4
2015-11-05 18:36 hgbot Checkin
2015-11-05 18:36 hgbot Note Added: 0081538
2015-11-05 18:36 hgbot Status scheduled => resolved
2015-11-05 18:36 hgbot Resolution open => fixed
2015-11-05 18:36 hgbot Fixed in SCM revision => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/3e9c055f9ec7958067c7c088d2ed17cc254f4de7 [^]
2015-11-10 16:43 hgbot Checkin
2015-11-10 16:43 hgbot Note Added: 0081664
2015-11-10 16:43 hgbot Fixed in SCM revision http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/3e9c055f9ec7958067c7c088d2ed17cc254f4de7 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q4/org.openbravo.retail.posterminal/rev/7d9eebff4858d2c8e607e9318563a44abc70cda8 [^]
2015-11-11 09:58 Orekaria Review Assigned To => Orekaria
2015-11-11 09:58 Orekaria Status resolved => closed
2015-11-11 09:58 Orekaria Fixed in Version => RR15Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker