0031378: Cashup Date is not taken into account. Instead current date is used

Openbravo Issue Tracking System - Retail Modules

View Issue Details

Project

Category

View Status

Date Submitted

Last Update

0031378

Retail Modules

Web POS

public

2015-11-05 17:46

2015-11-10 16:38

Reporter

guilleaer

Assigned To

marvintm

Priority

normal

Severity

major

Reproducibility

always

Status

closed

Resolution

fixed

Platform

OS Version

Product Version

Target Version

Fixed in Version

RR16Q1

Merge Request Status

Review Assigned To

guilleaer

OBNetwork customer

Support ticket

Regression level

Production - QA Approved

Regression date

2015-06-25

Regression introduced in release

RR15Q3

Regression introduced by commit

https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fc607f588049 [^]

Triggers an Emergency Pack

Summary

0031378: Cashup Date is not taken into account. Instead current date is used

Description

Cashup date is not taken into account by ProcessCashClose because when the value is readed an exception is raised:

        String strCashUpDate = (String) jsonCashup.getString("cashUpDate");
        cashUpDate = (Date) JsonToDataConverter.convertJsonToPropertyValue(PropertyByType.DATETIME,
            ((String) strCashUpDate).subSequence(0, ((String) strCashUpDate).lastIndexOf(".")));

The value of strCashUpDate is 05-11-2015 but the value that we are trying to parse in the next line of code is expecting a different value.

Fortunately this piece of code is located between try/catch and we manage the exception in catch assigning new date to the cashup date.

The main issue will be when a cashup get stucked because an error an it is processed later. In this case the cashup date will not be the real date

Steps To Reproduce

1. set the laptop date as 02-nov
2. create an order and make it fail (e.g. remove obposcashupid field from the order)
3. ensure that order is in "errors while importing"
4. do a cashup
5. the cashup will go also to errors while importing.
6. fix laptop date
7. go to error window an fix the order adding de field that we removed
8. process the order
9. process the cashup -> cashup date will be 05-nov(today) instead of 02-nov(date when the cashup was processed

Proposed Solution

parse the value received from the client side properly.

Additional Information

Tags

No tags attached.

Relationships

depends on	backport	0031380	RR15Q4	closed	Retail	Cashup Date is not taken into account. Instead current date is used
depends on	backport	0031381	RR15Q3.2	closed	Retail	Cashup Date is not taken into account. Instead current date is used