Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030981
TypeCategorySeverityReproducibilityDate SubmittedLast Update
backport[Retail Modules] Layaway ordermajoralways2015-09-02 13:502015-11-02 10:22
ReportermalsasuaView Statuspublic 
Assigned Tomario_castello 
PriorityhighResolutionfixedFixed in VersionRR15Q3.2
StatusclosedFix in branchFixed in SCM revision5ee19c0ae683
ProjectionnoneETAnoneTarget VersionRR15Q3.2
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionRR15Q3SCM revision 
Merge Request Status
Review Assigned Toguilleaer
OBNetwork customerOBPS
Support ticket38051
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030981: when layaway is paid, the shipment can be created wrongly

Descriptionwhen a layaway is paid, the shipments lines can be created with incorrect quantities.
Steps To Reproduceno steps to reproduce, but checking the code:

. in this line[1], the order lines in var "lineReferences" are loaded sorted by the function getOrderLineList()
[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l235 [^]

. in this line[2], the order lines in var orderLines are loaded from the Json
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l899 [^]

and the JSON is retrieved from POS, and in POS the lines are loaded with this SQL (without order by):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/PaidReceipts.java#l91 [^]


To create the shipment lines, the qty is retrieved from var lineReferences:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l903 [^]

and the rest of info of line is retrieved from var
orderlines.getJSONObject(i):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l1028 [^]

And the elements can be ordered distinct in the two arrays


Module script should be done
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
blocks defect 0030741 closedmario_castello when layaway is paid, the shipment can be created wrongly 

-  Notes
(0081405)
hgbot (developer)
2015-10-30 13:08

 Repository: retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal
Changeset: 5ee19c0ae683cf96d6c63b71484b4c19b6c711f3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Oct 30 13:05:33 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal/rev/5ee19c0ae683cf96d6c63b71484b4c19b6c711f3 [^]

Fixed issue 30981. Create lineReferences list based on json lines

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---

- Issue History
Date Modified Username Field Change
2015-09-30 09:28 marvintm Type defect => backport
2015-09-30 09:28 marvintm Target Version => RR15Q3.2
2015-10-30 13:08 hgbot Checkin
2015-10-30 13:08 hgbot Note Added: 0081405
2015-10-30 13:08 hgbot Status scheduled => resolved
2015-10-30 13:08 hgbot Resolution open => fixed
2015-10-30 13:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eee715f8f9d4f46fbe864fa75b47d172bd50b882 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal/rev/5ee19c0ae683cf96d6c63b71484b4c19b6c711f3 [^]
2015-11-02 10:22 guilleaer Status resolved => closed
2015-11-02 10:22 guilleaer Fixed in Version => RR15Q3.2

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker