Openbravo Issue Tracking System - Retail Modules
View Issue Details
0030981Retail ModulesLayaway orderpublic2015-09-02 13:502015-11-02 10:22
malsasua 
mario_castello 
highmajoralways
closedfixed 
20Community Appliance
RR15Q3 
RR15Q3.2RR15Q3.2 
guilleaer
No
0030981: when layaway is paid, the shipment can be created wrongly
when a layaway is paid, the shipments lines can be created with incorrect quantities.
no steps to reproduce, but checking the code:

. in this line[1], the order lines in var "lineReferences" are loaded sorted by the function getOrderLineList()
[1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l235 [^]

. in this line[2], the order lines in var orderLines are loaded from the Json
[2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l899 [^]

and the JSON is retrieved from POS, and in POS the lines are loaded with this SQL (without order by):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/PaidReceipts.java#l91 [^]


To create the shipment lines, the qty is retrieved from var lineReferences:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l903 [^]

and the rest of info of line is retrieved from var
orderlines.getJSONObject(i):
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l1028 [^]

And the elements can be ordered distinct in the two arrays


Module script should be done
No tags attached.
blocks defect 0030741 closed mario_castello when layaway is paid, the shipment can be created wrongly 
Issue History
2015-09-30 09:28marvintmTypedefect => backport
2015-09-30 09:28marvintmTarget Version => RR15Q3.2
2015-10-30 13:08hgbotCheckin
2015-10-30 13:08hgbotNote Added: 0081405
2015-10-30 13:08hgbotStatusscheduled => resolved
2015-10-30 13:08hgbotResolutionopen => fixed
2015-10-30 13:08hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eee715f8f9d4f46fbe864fa75b47d172bd50b882 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal/rev/5ee19c0ae683cf96d6c63b71484b4c19b6c711f3 [^]
2015-11-02 10:22guilleaerStatusresolved => closed
2015-11-02 10:22guilleaerFixed in Version => RR15Q3.2

Notes
(0081405)
hgbot   
2015-10-30 13:08   
Repository: retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal
Changeset: 5ee19c0ae683cf96d6c63b71484b4c19b6c711f3
Author: Antonio Moreno <antonio.moreno <at> openbravo.com>
Date: Fri Oct 30 13:05:33 2015 +0100
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3.2/org.openbravo.retail.posterminal/rev/5ee19c0ae683cf96d6c63b71484b4c19b6c711f3 [^]

Fixed issue 30981. Create lineReferences list based on json lines

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
---