Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0030741 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Retail Modules] Layaway order | major | always | 2015-09-02 13:50 | 2015-10-20 10:10 | |||
| Reporter | malsasua | View Status | public | |||||
| Assigned To | mario_castello | |||||||
| Priority | high | Resolution | fixed | Fixed in Version | RR15Q4 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | eee715f8f9d4 | ||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Linux 32 bit | Database | PostgreSQL | Java version | 1.6.0_18 | |||
| OS Version | Community Appliance | Database version | 8.3.9 | Ant version | 1.7.1 | |||
| Product Version | RR15Q3 | SCM revision | ||||||
| Merge Request Status | ||||||||
| Review Assigned To | guilleaer | |||||||
| OBNetwork customer | OBPS | |||||||
| Support ticket | 38051 | |||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0030741: when layaway is paid, the shipment can be created wrongly | |||||||
| Description | when a layaway is paid, the shipments lines can be created with incorrect quantities. | |||||||
| Steps To Reproduce | no steps to reproduce, but checking the code: . in this line[1], the order lines in var "lineReferences" are loaded sorted by the function getOrderLineList() [1] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l235 [^] . in this line[2], the order lines in var orderLines are loaded from the Json [2] https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l899 [^] and the JSON is retrieved from POS, and in POS the lines are loaded with this SQL (without order by): https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/PaidReceipts.java#l91 [^] To create the shipment lines, the qty is retrieved from var lineReferences: https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l903 [^] and the rest of info of line is retrieved from var orderlines.getJSONObject(i): https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/file/ed027ed9e893/src/org/openbravo/retail/posterminal/OrderLoader.java#l1028 [^] And the elements can be ordered distinct in the two arrays Module script should be done | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
 Relationships [ Relation Graph ]
[ Dependency Graph ]
|
|||||||||||||||
|
|||||||||||||||
 Relationships |
|
Notes |
|
|
(0080391) hgbot (developer) 2015-09-14 22:17 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: 6cdf3bede0b50d62d4e6b57057011b8ab92aaf95 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Mon Sep 14 10:25:06 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6cdf3bede0b50d62d4e6b57057011b8ab92aaf95 [^] Fixed issue 30741: Create lineReferences list based on json lines --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
(0080628) hgbot (developer) 2015-09-24 23:57 |
Repository: tools/automation/pi-mobile Changeset: 9b75bf2b864288c11cd1d9cd279431bce0d234fd Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Thu Sep 24 15:57:08 2015 -0600 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/9b75bf2b864288c11cd1d9cd279431bce0d234fd [^] Related to issue 30741: Automation test to verify the quantity of each line in shipmnet --- A src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I30741_LayawayVerifyShipmentLineQuantity.java --- |
|
(0080669) guilleaer (viewer) 2015-09-28 16:54 |
The fix is not valid because you can have several lines with the same product. In that case the fix is not working. Use GPS handheld (not grouped product to test) I've been able to create a wrong shipment generating a layaway like that: GPS handheld -> 1units Adhesive body warmer -> 2units GPS handheld -> 3units After pay the layaway the shipments amounts will be wrong (both shipments lines qty for product GPS handheld will be one) |
|
(0080722) hgbot (developer) 2015-09-29 19:19 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: eee715f8f9d4f46fbe864fa75b47d172bd50b882 Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Sep 29 11:18:51 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eee715f8f9d4f46fbe864fa75b47d172bd50b882 [^] Fixed issue 30741: Restore to previous change and sort the list by lineNo --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
(0080728) hgbot (developer) 2015-09-29 23:03 |
Repository: erp/pmods/org.openbravo.retail.posterminal Changeset: dc96c55f48c1f9d1134a87d33ea102cd2457a34e Author: Mario Castello <mario.castello <at> peoplewalking.com> Date: Tue Sep 29 15:02:08 2015 -0600 URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/dc96c55f48c1f9d1134a87d33ea102cd2457a34e [^] Related to issue 30741: Change the Collection.sort with load the ordered lines --- M src/org/openbravo/retail/posterminal/OrderLoader.java --- |
|
(0080729) guilleaer (viewer) 2015-09-30 07:51 |
tested and verified |
|
(0081112) hgbot (developer) 2015-10-20 10:10 |
Repository: tools/automation/pi-mobile Changeset: 75aa963034ff5e71b0b1d70b3a93f570722b4486 Author: Rafa Alonso <ral <at> openbravo.com> Date: Tue Oct 20 10:03:21 2015 +0200 URL: http://code.openbravo.com/tools/automation/pi-mobile/rev/75aa963034ff5e71b0b1d70b3a93f570722b4486 [^] Related to issue 30741: Deactivated the 'I30741_LayawayVerifyShipmentLineQuantity' test until fixed --- M src-test/org/openbravo/test/mobile/retail/pack/selenium/tests/layaway/I30741_LayawayVerifyShipmentLineQuantity.java --- |
|
Notes |
|
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2015-09-02 13:50 | malsasua | New Issue | |
| 2015-09-02 13:50 | malsasua | Assigned To | => Retail |
| 2015-09-02 13:50 | malsasua | OBNetwork customer | => Yes |
| 2015-09-02 13:50 | malsasua | Support ticket | => 38051 |
| 2015-09-02 13:50 | malsasua | Resolution time | => 1443823200 |
| 2015-09-02 13:50 | malsasua | Triggers an Emergency Pack | => No |
| 2015-09-08 15:58 | mario_castello | Assigned To | Retail => mario_castello |
| 2015-09-08 20:30 | mario_castello | Status | new => scheduled |
| 2015-09-14 22:17 | hgbot | Checkin | |
| 2015-09-14 22:17 | hgbot | Note Added: 0080391 | |
| 2015-09-14 22:17 | hgbot | Status | scheduled => resolved |
| 2015-09-14 22:17 | hgbot | Resolution | open => fixed |
| 2015-09-14 22:17 | hgbot | Fixed in SCM revision | => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6cdf3bede0b50d62d4e6b57057011b8ab92aaf95 [^] |
| 2015-09-24 23:57 | hgbot | Checkin | |
| 2015-09-24 23:57 | hgbot | Note Added: 0080628 | |
| 2015-09-25 11:02 | Orekaria | Review Assigned To | => guilleaer |
| 2015-09-28 16:54 | guilleaer | Note Added: 0080669 | |
| 2015-09-28 16:54 | guilleaer | Status | resolved => new |
| 2015-09-28 16:54 | guilleaer | Resolution | fixed => open |
| 2015-09-29 19:19 | hgbot | Checkin | |
| 2015-09-29 19:19 | hgbot | Note Added: 0080722 | |
| 2015-09-29 19:19 | hgbot | Status | new => resolved |
| 2015-09-29 19:19 | hgbot | Resolution | open => fixed |
| 2015-09-29 19:19 | hgbot | Fixed in SCM revision | http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6cdf3bede0b50d62d4e6b57057011b8ab92aaf95 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/eee715f8f9d4f46fbe864fa75b47d172bd50b882 [^] |
| 2015-09-29 23:03 | hgbot | Checkin | |
| 2015-09-29 23:03 | hgbot | Note Added: 0080728 | |
| 2015-09-30 07:51 | guilleaer | Note Added: 0080729 | |
| 2015-09-30 07:51 | guilleaer | Status | resolved => closed |
| 2015-09-30 07:51 | guilleaer | Fixed in Version | => RR15Q4 |
| 2015-09-30 09:28 | marvintm | Status | closed => new |
| 2015-09-30 09:28 | marvintm | Resolution | fixed => open |
| 2015-09-30 09:28 | marvintm | Fixed in Version | RR15Q4 => |
| 2015-09-30 09:28 | marvintm | Status | new => acknowledged |
| 2015-09-30 09:28 | marvintm | Status | acknowledged => scheduled |
| 2015-09-30 09:28 | marvintm | Status | scheduled => resolved |
| 2015-09-30 09:28 | marvintm | Resolution | open => fixed |
| 2015-09-30 09:28 | marvintm | Status | resolved => new |
| 2015-09-30 09:28 | marvintm | Resolution | fixed => open |
| 2015-09-30 09:28 | marvintm | Status | new => acknowledged |
| 2015-09-30 09:28 | marvintm | Status | acknowledged => scheduled |
| 2015-09-30 09:29 | marvintm | Status | scheduled => resolved |
| 2015-09-30 09:29 | marvintm | Fixed in Version | => RR15Q4 |
| 2015-09-30 09:29 | marvintm | Resolution | open => fixed |
| 2015-09-30 09:29 | marvintm | Status | resolved => closed |
| 2015-10-20 10:10 | hgbot | Checkin | |
| 2015-10-20 10:10 | hgbot | Note Added: 0081112 | |
|
Issue History |
| Copyright © 2000 - 2009 MantisBT Group |
 |