Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030629
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajoralways2015-08-22 12:042015-09-18 15:14
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in VersionRR15Q4
StatusclosedFix in branchFixed in SCM revision75e5cef0abfa
ProjectionnoneETAnoneTarget VersionRR15Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030629: Stabilization: The amounts of the receipt are calculated when they should not

DescriptionStabilization: The amounts of the receipt are calculated when they should not

The user is key here
The amount seen by the user are the ones that must prevail
Steps To ReproduceAdd a log line in the calculateGross method tracking the caller stacktrace
Verify that the method is being call when it should not
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0023746RMP23 closedmarvintm Bug in web pos payments 
related to defect 0030465RR15Q4 closedOrekaria Stabillization: When the receipt is done, an immutable copy of it should be used in the involved asynchronous processes 
blocks defect 0030603RR15Q4 closedOrekaria Stabilization: RR15Q4 related issues 

-  Notes
(0079602)
hgbot (developer)
2015-08-22 20:35

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6148baedce65d9c4a76b26512ede13e3da884077
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6148baedce65d9c4a76b26512ede13e3da884077 [^]

Related to issue 30629: Add a check to verify that the calculateGross is only being called by the UI receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079603)
hgbot (developer)
2015-08-22 20:35

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 480b37c7634f004490b2641dc652311ade0d9cff
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/480b37c7634f004490b2641dc652311ade0d9cff [^]

Fixes issue 30629: De-asynchronize the saving of the receipt when the calculateGross has finished

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079604)
hgbot (developer)
2015-08-22 20:35

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e1ae36bd15744a6c598a3ee9358483488015b520
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1ae36bd15744a6c598a3ee9358483488015b520 [^]

Fixes issue 30629: Do not recalculate a non UI receipt. Receipt amounts must prevail

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---
(0079608)
hgbot (developer)
2015-08-22 20:35

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6c639642cb3d18eca766e47834e843898357c2eb
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c639642cb3d18eca766e47834e843898357c2eb [^]

Fixes issue 30629: The 'calculateGross' event is no longer fired

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079619)
hgbot (developer)
2015-08-22 20:36

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 75e5cef0abfa668f64faad652aa16d4a8a63b526
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/75e5cef0abfa668f64faad652aa16d4a8a63b526 [^]

Fixes issue 30629: calculateGross can be locked

- will be unlocked when a refresh is performed and there were existing receipts
- will be locked while the receipt is being finished

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0080342)
Orekaria (administrator)
2015-09-11 15:38

 Search for event captures:
this.receipt.on('change:payment change:change calculategross change:bp', function () {

And this code must be fixed:
/web/org.openbravo.mobile.procurement/source/pointofpurchase/mpr-popurchase-tabkeyboardpanel-tabcontainer.js

this.receipt.on('calculategross', function () {

- Issue History
Date Modified Username Field Change
2015-08-22 12:04 Orekaria New Issue
2015-08-22 12:04 Orekaria Assigned To => Orekaria
2015-08-22 12:04 Orekaria Triggers an Emergency Pack => No
2015-08-22 12:04 Orekaria Relationship added blocks 0030603
2015-08-22 12:15 Orekaria Summary Stabilization: The amounts of the receipt are calculated by processes that do not have to => Stabilization: The amounts of the receipt are calculated when they should not
2015-08-22 12:15 Orekaria Description Updated View Revisions
2015-08-22 12:15 Orekaria Proposed Solution updated
2015-08-22 20:35 hgbot Checkin
2015-08-22 20:35 hgbot Note Added: 0079602
2015-08-22 20:35 hgbot Checkin
2015-08-22 20:35 hgbot Note Added: 0079603
2015-08-22 20:35 hgbot Status new => resolved
2015-08-22 20:35 hgbot Resolution open => fixed
2015-08-22 20:35 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/480b37c7634f004490b2641dc652311ade0d9cff [^]
2015-08-22 20:35 hgbot Checkin
2015-08-22 20:35 hgbot Note Added: 0079604
2015-08-22 20:35 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/480b37c7634f004490b2641dc652311ade0d9cff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1ae36bd15744a6c598a3ee9358483488015b520 [^]
2015-08-22 20:35 hgbot Checkin
2015-08-22 20:35 hgbot Note Added: 0079608
2015-08-22 20:35 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1ae36bd15744a6c598a3ee9358483488015b520 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c639642cb3d18eca766e47834e843898357c2eb [^]
2015-08-22 20:36 hgbot Checkin
2015-08-22 20:36 hgbot Note Added: 0079619
2015-08-22 20:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c639642cb3d18eca766e47834e843898357c2eb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/75e5cef0abfa668f64faad652aa16d4a8a63b526 [^]
2015-08-23 11:46 Orekaria Relationship added has duplicate 0030465
2015-08-23 11:47 Orekaria Relationship deleted has duplicate 0030465
2015-08-23 11:48 Orekaria Relationship added related to 0030465
2015-08-23 11:59 Orekaria Relationship added related to 0023746
2015-09-11 15:38 Orekaria Note Added: 0080342
2015-09-18 15:14 marvintm Review Assigned To => marvintm
2015-09-18 15:14 marvintm Status resolved => closed
2015-09-18 15:14 marvintm Fixed in Version => RR15Q4

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker