Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030465
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2015-07-30 15:562015-09-09 17:01
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision7415cc2dc1fd
ProjectionnoneETAnoneTarget VersionRR15Q4
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030465: Stabillization: When the receipt is done, an immutable copy of it should be used in the involved asynchronous processes

DescriptionWhen the receipt is done, an immutable copy of it should be used in the involved asynchronous processes

This way we prevent unwanted changes made by processes not related to the closing of the receipt
Steps To ReproduceVerify that in the 'dataordersave' file,
- an auxreceipt is created but the receipt is used within the asynchronous processes
- an auxreceipt is used in the hooks
- the clearWith method used to clone the receipt, is triggering events
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0030629RR15Q4 closedOrekaria Stabilization: The amounts of the receipt are calculated when they should not 
related to defect 0023746RMP23 closedmarvintm Bug in web pos payments 
depends on design defect 0030479RR15Q4 closedOrekaria Stabilization: Creating a clone of an object should not fire any event 
has duplicate defect 0030473 closedOrekaria eventParams.callback should not wait to the end of sync process when OBPOS_PostSyncReceipt is present 
blocks defect 0030603RR15Q4 closedOrekaria Stabilization: RR15Q4 related issues 
blocks defect 0030805 closedOrekaria Clone of the receipt is no longer necessary, so it should be reverted 

-  Notes
(0079161)
hgbot (developer)
2015-07-31 23:00

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 09f4d69af7c14a24a45af4da58963e16d9aa1444
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Jul 29 16:17:52 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09f4d69af7c14a24a45af4da58963e16d9aa1444 [^]

Fixes issue 30465: A clone of the receipt is used in the asynchronous processes

The problem is that when the receipt is closed, the asynchronous processes receive the live receipt object. This receipt object should not be changed, but still it could

To prevent changes in the receipt while is being finalizing, an immutable copy is sent to the asynchronous processes

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---
(0079194)
hgbot (developer)
2015-08-05 09:39

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 69b8e2c16daea97c246d124fa05d0c7738b99d83
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Wed Aug 05 09:38:50 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69b8e2c16daea97c246d124fa05d0c7738b99d83 [^]

Fixes issue 30465: A clone of the receipt is used in the asynchronous processes (II)

- 'successcallback' is executed before the 'closed' event fires the final callback
- the callback executed after the 'closed' event has been refactored

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0079614)
hgbot (developer)
2015-08-22 20:36

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 7415cc2dc1fd42661309fa03f34c19867d0c63d2
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7415cc2dc1fd42661309fa03f34c19867d0c63d2 [^]

Fixes issue 30465: The hasbeenpaid flag will be set at the end of the transaction

- the problem is that the receipt could have been flushed to the server (by the runsyncprocess) before the receipt was saved
- the rollback callback is used to return the receipt value to 'N'. If the 'hasbeenpaid' value is 'Y', the syncModels process would flush it to the server and delete it from the local database

---
M web/org.openbravo.retail.posterminal/js/data/dataordersave.js
---

- Issue History
Date Modified Username Field Change
2015-07-30 15:56 Orekaria New Issue
2015-07-30 15:56 Orekaria Assigned To => Retail
2015-07-30 15:56 Orekaria Triggers an Emergency Pack => No
2015-07-31 23:00 hgbot Checkin
2015-07-31 23:00 hgbot Note Added: 0079161
2015-07-31 23:01 hgbot Status new => resolved
2015-07-31 23:01 hgbot Resolution open => fixed
2015-07-31 23:01 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09f4d69af7c14a24a45af4da58963e16d9aa1444 [^]
2015-08-05 09:39 hgbot Checkin
2015-08-05 09:39 hgbot Note Added: 0079194
2015-08-05 09:39 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/09f4d69af7c14a24a45af4da58963e16d9aa1444 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69b8e2c16daea97c246d124fa05d0c7738b99d83 [^]
2015-08-05 17:11 Orekaria Relationship added has duplicate 0030473
2015-08-18 18:47 Orekaria Relationship added depends on 0030479
2015-08-19 12:35 Orekaria Relationship added blocks 0030603
2015-08-19 18:33 Orekaria Target Version => RR15Q4
2015-08-19 18:33 Orekaria Summary When the receipt is done, an immutable copy of it should be used in the involved asynchronous processes => Stabillization: When the receipt is done, an immutable copy of it should be used in the involved asynchronous processes
2015-08-20 09:59 Orekaria Assigned To Retail => Orekaria
2015-08-22 20:36 hgbot Checkin
2015-08-22 20:36 hgbot Note Added: 0079614
2015-08-22 20:36 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/69b8e2c16daea97c246d124fa05d0c7738b99d83 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/7415cc2dc1fd42661309fa03f34c19867d0c63d2 [^]
2015-08-22 20:54 Orekaria Summary Stabillization: When the receipt is done, an immutable copy of it should be used in the involved asynchronous processes => Stabillization: The amounts of receipt are being modified after the user has tapped in the 'done' button
2015-08-22 20:54 Orekaria Description Updated View Revisions
2015-08-22 20:55 Orekaria Summary Stabillization: The amounts of receipt are being modified after the user has tapped in the 'done' button => Stabillization: The amounts of the receipt are being modified after the user has tapped in the 'done' button
2015-08-23 11:46 Orekaria Relationship added duplicate of 0030629
2015-08-23 11:47 Orekaria Relationship deleted 0030629
2015-08-23 11:47 Orekaria Summary Stabillization: The amounts of the receipt are being modified after the user has tapped in the 'done' button => Stabillization: When the receipt is done, an immutable copy of it should be used in the involved asynchronous processes
2015-08-23 11:48 Orekaria Relationship added related to 0030629
2015-08-23 11:59 Orekaria Relationship added related to 0023746
2015-09-09 17:01 marvintm Review Assigned To => marvintm
2015-09-09 17:01 marvintm Status resolved => closed
2015-09-09 17:12 Orekaria Relationship added blocks 0030805

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker