Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030629Retail ModulesWeb POSpublic2015-08-22 12:042015-09-18 15:14
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q4Fixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030629: Stabilization: The amounts of the receipt are calculated when they should not
DescriptionStabilization: The amounts of the receipt are calculated when they should not

The user is key here
The amount seen by the user are the ones that must prevail
Steps To ReproduceAdd a log line in the calculateGross method tracking the caller stacktrace
Verify that the method is being call when it should not
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0023746RMP23 closed marvintm Bug in web pos payments 
related to defect 0030465RR15Q4 closed Orekaria Stabillization: When the receipt is done, an immutable copy of it should be used in the involved asynchronous processes 
blocks defect 0030603RR15Q4 closed Orekaria Stabilization: RR15Q4 related issues 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-22 12:04OrekariaNew Issue
2015-08-22 12:04OrekariaAssigned To => Orekaria
2015-08-22 12:04OrekariaOBNetwork customer => No
2015-08-22 12:04OrekariaTriggers an Emergency Pack => No
2015-08-22 12:04OrekariaRelationship addedblocks 0030603
2015-08-22 12:15OrekariaSummaryStabilization: The amounts of the receipt are calculated by processes that do not have to => Stabilization: The amounts of the receipt are calculated when they should not
2015-08-22 12:15OrekariaDescription Updatedbug_revision_view_page.php?rev_id=9241#r9241
2015-08-22 12:15OrekariaProposed Solution updated
2015-08-22 20:35hgbotCheckin
2015-08-22 20:35hgbotNote Added: 0079602
2015-08-22 20:35hgbotCheckin
2015-08-22 20:35hgbotNote Added: 0079603
2015-08-22 20:35hgbotStatusnew => resolved
2015-08-22 20:35hgbotResolutionopen => fixed
2015-08-22 20:35hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/480b37c7634f004490b2641dc652311ade0d9cff [^]
2015-08-22 20:35hgbotCheckin
2015-08-22 20:35hgbotNote Added: 0079604
2015-08-22 20:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/480b37c7634f004490b2641dc652311ade0d9cff [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1ae36bd15744a6c598a3ee9358483488015b520 [^]
2015-08-22 20:35hgbotCheckin
2015-08-22 20:35hgbotNote Added: 0079608
2015-08-22 20:35hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1ae36bd15744a6c598a3ee9358483488015b520 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c639642cb3d18eca766e47834e843898357c2eb [^]
2015-08-22 20:36hgbotCheckin
2015-08-22 20:36hgbotNote Added: 0079619
2015-08-22 20:36hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c639642cb3d18eca766e47834e843898357c2eb [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/75e5cef0abfa668f64faad652aa16d4a8a63b526 [^]
2015-08-23 11:46OrekariaRelationship addedhas duplicate 0030465
2015-08-23 11:47OrekariaRelationship deletedhas duplicate 0030465
2015-08-23 11:48OrekariaRelationship addedrelated to 0030465
2015-08-23 11:59OrekariaRelationship addedrelated to 0023746
2015-09-11 15:38OrekariaNote Added: 0080342
2015-09-18 15:14marvintmReview Assigned To => marvintm
2015-09-18 15:14marvintmStatusresolved => closed
2015-09-18 15:14marvintmFixed in Version => RR15Q4

Notes
(0079602)
hgbot   
2015-08-22 20:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6148baedce65d9c4a76b26512ede13e3da884077
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6148baedce65d9c4a76b26512ede13e3da884077 [^]

Related to issue 30629: Add a check to verify that the calculateGross is only being called by the UI receipt

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079603)
hgbot   
2015-08-22 20:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 480b37c7634f004490b2641dc652311ade0d9cff
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/480b37c7634f004490b2641dc652311ade0d9cff [^]

Fixes issue 30629: De-asynchronize the saving of the receipt when the calculateGross has finished

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079604)
hgbot   
2015-08-22 20:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e1ae36bd15744a6c598a3ee9358483488015b520
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:55 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e1ae36bd15744a6c598a3ee9358483488015b520 [^]

Fixes issue 30629: Do not recalculate a non UI receipt. Receipt amounts must prevail

---
M web/org.openbravo.retail.posterminal/js/closecash/model/cashup-model.js
---
(0079608)
hgbot   
2015-08-22 20:35   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 6c639642cb3d18eca766e47834e843898357c2eb
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/6c639642cb3d18eca766e47834e843898357c2eb [^]

Fixes issue 30629: The 'calculateGross' event is no longer fired

---
M web/org.openbravo.retail.posterminal/js/model/order.js
---
(0079619)
hgbot   
2015-08-22 20:36   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 75e5cef0abfa668f64faad652aa16d4a8a63b526
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Sat Aug 22 20:32:56 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/75e5cef0abfa668f64faad652aa16d4a8a63b526 [^]

Fixes issue 30629: calculateGross can be locked

- will be unlocked when a refresh is performed and there were existing receipts
- will be locked while the receipt is being finished

---
M web/org.openbravo.retail.posterminal/js/model/order.js
M web/org.openbravo.retail.posterminal/js/pointofsale/model/pointofsale-model.js
---
(0080342)
Orekaria   
2015-09-11 15:38   
Search for event captures:
this.receipt.on('change:payment change:change calculategross change:bp', function () {

And this code must be fixed:
/web/org.openbravo.mobile.procurement/source/pointofpurchase/mpr-popurchase-tabkeyboardpanel-tabcontainer.js

this.receipt.on('calculategross', function () {