Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0030518
TypeCategorySeverityReproducibilityDate SubmittedLast Update
design defect[Retail Modules] Web POSmajoralways2015-08-07 12:472015-08-28 16:36
ReporterOrekariaView Statuspublic 
Assigned ToOrekaria 
PrioritynormalResolutionfixedFixed in VersionRR15Q4
StatusclosedFix in branchFixed in SCM revision383cdff5c3df
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomarvintm
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0030518: The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish

DescriptionThe callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish

The problem is that the flows reaching this point are expected to be executed once at the end, and not every paymentmethod

This issue has integrity and performance defect
Steps To ReproduceIn the 'cashupreportutils' file, verify that in the 'OB.UTIL.calculateCurrentCash', the callback is being executed per payment method

Verify that no callback executed by this method, supports this flow decission
Proposed SolutionMake the callback to be run at the end

Even if the callback had any per-payment purpose, create a new callback with a proper name like 'perPaymentMethodCallback' to be sure that later developers can perceive that the behavior is not the expected standard
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on backport 0030519RR15Q3 closedOrekaria The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish 
depends on backport 0030520RR15Q2.4 closedOrekaria The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish 
caused by defect 0026156RR14Q3 closedmarvintm Wrong message If you try to pay a return 
blocks defect 0030603RR15Q4 closedOrekaria Stabilization: RR15Q4 related issues 

-  Notes
(0079253)
hgbot (developer)
2015-08-07 13:45

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 383cdff5c3dfdc5f4dfa0867946c753e16fe4c44
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Aug 07 13:40:14 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/383cdff5c3dfdc5f4dfa0867946c753e16fe4c44 [^]

Fixes issue 30518: The callback in the 'cashUpReportUtils' should be called when the method flow has finished

The problem was that the callback was being executed per payment method, so the callback that is expected to be executed at the end of the method actions, could lead to unwanted results

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0079272)
hgbot (developer)
2015-08-10 09:45

 Repository: retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal
Changeset: b5f6800137c99e27754131110015ae916277b9d1
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Aug 07 13:40:14 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/b5f6800137c99e27754131110015ae916277b9d1 [^]

Fixes issue 30519, backport of issue 30518: The callback in the 'cashUpReportUtils' should be called when the method flow has finished

The problem was that the callback was being executed per payment method, so the callback that is expected to be executed at the end of the method actions, could lead to unwanted results

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0079661)
hgbot (developer)
2015-08-25 08:55

 Repository: retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal
Changeset: 61922c07a6ad828581fc3e6d9bdadc0c3cd782c5
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Aug 07 13:40:14 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/61922c07a6ad828581fc3e6d9bdadc0c3cd782c5 [^]

Fixes issue 30520, backport of issue 30518: The callback in the 'cashUpReportUtils' should be called when the method flow has finished

The problem was that the callback was being executed per payment method, so the callback that is expected to be executed at the end of the method actions, could lead to unwanted results

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---

- Issue History
Date Modified Username Field Change
2015-08-07 12:47 Orekaria New Issue
2015-08-07 12:47 Orekaria Assigned To => Orekaria
2015-08-07 12:47 Orekaria Triggers an Emergency Pack => No
2015-08-07 13:15 Orekaria Status new => scheduled
2015-08-07 13:18 Orekaria Regression level => Production - Confirmed Stable
2015-08-07 13:18 Orekaria Regression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330 [^]
2015-08-07 13:38 Orekaria Regression level Production - Confirmed Stable =>
2015-08-07 13:38 Orekaria Regression introduced by commit https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330 [^] =>
2015-08-07 13:38 Orekaria Type defect => design defect
2015-08-07 13:38 Orekaria Relationship added caused by 0026156
2015-08-07 13:45 hgbot Checkin
2015-08-07 13:45 hgbot Note Added: 0079253
2015-08-07 13:45 hgbot Status scheduled => resolved
2015-08-07 13:45 hgbot Resolution open => fixed
2015-08-07 13:45 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/383cdff5c3dfdc5f4dfa0867946c753e16fe4c44 [^]
2015-08-10 09:45 hgbot Checkin
2015-08-10 09:45 hgbot Note Added: 0079272
2015-08-19 12:40 Orekaria Relationship added blocks 0030603
2015-08-25 08:55 hgbot Checkin
2015-08-25 08:55 hgbot Note Added: 0079661
2015-08-28 16:35 marvintm Review Assigned To => marvintm
2015-08-28 16:35 marvintm Status resolved => closed
2015-08-28 16:35 marvintm Status closed => new
2015-08-28 16:35 marvintm Resolution fixed => open
2015-08-28 16:35 marvintm Status new => scheduled
2015-08-28 16:35 marvintm Status scheduled => resolved
2015-08-28 16:35 marvintm Fixed in Version => RR15Q4
2015-08-28 16:35 marvintm Resolution open => fixed
2015-08-28 16:36 marvintm Status resolved => closed

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker