Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0030518Retail ModulesWeb POSpublic2015-08-07 12:472015-08-28 16:36
ReporterOrekaria 
Assigned ToOrekaria 
PrioritynormalSeveritymajorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionRR15Q4 
Merge Request Status
Review Assigned Tomarvintm
OBNetwork customer
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0030518: The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish
DescriptionThe callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish

The problem is that the flows reaching this point are expected to be executed once at the end, and not every paymentmethod

This issue has integrity and performance defect
Steps To ReproduceIn the 'cashupreportutils' file, verify that in the 'OB.UTIL.calculateCurrentCash', the callback is being executed per payment method

Verify that no callback executed by this method, supports this flow decission
Proposed SolutionMake the callback to be run at the end

Even if the callback had any per-payment purpose, create a new callback with a proper name like 'perPaymentMethodCallback' to be sure that later developers can perceive that the behavior is not the expected standard
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030519RR15Q3 closed Orekaria The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish 
depends on backport 0030520RR15Q2.4 closed Orekaria The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish 
caused by defect 0026156RR14Q3 closed marvintm Wrong message If you try to pay a return 
blocks defect 0030603RR15Q4 closed Orekaria Stabilization: RR15Q4 related issues 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2015-08-07 12:47OrekariaNew Issue
2015-08-07 12:47OrekariaAssigned To => Orekaria
2015-08-07 12:47OrekariaTriggers an Emergency Pack => No
2015-08-07 13:15OrekariaStatusnew => scheduled
2015-08-07 13:18OrekariaRegression level => Production - Confirmed Stable
2015-08-07 13:18OrekariaRegression introduced by commit => https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330 [^]
2015-08-07 13:38OrekariaRegression levelProduction - Confirmed Stable =>
2015-08-07 13:38OrekariaRegression introduced by commithttps://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/195fc620eeb2fcb3b44ba1bb1540ea43ecabe330 [^] =>
2015-08-07 13:38OrekariaTypedefect => design defect
2015-08-07 13:38OrekariaRelationship addedcaused by 0026156
2015-08-07 13:45hgbotCheckin
2015-08-07 13:45hgbotNote Added: 0079253
2015-08-07 13:45hgbotStatusscheduled => resolved
2015-08-07 13:45hgbotResolutionopen => fixed
2015-08-07 13:45hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/383cdff5c3dfdc5f4dfa0867946c753e16fe4c44 [^]
2015-08-10 09:45hgbotCheckin
2015-08-10 09:45hgbotNote Added: 0079272
2015-08-19 12:40OrekariaRelationship addedblocks 0030603
2015-08-25 08:55hgbotCheckin
2015-08-25 08:55hgbotNote Added: 0079661
2015-08-28 16:35marvintmReview Assigned To => marvintm
2015-08-28 16:35marvintmStatusresolved => closed
2015-08-28 16:35marvintmStatusclosed => new
2015-08-28 16:35marvintmResolutionfixed => open
2015-08-28 16:35marvintmStatusnew => scheduled
2015-08-28 16:35marvintmStatusscheduled => resolved
2015-08-28 16:35marvintmFixed in Version => RR15Q4
2015-08-28 16:35marvintmResolutionopen => fixed
2015-08-28 16:36marvintmStatusresolved => closed

Notes
(0079253)
hgbot   
2015-08-07 13:45   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 383cdff5c3dfdc5f4dfa0867946c753e16fe4c44
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Aug 07 13:40:14 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/383cdff5c3dfdc5f4dfa0867946c753e16fe4c44 [^]

Fixes issue 30518: The callback in the 'cashUpReportUtils' should be called when the method flow has finished

The problem was that the callback was being executed per payment method, so the callback that is expected to be executed at the end of the method actions, could lead to unwanted results

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0079272)
hgbot   
2015-08-10 09:45   
Repository: retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal
Changeset: b5f6800137c99e27754131110015ae916277b9d1
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Aug 07 13:40:14 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q3/org.openbravo.retail.posterminal/rev/b5f6800137c99e27754131110015ae916277b9d1 [^]

Fixes issue 30519, backport of issue 30518: The callback in the 'cashUpReportUtils' should be called when the method flow has finished

The problem was that the callback was being executed per payment method, so the callback that is expected to be executed at the end of the method actions, could lead to unwanted results

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0079661)
hgbot   
2015-08-25 08:55   
Repository: retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal
Changeset: 61922c07a6ad828581fc3e6d9bdadc0c3cd782c5
Author: Rafa Alonso <ral <at> openbravo.com>
Date: Fri Aug 07 13:40:14 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/61922c07a6ad828581fc3e6d9bdadc0c3cd782c5 [^]

Fixes issue 30520, backport of issue 30518: The callback in the 'cashUpReportUtils' should be called when the method flow has finished

The problem was that the callback was being executed per payment method, so the callback that is expected to be executed at the end of the method actions, could lead to unwanted results

---
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---