0030520: The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish

Description

The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish

The problem is that the flows reaching this point are expected to be executed once at the end, and not every paymentmethod

This issue has integrity and performance defect

Steps To Reproduce

In the 'cashupreportutils' file, verify that in the 'OB.UTIL.calculateCurrentCash', the callback is being executed per payment method

Verify that no callback executed by this method, supports this flow decission

Proposed Solution

Make the callback to be run at the end

Even if the callback had any per-payment purpose, create a new callback with a proper name like 'perPaymentMethodCallback' to be sure that later developers can perceive that the behavior is not the expected standard

Tags

No tags attached.

Attached Files

Relationships [ Relation Graph ] [ Dependency Graph ]

blocks

design defect

0030518

closed

Orekaria

The callback in 'OB.UTIL.calculateCurrentCash' should be called once, on finish

Notes
(0079662) hgbot (developer) 2015-08-25 08:55	Repository: retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal Changeset: 61922c07a6ad828581fc3e6d9bdadc0c3cd782c5 Author: Rafa Alonso <ral <at> openbravo.com> Date: Fri Aug 07 13:40:14 2015 +0200 URL: http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/61922c07a6ad828581fc3e6d9bdadc0c3cd782c5 [^] Fixes issue 30520, backport of issue 30518: The callback in the 'cashUpReportUtils' should be called when the method flow has finished The problem was that the callback was being executed per payment method, so the callback that is expected to be executed at the end of the method actions, could lead to unwanted results --- M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js ---

Issue History
Date Modified	Username	Field	Change
2015-08-07 13:15	Orekaria	Type	defect => backport
2015-08-07 13:15	Orekaria	Target Version	=> RR15Q2.4
2015-08-25 08:55	hgbot	Checkin
2015-08-25 08:55	hgbot	Note Added: 0079662
2015-08-25 08:55	hgbot	Status	scheduled => resolved
2015-08-25 08:55	hgbot	Resolution	open => fixed
2015-08-25 08:55	hgbot	Fixed in SCM revision	=> http://code.openbravo.com/retail/backports/3.0RR15Q2.4/org.openbravo.retail.posterminal/rev/61922c07a6ad828581fc3e6d9bdadc0c3cd782c5 [^]
2015-08-25 15:53	marvintm	Review Assigned To	=> marvintm
2015-08-25 15:53	marvintm	Status	resolved => closed
2015-08-25 15:53	marvintm	Fixed in Version	=> RR15Q2.4