Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029418
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformcriticalhave not tried2015-03-26 08:422015-03-26 16:35
ReporteralostaleView Statuspublic 
Assigned Toalostale 
PriorityimmediateResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision-
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned To
Web browser
ModulesCore
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0029418: API change in process definition client side validation function

DescriptionIn order to fix issue 0029416 Done button in process definition is locked while client side validations are being executed. If the validation succeeds, the complete UI is locked to execute the process, but if it fails, UI should be unlocked again.

As client side validation can perform asynchronous tasks, caller cannot decide when the UI should be unlocked, so this should be done by the client side definition function.

Proposed API change:

-Current API for client side validation functions [1] is:
  function (view, actionHandlerCall)
    This function is charge of invoking actionHandlerCall in case of successful validation or do nothing if they fail.
    

-New proposed API:
  function (view, actionHandlerCall, clientSideValidationFail)
    Now the function should call actionHandlerCall in case of success and clientSideValidationFail in case of invalid.


[1] http://wiki.openbravo.com/wiki/How_to_create_a_Standard_Process_Definition#Invoking_a_client_side_validation_before_calling_the_action_handler [^]
Steps To Reproduce-
Proposed SolutionThis change affects to all process definitions with client side validations (this feature was added in PR14Q3), it affects 5 processes in Openbravo 3 distribution, but as it is a relatively new feature, we don't expect many modules making use of it.

Risk assessment: medium

Components affected by this change that are not updated would misbehave in case parameter values don't satisfy client side validation, in which case Done button would be locked. When in this situation, button would be unlocked in case of changing parameter values or if the process popup/window is reopened.

Note if issue 0029388 is backported to PR15Q1, this API change will also be backported.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to feature request 00259953.0PR14Q3 closedAugustoMauch Parameter Windows Phase III 
depends on backport 00294243.0PR15Q1.3 closedalostale API change in process definition client side validation function 
blocks backport 00294163.0PR15Q1.3 closedalostale Duplicated records in Used Credit Source tab when clicking Done more than once in Add Details pop-up 
blocks defect 0029388 closedalostale Duplicated records in Used Credit Source tab when clicking Done more than once in Add Details pop-up 

-  Notes
(0075990)
dmitry_mezentsev (developer)
2015-03-26 10:24

 Approved.
(0075991)
hgbot (developer)
2015-03-26 10:33

 Repository: erp/devel/pi
Changeset: 9216d290b2f207e748568dc7430aaf7ca41d5033
Author: Asier Lostalé <asier.lostale <at> openbravo.com>
Date: Thu Mar 26 10:26:30 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/9216d290b2f207e748568dc7430aaf7ca41d5033 [^]

fixed bug 29388, related to issue 29418: Done can be clicked more than once

  In process definition Done button was enabled and clickable while client side
  validations were being evaluated. This was specially noticeable if those validations
  perform backend requests to be completed (which is the case of Add Payment).

  Fixed by disabling Done button as first step before executing any validation.

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addTransaction.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-findTransaction.js
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-matchStatement.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-parameter-window-view.js
M web/js/validateCostingRuleProcess.js
---
(0076023)
hudsonbot (developer)
2015-03-26 16:35

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/74bd53f51456 [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2015-03-26 08:42 alostale New Issue
2015-03-26 08:42 alostale Assigned To => dmitry_mezentsev
2015-03-26 08:42 alostale Modules => Core
2015-03-26 08:42 alostale Triggers an Emergency Pack => No
2015-03-26 08:43 alostale Proposed Solution updated
2015-03-26 08:43 alostale Relationship added blocks 0025995
2015-03-26 08:44 alostale Relationship replaced related to 0025995
2015-03-26 08:44 alostale Relationship added blocks 0029416
2015-03-26 08:44 alostale Relationship added blocks 0029388
2015-03-26 10:24 dmitry_mezentsev Note Added: 0075990
2015-03-26 10:24 dmitry_mezentsev Assigned To dmitry_mezentsev => alostale
2015-03-26 10:33 hgbot Checkin
2015-03-26 10:33 hgbot Note Added: 0075991
2015-03-26 10:37 alostale Status new => scheduled
2015-03-26 11:15 alostale Status scheduled => resolved
2015-03-26 11:15 alostale Fixed in SCM revision => -
2015-03-26 11:15 alostale Resolution open => fixed
2015-03-26 11:15 alostale Status resolved => closed
2015-03-26 16:35 hudsonbot Checkin
2015-03-26 16:35 hudsonbot Note Added: 0076023

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker