Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0029032
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformcriticalhave not tried2015-02-23 18:132015-03-02 08:39
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revisionb8e082853490
ProjectionnoneETAnoneTarget Version
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toalostale
Web browser
ModulesCore
Regression levelAutomated tests
Regression date2015-02-23
Regression introduced in releasepi
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/d061c9e837aa5a0ce0a7fb221e1ac8c822748988 [^]
Triggers an Emergency PackNo
Summary

0029032: int-basic-pgsql/oracle tests are broken due to change in pick and execute windows

Descriptionwhen this changeset [1] was pushed to pi the int-basic-pgsql and int-basic-oracle tests stopped working. The problem seems to be that the actions that be done when a record is selected in a Pick and Edit window are not taking place.

[1] https://code.openbravo.com/erp/devel/pi/rev/d061c9e837aa5a0ce0a7fb221e1ac8c822748988 [^]
Steps To ReproduceSee [1] and [2]

[1] http://ci.openbravo.com/job/int-basic-pgsql/772/ [^]
[2] http://ci.openbravo.com/job/int-basic-oracle/780/ [^]
TagsNo tags attached.
Attached Files

- Relationships Relation Graph ] Dependency Graph ]
caused by defect 00287123.0PR15Q2 closedalostale Records selection is lost in pick and execute window under some circumnstances 

-  Notes
(0074815)
hgbot (developer)
2015-02-23 18:22

Repository: erp/devel/pi
Changeset: 7b4dd6eca8a6caf515c1b09f969069da0482d88e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 23 18:20:43 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7b4dd6eca8a6caf515c1b09f969069da0482d88e [^]

Fixes bug 29032: Arguments to the selectionChanged function are passed properly

Before this changeset [1] was committed, the OBPickAndExecuteGrid.selectionUpdated(record, selected) function did not take into account the second parameter. This parameter was set to true if the record was being selected and to false if it was being deselected.

Now that the selected parameter is being taking into account, some APRM logic that should be executed when a record in a P&E window is selected is not being run. The problem was that tje selection updated function was being called incorrectly, like this:

this.Super('selectionChanged', record, state);

When invoking the Super function, all the parameters that are to be passed to the function should be included in the second argument (as an array if there are more than one). This is the way it should be done:

this.Super('selectionChanged', [record, state]);

[1] https://code.openbravo.com/erp/devel/pi/rev/d061c9e837aa5a0ce0a7fb221e1ac8c822748988 [^]

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0074828)
hgbot (developer)
2015-02-24 10:56

Repository: erp/devel/pi
Changeset: 3a5c4c183c9c5ea6816975ff39b78331accc1b28
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 24 10:55:13 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3a5c4c183c9c5ea6816975ff39b78331accc1b28 [^]

Related with issue 29032: Use arguments keyword instead of parameter array

The achieved result is the same, but using the arguments keyword is better because it would not be affected by a change in the name of the parameters

---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
(0074831)
hgbot (developer)
2015-02-24 11:08

Repository: erp/devel/pi
Changeset: b8e08285349001bc1d72d2a0a49f40be59a1e2db
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 24 11:07:02 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b8e08285349001bc1d72d2a0a49f40be59a1e2db [^]

Fixes issue 29032, related with issue 28712: Backs out changeset d061c9e837aa

This changeset has been backed out as it is breaking the int-basic-pgsql and int-basic-oracle tests.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-pickeditgrid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
(0074892)
hudsonbot (developer)
2015-02-24 23:09

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6c8e140b31ec [^]
Maturity status: Test
(0074893)
hudsonbot (developer)
2015-02-24 23:09

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6c8e140b31ec [^]
Maturity status: Test
(0074894)
hudsonbot (developer)
2015-02-24 23:09

A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/6c8e140b31ec [^]
Maturity status: Test
(0075052)
alostale (manager)
2015-03-02 08:39

code reviewed + tested

- Issue History
Date Modified Username Field Change
2015-02-23 18:13 AugustoMauch New Issue
2015-02-23 18:13 AugustoMauch Assigned To => AugustoMauch
2015-02-23 18:13 AugustoMauch Modules => Core
2015-02-23 18:13 AugustoMauch Regression level => Automated tests
2015-02-23 18:13 AugustoMauch Regression date => 2015-02-23
2015-02-23 18:13 AugustoMauch Regression introduced in release => pi
2015-02-23 18:13 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/d061c9e837aa5a0ce0a7fb221e1ac8c822748988 [^]
2015-02-23 18:13 AugustoMauch Triggers an Emergency Pack => No
2015-02-23 18:13 AugustoMauch Relationship added caused by 0028712
2015-02-23 18:21 AugustoMauch Issue Monitored: alostale
2015-02-23 18:21 AugustoMauch Review Assigned To => alostale
2015-02-23 18:22 hgbot Checkin
2015-02-23 18:22 hgbot Note Added: 0074815
2015-02-23 18:22 hgbot Status new => resolved
2015-02-23 18:22 hgbot Resolution open => fixed
2015-02-23 18:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7b4dd6eca8a6caf515c1b09f969069da0482d88e [^]
2015-02-24 10:56 hgbot Checkin
2015-02-24 10:56 hgbot Note Added: 0074828
2015-02-24 11:08 hgbot Checkin
2015-02-24 11:08 hgbot Note Added: 0074831
2015-02-24 11:08 hgbot Fixed in SCM revision http://code.openbravo.com/erp/devel/pi/rev/7b4dd6eca8a6caf515c1b09f969069da0482d88e [^] => http://code.openbravo.com/erp/devel/pi/rev/b8e08285349001bc1d72d2a0a49f40be59a1e2db [^]
2015-02-24 23:09 hudsonbot Checkin
2015-02-24 23:09 hudsonbot Note Added: 0074892
2015-02-24 23:09 hudsonbot Checkin
2015-02-24 23:09 hudsonbot Note Added: 0074893
2015-02-24 23:09 hudsonbot Checkin
2015-02-24 23:09 hudsonbot Note Added: 0074894
2015-03-02 08:39 alostale Note Added: 0075052
2015-03-02 08:39 alostale Status resolved => closed
2015-03-02 08:39 alostale Fixed in Version => 3.0PR15Q2


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker