|
Notes |
|
|
(0074815)
|
|
hgbot
|
|
2015-02-23 18:22
|
|
Repository: erp/devel/pi
Changeset: 7b4dd6eca8a6caf515c1b09f969069da0482d88e
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Mon Feb 23 18:20:43 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7b4dd6eca8a6caf515c1b09f969069da0482d88e [^]
Fixes bug 29032: Arguments to the selectionChanged function are passed properly
Before this changeset [1] was committed, the OBPickAndExecuteGrid.selectionUpdated(record, selected) function did not take into account the second parameter. This parameter was set to true if the record was being selected and to false if it was being deselected.
Now that the selected parameter is being taking into account, some APRM logic that should be executed when a record in a P&E window is selected is not being run. The problem was that tje selection updated function was being called incorrectly, like this:
this.Super('selectionChanged', record, state);
When invoking the Super function, all the parameters that are to be passed to the function should be included in the second argument (as an array if there are more than one). This is the way it should be done:
this.Super('selectionChanged', [record, state]);
[1] https://code.openbravo.com/erp/devel/pi/rev/d061c9e837aa5a0ce0a7fb221e1ac8c822748988 [^]
---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
|
|
|
|
(0074828)
|
|
hgbot
|
|
2015-02-24 10:56
|
|
Repository: erp/devel/pi
Changeset: 3a5c4c183c9c5ea6816975ff39b78331accc1b28
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 24 10:55:13 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/3a5c4c183c9c5ea6816975ff39b78331accc1b28 [^]
Related with issue 29032: Use arguments keyword instead of parameter array
The achieved result is the same, but using the arguments keyword is better because it would not be affected by a change in the name of the parameters
---
M modules/org.openbravo.advpaymentmngt/web/org.openbravo.advpaymentmngt/js/ob-aprm-addPayment.js
---
|
|
|
|
(0074831)
|
|
hgbot
|
|
2015-02-24 11:08
|
|
Repository: erp/devel/pi
Changeset: b8e08285349001bc1d72d2a0a49f40be59a1e2db
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 24 11:07:02 2015 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/b8e08285349001bc1d72d2a0a49f40be59a1e2db [^]
Fixes issue 29032, related with issue 28712: Backs out changeset d061c9e837aa
This changeset has been backed out as it is breaking the int-basic-pgsql and int-basic-oracle tests.
---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-pickeditgrid.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/process/ob-pick-and-execute-grid.js
---
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|