Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0029003
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] 07. Sales managementmajoralways2015-02-19 23:182016-04-08 11:00
ReporterreinaldoguerraView Statuspublic 
Assigned Toreinaldoguerra 
PrioritynormalResolutionfixedFixed in Version3.0PR15Q2
StatusclosedFix in branchFixed in SCM revision4f00f31f65e1
ProjectionnoneETAnoneTarget Version3.0PR15Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toaferraz
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2014-02-20
Regression introduced in release3.0PR14Q2
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/0b033ca5bd1b08e81a30cfdbab2b459549d8c17c [^]
Triggers an Emergency PackNo
Summary

0029003: Error in log when typing a wrong filter in Manage Reservation Stock pop-up

DescriptionWhen typing a wrong filter in some columns in Manage Reservation Stock pop-up, an error is registerd in the log.
Steps To Reproduce1- Login into Openbravo ERP
2- As group admin role, set the Enable Stock Reservation preference to 'Y'
3- Logout and login again
4- Go to Sales Order window and create a header.
5- Go to lines and create a new one, select a product that has stock (for example Vino Blanco)
6- Book it
7- Go to the lines tab and open the Manage Reservation pop-up
8- Type a wrong filter in warehouse's column and check no records are shown but:
   The logs shows: ERROR org.openbravo.client.kernel.KernelUtils - unexpected end of subtree
   
Note: Same occurs from Stock reservation window
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 00289073.0PR15Q3 closedreinaldoguerra Cannot filter the Manage Reservation Stock pop-up of Sales Order window 
depends on backport 00294493.0PR15Q1.3 closedreinaldoguerra Error in log when typing a wrong filter in Manage Reservation Stock pop-up 
caused by design defect 0023412 closedSandrahuguet Manage Stock Pick and Execute Window does not work with large amount of data 
causes defect 0029479 closedaferraz Lines still showing when filtering by a wrong value in a number type column in Manage Reservation popup 

-  Notes
(0074806)
reinaldoguerra (developer)
2015-02-23 14:18
edited on: 2015-02-23 19:12

 Test plan used:
1- Login into Openbravo ERP
2- As group admin role, set the Enable Stock Reservation preference to 'Y'
3- Logout and login again
4- Go to Sales Order window and create a header.
5- Go to lines and create a new one, select a product that has stock (for example Vino Blanco)
6- Book it
7- Go to the lines tab and open the Manage Reservation pop-up
8- Type a wrong filter in warehouse's column and check no log errors are shown. The same for the rest of columns with data to be filtered.
9- Now go to Stock reservation window and make the same test selecting one record and clicking Manage Stock button.
(0076052)
hgbot (developer)
2015-03-27 08:33

 Repository: erp/devel/pi
Changeset: 4f00f31f65e1024bf0a9e985297f8bef5746b68f
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Wed Mar 25 12:25:21 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/4f00f31f65e1024bf0a9e985297f8bef5746b68f [^]

Fixed bug 28907, fixed bug 27848, fixed bug 29003

The following changes was made in Stock Reservation pick and edit:
When filters are executed, a Reservation entity is created from the json parameter "@MaterialMgmtReservation.id@". This works fine when the pop-up is called from Stock Reservation window, but from Sales Order, this parameter does not exists, and the filter process fails. Now is included a code line that puts a "@MaterialMgmtReservation.id@" into the json parameters before the filters are applied.
Array critera filtering was bad created when getting grid's data, so was changed, to allow filter's multiple selection.
An hibernate exception is launched when typing wrong filters and the expression "in ()" is included in the query to be executed. So this expression was replaced by one which returns a false value: "1 = 2".
Were included also, changes to allow filtering quantity's column. Other changes were included to avoid exceptions comparing to null values.

---
M src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
---
(0076059)
aferraz (manager)
2015-03-27 09:45

 Related to 29003: Avoid exception

Avoid exceptions in getOrderLineSetValueFilterData and getAttributeSetValueFilterData methods

https://code.openbravo.com/erp/devel/pi/rev/12e2fb2008f2 [^]
(0076060)
aferraz (manager)
2015-03-27 09:46

 Related to 29003: Avoid exception when filtering by number

Avoid exceptions when retrieving the value of the filter in number-type columns and the value is not a number

https://code.openbravo.com/erp/devel/pi/rev/bb85cbd52ff0 [^]
(0076061)
aferraz (manager)
2015-03-27 09:46

 Code review + Testing OK
(0076098)
hudsonbot (developer)
2015-03-27 15:58

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e2f5d600634 [^]
Maturity status: Test
(0076679)
Sandrahuguet (developer)
2015-04-22 09:59

 Test added in teslink

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8204 [^]
(0085525)
hgbot (developer)
2016-04-08 11:00

 Repository: tools/automation/int
Changeset: 777758126bdbe2cf3cc1a64d0f98ffc75330734c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Feb 26 08:46:30 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/777758126bdbe2cf3cc1a64d0f98ffc75330734c [^]

Related to issue 28907 & Related to issue 27848 & Related to issue 29003: Add an automated test

---
M src-test/com/openbravo/test/integration/erp/data/sales/transactions/salesorder/ManageReservationData.java
M src-test/com/openbravo/test/integration/erp/gui/sales/transactions/salesorder/LinesTab.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/pickandexecute/PickAndExecuteWindow.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RES_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/testscripts/sales/transactions/SalesOrder.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RESRegression28907R27848R29003.java
---

- Issue History
Date Modified Username Field Change
2015-02-19 23:18 reinaldoguerra New Issue
2015-02-19 23:18 reinaldoguerra Assigned To => reinaldoguerra
2015-02-19 23:18 reinaldoguerra Modules => Core
2015-02-19 23:18 reinaldoguerra Resolution time => 1426114800
2015-02-19 23:18 reinaldoguerra Triggers an Emergency Pack => No
2015-02-19 23:27 reinaldoguerra Relationship added depends on 0028907
2015-02-20 08:23 Sandrahuguet Priority urgent => normal
2015-02-20 21:38 reinaldoguerra Steps to Reproduce Updated View Revisions
2015-02-23 14:18 reinaldoguerra Note Added: 0074806
2015-02-23 19:12 reinaldoguerra Note Edited: 0074806 View Revisions
2015-03-17 14:14 reinaldoguerra Status new => scheduled
2015-03-24 18:27 aferraz Regression level => Production - Confirmed Stable
2015-03-24 18:27 aferraz Regression date => 2014-02-20
2015-03-24 18:27 aferraz Regression introduced in release => 3.0PR14Q2
2015-03-24 18:27 aferraz Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/0b033ca5bd1b08e81a30cfdbab2b459549d8c17c [^]
2015-03-24 18:28 aferraz Relationship added caused by 0023412
2015-03-27 08:33 hgbot Checkin
2015-03-27 08:33 hgbot Note Added: 0076052
2015-03-27 08:33 hgbot Status scheduled => resolved
2015-03-27 08:33 hgbot Resolution open => fixed
2015-03-27 08:33 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4f00f31f65e1024bf0a9e985297f8bef5746b68f [^]
2015-03-27 08:35 aferraz Review Assigned To => aferraz
2015-03-27 08:35 aferraz Note Added: 0076056
2015-03-27 08:35 aferraz Status resolved => closed
2015-03-27 09:45 aferraz Note Added: 0076059
2015-03-27 09:46 aferraz Note Added: 0076060
2015-03-27 09:46 aferraz Note Deleted: 0076056
2015-03-27 09:46 aferraz Note Added: 0076061
2015-03-27 14:51 aferraz Status closed => new
2015-03-27 14:51 aferraz Resolution fixed => open
2015-03-27 14:52 aferraz Status new => scheduled
2015-03-27 14:52 aferraz Status scheduled => resolved
2015-03-27 14:52 aferraz Resolution open => fixed
2015-03-27 14:52 aferraz Status resolved => closed
2015-03-27 15:58 hudsonbot Checkin
2015-03-27 15:58 hudsonbot Note Added: 0076098
2015-03-31 18:21 aferraz Relationship added causes 0029479
2015-04-01 18:14 dmitry_mezentsev Fixed in Version => 3.0PR15Q2
2015-04-01 18:14 dmitry_mezentsev Target Version => 3.0PR15Q2
2015-04-22 09:59 Sandrahuguet Note Added: 0076679
2016-04-08 11:00 hgbot Checkin
2016-04-08 11:00 hgbot Note Added: 0085525

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker