Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
0029003Openbravo ERP07. Sales managementpublic2015-02-19 23:182016-04-08 11:00
reinaldoguerra 
reinaldoguerra 
normalmajoralways
closedfixed 
5
 
3.0PR15Q23.0PR15Q2 
aferraz
Core
Production - Confirmed Stable
2014-02-20
3.0PR14Q2
https://code.openbravo.com/erp/devel/pi/rev/0b033ca5bd1b08e81a30cfdbab2b459549d8c17c [^]
No
0029003: Error in log when typing a wrong filter in Manage Reservation Stock pop-up
When typing a wrong filter in some columns in Manage Reservation Stock pop-up, an error is registerd in the log.
1- Login into Openbravo ERP
2- As group admin role, set the Enable Stock Reservation preference to 'Y'
3- Logout and login again
4- Go to Sales Order window and create a header.
5- Go to lines and create a new one, select a product that has stock (for example Vino Blanco)
6- Book it
7- Go to the lines tab and open the Manage Reservation pop-up
8- Type a wrong filter in warehouse's column and check no records are shown but:
   The logs shows: ERROR org.openbravo.client.kernel.KernelUtils - unexpected end of subtree
   
Note: Same occurs from Stock reservation window
No tags attached.
depends on defect 00289073.0PR15Q3 closed reinaldoguerra Cannot filter the Manage Reservation Stock pop-up of Sales Order window 
depends on backport 00294493.0PR15Q1.3 closed reinaldoguerra Error in log when typing a wrong filter in Manage Reservation Stock pop-up 
caused by design defect 0023412 closed Sandrahuguet Manage Stock Pick and Execute Window does not work with large amount of data 
causes defect 0029479 closed aferraz Lines still showing when filtering by a wrong value in a number type column in Manage Reservation popup 
Issue History
2015-02-19 23:18reinaldoguerraNew Issue
2015-02-19 23:18reinaldoguerraAssigned To => reinaldoguerra
2015-02-19 23:18reinaldoguerraModules => Core
2015-02-19 23:18reinaldoguerraResolution time => 1426114800
2015-02-19 23:18reinaldoguerraTriggers an Emergency Pack => No
2015-02-19 23:27reinaldoguerraRelationship addeddepends on 0028907
2015-02-20 08:23SandrahuguetPriorityurgent => normal
2015-02-20 21:38reinaldoguerraSteps to Reproduce Updatedbug_revision_view_page.php?rev_id=7732#r7732
2015-02-23 14:18reinaldoguerraNote Added: 0074806
2015-02-23 19:12reinaldoguerraNote Edited: 0074806bug_revision_view_page.php?bugnote_id=0074806#r7747
2015-03-17 14:14reinaldoguerraStatusnew => scheduled
2015-03-24 18:27aferrazRegression level => Production - Confirmed Stable
2015-03-24 18:27aferrazRegression date => 2014-02-20
2015-03-24 18:27aferrazRegression introduced in release => 3.0PR14Q2
2015-03-24 18:27aferrazRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/0b033ca5bd1b08e81a30cfdbab2b459549d8c17c [^]
2015-03-24 18:28aferrazRelationship addedcaused by 0023412
2015-03-27 08:33hgbotCheckin
2015-03-27 08:33hgbotNote Added: 0076052
2015-03-27 08:33hgbotStatusscheduled => resolved
2015-03-27 08:33hgbotResolutionopen => fixed
2015-03-27 08:33hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/4f00f31f65e1024bf0a9e985297f8bef5746b68f [^]
2015-03-27 08:35aferrazReview Assigned To => aferraz
2015-03-27 08:35aferrazNote Added: 0076056
2015-03-27 08:35aferrazStatusresolved => closed
2015-03-27 09:45aferrazNote Added: 0076059
2015-03-27 09:46aferrazNote Added: 0076060
2015-03-27 09:46aferrazNote Deleted: 0076056
2015-03-27 09:46aferrazNote Added: 0076061
2015-03-27 14:51aferrazStatusclosed => new
2015-03-27 14:51aferrazResolutionfixed => open
2015-03-27 14:52aferrazStatusnew => scheduled
2015-03-27 14:52aferrazStatusscheduled => resolved
2015-03-27 14:52aferrazResolutionopen => fixed
2015-03-27 14:52aferrazStatusresolved => closed
2015-03-27 15:58hudsonbotCheckin
2015-03-27 15:58hudsonbotNote Added: 0076098
2015-03-31 18:21aferrazRelationship addedcauses 0029479
2015-04-01 18:14dmitry_mezentsevFixed in Version => 3.0PR15Q2
2015-04-01 18:14dmitry_mezentsevTarget Version => 3.0PR15Q2
2015-04-22 09:59SandrahuguetNote Added: 0076679
2016-04-08 11:00hgbotCheckin
2016-04-08 11:00hgbotNote Added: 0085525

Notes
(0074806)
reinaldoguerra   
2015-02-23 14:18   
(edited on: 2015-02-23 19:12)
Test plan used:
1- Login into Openbravo ERP
2- As group admin role, set the Enable Stock Reservation preference to 'Y'
3- Logout and login again
4- Go to Sales Order window and create a header.
5- Go to lines and create a new one, select a product that has stock (for example Vino Blanco)
6- Book it
7- Go to the lines tab and open the Manage Reservation pop-up
8- Type a wrong filter in warehouse's column and check no log errors are shown. The same for the rest of columns with data to be filtered.
9- Now go to Stock reservation window and make the same test selecting one record and clicking Manage Stock button.

(0076052)
hgbot   
2015-03-27 08:33   
Repository: erp/devel/pi
Changeset: 4f00f31f65e1024bf0a9e985297f8bef5746b68f
Author: Reinaldo Guerra <reinaldo.guerra <at> peoplewalking.com>
Date: Wed Mar 25 12:25:21 2015 -0500
URL: http://code.openbravo.com/erp/devel/pi/rev/4f00f31f65e1024bf0a9e985297f8bef5746b68f [^]

Fixed bug 28907, fixed bug 27848, fixed bug 29003

The following changes was made in Stock Reservation pick and edit:
When filters are executed, a Reservation entity is created from the json parameter "@MaterialMgmtReservation.id@". This works fine when the pop-up is called from Stock Reservation window, but from Sales Order, this parameter does not exists, and the filter process fails. Now is included a code line that puts a "@MaterialMgmtReservation.id@" into the json parameters before the filters are applied.
Array critera filtering was bad created when getting grid's data, so was changed, to allow filter's multiple selection.
An hibernate exception is launched when typing wrong filters and the expression "in ()" is included in the query to be executed. So this expression was replaced by one which returns a false value: "1 = 2".
Were included also, changes to allow filtering quantity's column. Other changes were included to avoid exceptions comparing to null values.

---
M src/org/openbravo/common/datasource/StockReservationPickAndEditDataSource.java
---
(0076059)
aferraz   
2015-03-27 09:45   
Related to 29003: Avoid exception

Avoid exceptions in getOrderLineSetValueFilterData and getAttributeSetValueFilterData methods

https://code.openbravo.com/erp/devel/pi/rev/12e2fb2008f2 [^]
(0076060)
aferraz   
2015-03-27 09:46   
Related to 29003: Avoid exception when filtering by number

Avoid exceptions when retrieving the value of the filter in number-type columns and the value is not a number

https://code.openbravo.com/erp/devel/pi/rev/bb85cbd52ff0 [^]
(0076061)
aferraz   
2015-03-27 09:46   
Code review + Testing OK
(0076098)
hudsonbot   
2015-03-27 15:58   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/9e2f5d600634 [^]
Maturity status: Test
(0076679)
Sandrahuguet   
2015-04-22 09:59   
Test added in teslink

https://testlink.openbravo.com/testlink/linkto.php?tprojectPrefix=Communit&item=testcase&id=Communit-8204 [^]
(0085525)
hgbot   
2016-04-08 11:00   
Repository: tools/automation/int
Changeset: 777758126bdbe2cf3cc1a64d0f98ffc75330734c
Author: Alvaro Ferraz <alvaro.ferraz <at> openbravo.com>
Date: Fri Feb 26 08:46:30 2016 +0100
URL: http://code.openbravo.com/tools/automation/int/rev/777758126bdbe2cf3cc1a64d0f98ffc75330734c [^]

Related to issue 28907 & Related to issue 27848 & Related to issue 29003: Add an automated test

---
M src-test/com/openbravo/test/integration/erp/data/sales/transactions/salesorder/ManageReservationData.java
M src-test/com/openbravo/test/integration/erp/gui/sales/transactions/salesorder/LinesTab.java
M src-test/com/openbravo/test/integration/erp/modules/client/application/gui/pickandexecute/PickAndExecuteWindow.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RES_RegressionSuite.java
M src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/build.xml
M src-test/com/openbravo/test/integration/erp/testscripts/sales/transactions/SalesOrder.java
A src-test/com/openbravo/test/integration/erp/modules/functionalteam/reservation/testsuites/RES_Regressions/RESRegression28907R27848R29003.java
---