Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue DetailsJump to Notes ] Issue History ] Print ]
ID
0028975
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Cash upminoralways2015-02-17 23:062015-09-28 11:04
ReportermalsasuaView Statuspublic 
Assigned Tomarvintm 
PrioritynormalResolutionfixedFixed in Version
StatusclosedFix in branchFixed in SCM revision616729f0e0ec
ProjectionnoneETAnoneTarget Version
OSLinux 32 bitDatabasePostgreSQLJava version1.6.0_18
OS VersionCommunity ApplianceDatabase version8.3.9Ant version1.7.1
Product VersionSCM revision 
Review Assigned Toadrianromero
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028975: additional checks to avoid wrong cashups

DescriptionWhen a same terminal is accessed from two or more devices, the cashups generated by this terminal can be wrong.

When it happens, the cashup should not be processed and it should be included in "Errors while importing data" window
Steps To Reproducein device1
. clean cache
. do login in VBS-1
. new cashup with "id1" is created in local database
. create and pay a new receipt
. logout

in device2
. clean cache
. do login in VBS-1
. cashup with "id1" is loaded in local database
. create and pay a new receipt
. do a cashup
. logout

in device1
. do login in VBS-1
. cashup with "id1" is loaded in local database
. create and pay a new receipt

in backoffice, the cashup with "id1" is set as
. processed=N
. processedbo=Y

it is wrong
TagsNo tags attached.
Attached Filesdiff file icon diffNewChecks_Q11.diff [^] (2,835 bytes) 2015-02-17 23:08 [Show Content]
diff file icon diffProcessedToN_Q11.diff [^] (2,202 bytes) 2015-02-17 23:08 [Show Content]

- Relationships Relation Graph ] Dependency Graph ]
depends on backport 0030946RR15Q2.5 closedmarvintm additional checks to avoid wrong cashups 
has duplicate defect 0030830 closedRetail cashup in backoffice is updated with old record 

-  Notes
(0076393)
hgbot (developer)
2015-04-09 09:04

Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 616729f0e0ecf356797e40e89e374bd7b50179f0
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Thu Apr 09 09:03:34 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]

fixed issue 28975: aditionals checks to verify if the cashup was processed previously

three changes:
when a receipt is synced, in the orderloader is verified if the cashup related to the receipt has been processed previously
in the query to load the cashup in the terminal from backend, only will be loaded the cashups not processed
when a cashup is synced, it is not allowed to change the processed field from Y to N

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0076402)
hgbot (developer)
2015-04-09 09:51

Repository: retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal
Changeset: 616729f0e0ecf356797e40e89e374bd7b50179f0
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Thu Apr 09 09:03:34 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]

fixed issue 28975: aditionals checks to verify if the cashup was processed previously

three changes:
when a receipt is synced, in the orderloader is verified if the cashup related to the receipt has been processed previously
in the query to load the cashup in the terminal from backend, only will be loaded the cashups not processed
when a cashup is synced, it is not allowed to change the processed field from Y to N

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0076584)
adrianromero (manager)
2015-04-16 12:46

Verified. These changes keep the consistency of the database due to the non permitted action of login in the same terminal using two different devices.

In any case, login in the same terminal using two different devices continues to be a non permitted action. For example after the cashup in device2, receipts created in device1 will go to the window "Errors while importing POS data" because the cashup for this receipt has been previously closed. Also if trying to execute a cashup in device1 the figures will be wrong and for the same reason it will go to the window "Errors while importing POS data".

- Issue History
Date Modified Username Field Change
2015-02-17 23:06 malsasua New Issue
2015-02-17 23:06 malsasua Assigned To => marvintm
2015-02-17 23:06 malsasua Triggers an Emergency Pack => No
2015-02-17 23:08 malsasua File Added: diffNewChecks_Q11.diff
2015-02-17 23:08 malsasua File Added: diffProcessedToN_Q11.diff
2015-04-09 09:04 hgbot Checkin
2015-04-09 09:04 hgbot Note Added: 0076393
2015-04-09 09:04 hgbot Status new => resolved
2015-04-09 09:04 hgbot Resolution open => fixed
2015-04-09 09:04 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]
2015-04-09 09:51 hgbot Checkin
2015-04-09 09:51 hgbot Note Added: 0076402
2015-04-09 09:51 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]
2015-04-16 12:46 adrianromero Note Added: 0076584
2015-04-16 12:46 adrianromero Status resolved => closed
2015-04-16 12:46 adrianromero Review Assigned To => adrianromero
2015-09-16 12:08 malsasua Relationship added has duplicate 0030830
2015-09-28 11:04 marvintm Status closed => new
2015-09-28 11:04 marvintm Resolution fixed => open
2015-09-28 11:04 marvintm Status new => scheduled
2015-09-28 11:04 marvintm Status scheduled => resolved
2015-09-28 11:04 marvintm Resolution open => fixed
2015-09-28 11:04 marvintm Status resolved => closed


Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker