Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028975Retail ModulesCash uppublic2015-02-17 23:062015-09-28 11:04
Reportermalsasua 
Assigned Tomarvintm 
PrioritynormalSeverityminorReproducibilityalways
StatusclosedResolutionfixed 
PlatformOS20OS VersionCommunity Appliance
Product Version 
Target VersionFixed in Version 
Merge Request Status
Review Assigned Toadrianromero
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028975: additional checks to avoid wrong cashups
DescriptionWhen a same terminal is accessed from two or more devices, the cashups generated by this terminal can be wrong.

When it happens, the cashup should not be processed and it should be included in "Errors while importing data" window
Steps To Reproducein device1
. clean cache
. do login in VBS-1
. new cashup with "id1" is created in local database
. create and pay a new receipt
. logout

in device2
. clean cache
. do login in VBS-1
. cashup with "id1" is loaded in local database
. create and pay a new receipt
. do a cashup
. logout

in device1
. do login in VBS-1
. cashup with "id1" is loaded in local database
. create and pay a new receipt

in backoffice, the cashup with "id1" is set as
. processed=N
. processedbo=Y

it is wrong
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on backport 0030946RR15Q2.5 closed marvintm additional checks to avoid wrong cashups 
has duplicate defect 0030830 closed Retail cashup in backoffice is updated with old record 
Attached Filesdiff diffNewChecks_Q11.diff (2,835) 2015-02-17 23:08
https://issues.openbravo.com/file_download.php?file_id=7800&type=bug
diff diffProcessedToN_Q11.diff (2,202) 2015-02-17 23:08
https://issues.openbravo.com/file_download.php?file_id=7801&type=bug
Issue History
Date ModifiedUsernameFieldChange
2015-02-17 23:06malsasuaNew Issue
2015-02-17 23:06malsasuaAssigned To => marvintm
2015-02-17 23:06malsasuaOBNetwork customer => No
2015-02-17 23:06malsasuaTriggers an Emergency Pack => No
2015-02-17 23:08malsasuaFile Added: diffNewChecks_Q11.diff
2015-02-17 23:08malsasuaFile Added: diffProcessedToN_Q11.diff
2015-04-09 09:04hgbotCheckin
2015-04-09 09:04hgbotNote Added: 0076393
2015-04-09 09:04hgbotStatusnew => resolved
2015-04-09 09:04hgbotResolutionopen => fixed
2015-04-09 09:04hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]
2015-04-09 09:51hgbotCheckin
2015-04-09 09:51hgbotNote Added: 0076402
2015-04-09 09:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^] => http://code.openbravo.com/retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]
2015-04-16 12:46adrianromeroNote Added: 0076584
2015-04-16 12:46adrianromeroStatusresolved => closed
2015-04-16 12:46adrianromeroReview Assigned To => adrianromero
2015-09-16 12:08malsasuaRelationship addedhas duplicate 0030830
2015-09-28 11:04marvintmStatusclosed => new
2015-09-28 11:04marvintmResolutionfixed => open
2015-09-28 11:04marvintmStatusnew => scheduled
2015-09-28 11:04marvintmStatusscheduled => resolved
2015-09-28 11:04marvintmResolutionopen => fixed
2015-09-28 11:04marvintmStatusresolved => closed

Notes
(0076393)
hgbot   
2015-04-09 09:04   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: 616729f0e0ecf356797e40e89e374bd7b50179f0
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Thu Apr 09 09:03:34 2015 +0200
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]

fixed issue 28975: aditionals checks to verify if the cashup was processed previously

three changes:
when a receipt is synced, in the orderloader is verified if the cashup related to the receipt has been processed previously
in the query to load the cashup in the terminal from backend, only will be loaded the cashups not processed
when a cashup is synced, it is not allowed to change the processed field from Y to N

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0076402)
hgbot   
2015-04-09 09:51   
Repository: retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal
Changeset: 616729f0e0ecf356797e40e89e374bd7b50179f0
Author: Miguel A. Alsasua <miguel.alsasua <at> openbravo.com>
Date: Thu Apr 09 09:03:34 2015 +0200
URL: http://code.openbravo.com/retail/backports/3.0RR15Q2/org.openbravo.retail.posterminal/rev/616729f0e0ecf356797e40e89e374bd7b50179f0 [^]

fixed issue 28975: aditionals checks to verify if the cashup was processed previously

three changes:
when a receipt is synced, in the orderloader is verified if the cashup related to the receipt has been processed previously
in the query to load the cashup in the terminal from backend, only will be loaded the cashups not processed
when a cashup is synced, it is not allowed to change the processed field from Y to N

---
M src/org/openbravo/retail/posterminal/OrderLoader.java
M src/org/openbravo/retail/posterminal/ProcessCashClose.java
M src/org/openbravo/retail/posterminal/master/Cashup.java
M web/org.openbravo.retail.posterminal/js/utils/cashUpReportUtils.js
---
(0076584)
adrianromero   
2015-04-16 12:46   
Verified. These changes keep the consistency of the database due to the non permitted action of login in the same terminal using two different devices.

In any case, login in the same terminal using two different devices continues to be a non permitted action. For example after the cashup in device2, receipts created in device1 will go to the window "Errors while importing POS data" because the cashup for this receipt has been previously closed. Also if trying to execute a cashup in device1 the figures will be wrong and for the same reason it will go to the window "Errors while importing POS data".