Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0028419
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Retail Modules] Web POSmajorhave not tried2014-12-16 01:332014-12-16 17:11
ReportermtaalView Statuspublic 
Assigned Tomtaal 
PrioritynormalResolutionfixedFixed in VersionRR15Q1
StatusclosedFix in branchFixed in SCM revisionfd90c9d353fd
ProjectionnoneETAnoneTarget VersionRR15Q1
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Tomalsasua
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary

0028419: Module script 26444 not running as preference check is incorrect

DescriptionSee the modulescript of the related issue. This changeset:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/29e8b1f5fcf2b7d3ee0fbf84c34ab4a3a2fe4c8c#l3.7 [^]

There is this code:
String isFixed = FixDataIssue26444Data.selectExistsPreference(cp);
if (isFixed.equals("0")) {
    return;
}

The FixDataIssue26444Data.selectExistsPreference returns 1 if the preference exists and 0 if it does not exist. In this case the isFixed check should be on "1" and not "0".
Steps To ReproduceCheck if the result is 1 instead of 0. If it is 1 then do not run the modulescript.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 0026444RR14Q3 closedmalsasua Invoices with total gross amount of 0 should not have a payment plan 

-  Notes
(0072530)
hgbot (developer)
2014-12-16 01:34

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d025f0a3916f91162610f37364807ec1041e1663
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 16 01:34:16 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d025f0a3916f91162610f37364807ec1041e1663 [^]

Fixes issue 28419: Module script 26444 not running as preference check is incorrect
Do the check on 1 instead of 0

---
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.java
---
(0072541)
hgbot (developer)
2014-12-16 10:51

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e154a8439a6009911ba88167a2a7dd2594dc5672
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 16 10:51:19 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e154a8439a6009911ba88167a2a7dd2594dc5672 [^]

Fixes issue 28419: Module script 26444 not running as preference check is incorrect
Added compiled class files

---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.class
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444Data.class
---
(0072542)
hgbot (developer)
2014-12-16 11:13

 Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fd90c9d353fd5bf2b1ac7bfc8b73a13d24c73a7d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 16 11:12:58 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd90c9d353fd5bf2b1ac7bfc8b73a13d24c73a7d [^]

Fixes issue 28419: Module script 26444 not running as preference check is incorrect
Now compiled with correct jdk 1.6

---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.class
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444Data.class
---
(0072568)
malsasua (developer)
2014-12-16 17:11

 verified

- Issue History
Date Modified Username Field Change
2014-12-16 01:33 mtaal New Issue
2014-12-16 01:33 mtaal Assigned To => mtaal
2014-12-16 01:33 mtaal Triggers an Emergency Pack => No
2014-12-16 01:33 mtaal Relationship added related to 0026444
2014-12-16 01:34 hgbot Checkin
2014-12-16 01:34 hgbot Note Added: 0072530
2014-12-16 01:34 hgbot Status new => resolved
2014-12-16 01:34 hgbot Resolution open => fixed
2014-12-16 01:34 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d025f0a3916f91162610f37364807ec1041e1663 [^]
2014-12-16 10:51 hgbot Checkin
2014-12-16 10:51 hgbot Note Added: 0072541
2014-12-16 10:51 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d025f0a3916f91162610f37364807ec1041e1663 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e154a8439a6009911ba88167a2a7dd2594dc5672 [^]
2014-12-16 11:13 hgbot Checkin
2014-12-16 11:13 hgbot Note Added: 0072542
2014-12-16 11:13 hgbot Fixed in SCM revision http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e154a8439a6009911ba88167a2a7dd2594dc5672 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd90c9d353fd5bf2b1ac7bfc8b73a13d24c73a7d [^]
2014-12-16 17:11 malsasua Review Assigned To => malsasua
2014-12-16 17:11 malsasua Note Added: 0072568
2014-12-16 17:11 malsasua Status resolved => closed
2014-12-16 17:11 malsasua Fixed in Version => RR15Q1

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker