Openbravo Issue Tracking System - Retail Modules
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0028419Retail ModulesWeb POSpublic2014-12-16 01:332014-12-16 17:11
Reportermtaal 
Assigned Tomtaal 
PrioritynormalSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionRR15Q1Fixed in VersionRR15Q1 
Merge Request Status
Review Assigned Tomalsasua
OBNetwork customerNo
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0028419: Module script 26444 not running as preference check is incorrect
DescriptionSee the modulescript of the related issue. This changeset:
https://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/29e8b1f5fcf2b7d3ee0fbf84c34ab4a3a2fe4c8c#l3.7 [^]

There is this code:
String isFixed = FixDataIssue26444Data.selectExistsPreference(cp);
if (isFixed.equals("0")) {
    return;
}

The FixDataIssue26444Data.selectExistsPreference returns 1 if the preference exists and 0 if it does not exist. In this case the isFixed check should be on "1" and not "0".
Steps To ReproduceCheck if the result is 1 instead of 0. If it is 1 then do not run the modulescript.
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0026444RR14Q3 closed malsasua Invoices with total gross amount of 0 should not have a payment plan 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-12-16 01:33mtaalNew Issue
2014-12-16 01:33mtaalAssigned To => mtaal
2014-12-16 01:33mtaalOBNetwork customer => No
2014-12-16 01:33mtaalTriggers an Emergency Pack => No
2014-12-16 01:33mtaalRelationship addedrelated to 0026444
2014-12-16 01:34hgbotCheckin
2014-12-16 01:34hgbotNote Added: 0072530
2014-12-16 01:34hgbotStatusnew => resolved
2014-12-16 01:34hgbotResolutionopen => fixed
2014-12-16 01:34hgbotFixed in SCM revision => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d025f0a3916f91162610f37364807ec1041e1663 [^]
2014-12-16 10:51hgbotCheckin
2014-12-16 10:51hgbotNote Added: 0072541
2014-12-16 10:51hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d025f0a3916f91162610f37364807ec1041e1663 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e154a8439a6009911ba88167a2a7dd2594dc5672 [^]
2014-12-16 11:13hgbotCheckin
2014-12-16 11:13hgbotNote Added: 0072542
2014-12-16 11:13hgbotFixed in SCM revisionhttp://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e154a8439a6009911ba88167a2a7dd2594dc5672 [^] => http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd90c9d353fd5bf2b1ac7bfc8b73a13d24c73a7d [^]
2014-12-16 17:11malsasuaReview Assigned To => malsasua
2014-12-16 17:11malsasuaNote Added: 0072568
2014-12-16 17:11malsasuaStatusresolved => closed
2014-12-16 17:11malsasuaFixed in Version => RR15Q1

Notes
(0072530)
hgbot   
2014-12-16 01:34   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: d025f0a3916f91162610f37364807ec1041e1663
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 16 01:34:16 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/d025f0a3916f91162610f37364807ec1041e1663 [^]

Fixes issue 28419: Module script 26444 not running as preference check is incorrect
Do the check on 1 instead of 0

---
M src-util/modulescript/src/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.java
---
(0072541)
hgbot   
2014-12-16 10:51   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: e154a8439a6009911ba88167a2a7dd2594dc5672
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 16 10:51:19 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/e154a8439a6009911ba88167a2a7dd2594dc5672 [^]

Fixes issue 28419: Module script 26444 not running as preference check is incorrect
Added compiled class files

---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.class
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444Data.class
---
(0072542)
hgbot   
2014-12-16 11:13   
Repository: erp/pmods/org.openbravo.retail.posterminal
Changeset: fd90c9d353fd5bf2b1ac7bfc8b73a13d24c73a7d
Author: Martin Taal <martin.taal <at> openbravo.com>
Date: Tue Dec 16 11:12:58 2014 +0100
URL: http://code.openbravo.com/erp/pmods/org.openbravo.retail.posterminal/rev/fd90c9d353fd5bf2b1ac7bfc8b73a13d24c73a7d [^]

Fixes issue 28419: Module script 26444 not running as preference check is incorrect
Now compiled with correct jdk 1.6

---
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444.class
M build/classes/org/openbravo/retail/posterminal/modulescript/FixDataIssue26444Data.class
---
(0072568)
malsasua   
2014-12-16 17:11   
verified