Project:
| View Issue Details[ Jump to Notes ] | [ Issue History ] [ Print ] | |||||||
| ID | ||||||||
| 0027441 | ||||||||
| Type | Category | Severity | Reproducibility | Date Submitted | Last Update | |||
| defect | [Openbravo ERP] 07. Sales management | minor | have not tried | 2014-08-23 17:05 | 2023-01-30 16:44 | |||
| Reporter | shuehner | View Status | public | |||||
| Assigned To | shuehner | |||||||
| Priority | normal | Resolution | fixed | Fixed in Version | PR23Q2 | |||
| Status | closed | Fix in branch | Fixed in SCM revision | |||||
| Projection | none | ETA | none | Target Version | ||||
| OS | Any | Database | Any | Java version | ||||
| OS Version | Database version | Ant version | ||||||
| Product Version | SCM revision | |||||||
| Merge Request Status | approved | |||||||
| Review Assigned To | ||||||||
| OBNetwork customer | No | |||||||
| Web browser | ||||||||
| Modules | Core | |||||||
| Support ticket | ||||||||
| Regression level | ||||||||
| Regression date | ||||||||
| Regression introduced in release | ||||||||
| Regression introduced by commit | ||||||||
| Triggers an Emergency Pack | No | |||||||
| Summary | 0027441: Remove 2 unused/obsolete pl-functions of old-flow/pre-aprm time: c_order_status & c_debt_payment_paid | |||||||
| Description | About removal of c_order_status pl-function - There is no usage of it in git master codebase - 2 references in MRP_RUN_INITIALIZE are commented our (for a long time) - There are no referenced found either in - git clones of all /openbravo/product repos - Download of all obx modules (ignoring unsupported ones) - Additionally here is only covers the old-flow tables Apparently the equivalent with aprm was never implemented https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-db/database/model/functions/C_ORDER_STATUS.xml#L53 [^] - c_debt_payment_paid function - No users are found in git clones or obx download - Only user in git master is c_order_status function also to be removed here | |||||||
| Steps To Reproduce | - | |||||||
| Tags | No tags attached. | |||||||
| Attached Files | ||||||||
Relationships [ Relation Graph ]
[ Dependency Graph ]
|
||||||||||||||||||||||
|
||||||||||||||||||||||
Notes |
|
|
(0069651) shuehner (administrator) 2014-08-23 17:06 |
found using plpgsql_check |
|
(0144601) hgbot (developer) 2022-12-13 15:39 |
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/787 [^] |
|
(0144611) hgbot (developer) 2022-12-13 18:17 |
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/39 [^] |
|
(0146043) hgbot (developer) 2023-01-30 16:44 |
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^] Changeset: 3e8046be1f870d9b8140839549bd62476d33db00 Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 30-01-2023 15:43:22 URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/3e8046be1f870d9b8140839549bd62476d33db00 [^] Related to ISSUE-27441: Accept api change (to remove 2 old pl functions) --- R model/src-db/database/model/functions/C_DEBT_PAYMENT_PAID.xml R model/src-db/database/model/functions/C_ORDER_STATUS.xml --- |
|
(0146044) hgbot (developer) 2023-01-30 16:44 |
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/39 [^] |
|
(0146045) hgbot (developer) 2023-01-30 16:44 |
Directly closing issue as related merge request is already approved. Repository: https://gitlab.com/openbravo/product/openbravo [^] Changeset: 3c9ff869996f4407d62f51a8fcd0937cad97716e Author: Stefan Huehner <stefan.huehner@openbravo.com> Date: 30-01-2023 15:44:00 URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3c9ff869996f4407d62f51a8fcd0937cad97716e [^] Fixes ISSUE-27441. Remove unused c_order_status & C_DEBT_PAYMENT_PAID c_order_status function is unused and part of it seem only implemented for the old-flow/pre-aprm world. c_debt_payment_paid function is only used by c_order_status Remove both as unused and obsolete as part of old-flow cleanup. --- M src-db/database/model/functions/MRP_RUN_INITIALIZE.xml R src-db/database/model/functions/C_DEBT_PAYMENT_PAID.xml R src-db/database/model/functions/C_ORDER_STATUS.xml --- |
|
(0146046) hgbot (developer) 2023-01-30 16:44 |
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/787 [^] |
Issue History |
|||
| Date Modified | Username | Field | Change |
| 2014-08-23 17:05 | shuehner | New Issue | |
| 2014-08-23 17:05 | shuehner | Assigned To | => dmiguelez |
| 2014-08-23 17:05 | shuehner | OBNetwork customer | => No |
| 2014-08-23 17:05 | shuehner | Modules | => Core |
| 2014-08-23 17:05 | shuehner | Triggers an Emergency Pack | => No |
| 2014-08-23 17:06 | shuehner | Note Added: 0069651 | |
| 2014-08-23 17:06 | shuehner | Relationship added | related to 0027440 |
| 2014-09-03 13:55 | eduardo_Argal | Assigned To | dmiguelez => eduardo_Argal |
| 2020-02-03 12:23 | shuehner | Relationship added | blocks 0032688 |
| 2022-12-13 15:31 | shuehner | Summary | pl-function c_order_status is not used anywhere => Remove 2 unused/obsolete pl-functions of old-flow/pre-aprm time: c_order_status & c_debt_payment_paid |
| 2022-12-13 15:31 | shuehner | Description Updated | View Revisions |
| 2022-12-13 15:31 | shuehner | Assigned To | eduardo_Argal => shuehner |
| 2022-12-13 15:31 | shuehner | Relationship added | blocks 0050984 |
| 2022-12-13 15:39 | hgbot | Merge Request Status | => open |
| 2022-12-13 15:39 | hgbot | Note Added: 0144601 | |
| 2022-12-13 18:17 | hgbot | Note Added: 0144611 | |
| 2023-01-30 12:59 | hgbot | Merge Request Status | open => approved |
| 2023-01-30 16:44 | hgbot | Note Added: 0146043 | |
| 2023-01-30 16:44 | hgbot | Note Added: 0146044 | |
| 2023-01-30 16:44 | hgbot | Resolution | open => fixed |
| 2023-01-30 16:44 | hgbot | Status | new => closed |
| 2023-01-30 16:44 | hgbot | Fixed in Version | => PR23Q2 |
| 2023-01-30 16:44 | hgbot | Note Added: 0146045 | |
| 2023-01-30 16:44 | hgbot | Note Added: 0146046 | |
| Copyright © 2000 - 2009 MantisBT Group |