Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0027441Openbravo ERP07. Sales managementpublic2014-08-23 17:052023-01-30 16:44
Reportershuehner 
Assigned Toshuehner 
PrioritynormalSeverityminorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target VersionFixed in VersionPR23Q2 
Merge Request Statusapproved
Review Assigned To
OBNetwork customerNo
Web browser
ModulesCore
Support ticket
Regression level
Regression date
Regression introduced in release
Regression introduced by commit
Triggers an Emergency PackNo
Summary0027441: Remove 2 unused/obsolete pl-functions of old-flow/pre-aprm time: c_order_status & c_debt_payment_paid
DescriptionAbout removal of c_order_status pl-function
- There is no usage of it in git master codebase
  - 2 references in MRP_RUN_INITIALIZE are commented our (for a long time)
- There are no referenced found either in
  - git clones of all /openbravo/product repos
  - Download of all obx modules (ignoring unsupported ones)
- Additionally here is only covers the old-flow tables
  Apparently the equivalent with aprm was never implemented
  https://gitlab.com/openbravo/product/openbravo/-/blob/master/src-db/database/model/functions/C_ORDER_STATUS.xml#L53 [^]

- c_debt_payment_paid function
  - No users are found in git clones or obx download
  - Only user in git master is c_order_status function also to be removed here
Steps To Reproduce-
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
related to defect 0027440 closed AtulOpenbravo pl-function c_order_status is broken: uuid bug 
blocks design defect 0032688 acknowledged Triage Platform Base remove unused resources 
blocks design defect 0050984 new shuehner Tracking issue: Remove obsolete old-flow / pre-aprm related code 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-08-23 17:05shuehnerNew Issue
2014-08-23 17:05shuehnerAssigned To => dmiguelez
2014-08-23 17:05shuehnerOBNetwork customer => No
2014-08-23 17:05shuehnerModules => Core
2014-08-23 17:05shuehnerTriggers an Emergency Pack => No
2014-08-23 17:06shuehnerNote Added: 0069651
2014-08-23 17:06shuehnerRelationship addedrelated to 0027440
2014-09-03 13:55eduardo_ArgalAssigned Todmiguelez => eduardo_Argal
2020-02-03 12:23shuehnerRelationship addedblocks 0032688
2022-12-13 15:31shuehnerSummarypl-function c_order_status is not used anywhere => Remove 2 unused/obsolete pl-functions of old-flow/pre-aprm time: c_order_status & c_debt_payment_paid
2022-12-13 15:31shuehnerDescription Updatedbug_revision_view_page.php?rev_id=25235#r25235
2022-12-13 15:31shuehnerAssigned Toeduardo_Argal => shuehner
2022-12-13 15:31shuehnerRelationship addedblocks 0050984
2022-12-13 15:39hgbotMerge Request Status => open
2022-12-13 15:39hgbotNote Added: 0144601
2022-12-13 18:17hgbotNote Added: 0144611
2023-01-30 12:59hgbotMerge Request Statusopen => approved
2023-01-30 16:44hgbotNote Added: 0146043
2023-01-30 16:44hgbotNote Added: 0146044
2023-01-30 16:44hgbotResolutionopen => fixed
2023-01-30 16:44hgbotStatusnew => closed
2023-01-30 16:44hgbotFixed in Version => PR23Q2
2023-01-30 16:44hgbotNote Added: 0146045
2023-01-30 16:44hgbotNote Added: 0146046

Notes
(0069651)
shuehner   
2014-08-23 17:06   
found using plpgsql_check
(0144601)
hgbot   
2022-12-13 15:39   
Merge Request created: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/787 [^]
(0144611)
hgbot   
2022-12-13 18:17   
Merge Request created: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/39 [^]
(0146043)
hgbot   
2023-01-30 16:44   
Repository: https://gitlab.com/openbravo/ci/backoffice-api [^]
Changeset: 3e8046be1f870d9b8140839549bd62476d33db00
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 30-01-2023 15:43:22
URL: https://gitlab.com/openbravo/ci/backoffice-api/-/commit/3e8046be1f870d9b8140839549bd62476d33db00 [^]

Related to ISSUE-27441: Accept api change (to remove 2 old pl functions)

---
R model/src-db/database/model/functions/C_DEBT_PAYMENT_PAID.xml
R model/src-db/database/model/functions/C_ORDER_STATUS.xml
---
(0146044)
hgbot   
2023-01-30 16:44   
Merge request merged: https://gitlab.com/openbravo/ci/backoffice-api/-/merge_requests/39 [^]
(0146045)
hgbot   
2023-01-30 16:44   
Directly closing issue as related merge request is already approved.

Repository: https://gitlab.com/openbravo/product/openbravo [^]
Changeset: 3c9ff869996f4407d62f51a8fcd0937cad97716e
Author: Stefan Huehner <stefan.huehner@openbravo.com>
Date: 30-01-2023 15:44:00
URL: https://gitlab.com/openbravo/product/openbravo/-/commit/3c9ff869996f4407d62f51a8fcd0937cad97716e [^]

Fixes ISSUE-27441. Remove unused c_order_status & C_DEBT_PAYMENT_PAID

c_order_status function is unused and part of it seem only implemented
for the old-flow/pre-aprm world.
c_debt_payment_paid function is only used by c_order_status

Remove both as unused and obsolete as part of old-flow cleanup.

---
M src-db/database/model/functions/MRP_RUN_INITIALIZE.xml
R src-db/database/model/functions/C_DEBT_PAYMENT_PAID.xml
R src-db/database/model/functions/C_ORDER_STATUS.xml
---
(0146046)
hgbot   
2023-01-30 16:44   
Merge request merged: https://gitlab.com/openbravo/product/openbravo/-/merge_requests/787 [^]