Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0025838
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2014-02-26 09:512014-02-28 19:50
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR14Q2
StatusclosedFix in branchFixed in SCM revisiond3337dfe6180
ProjectionnoneETAnoneTarget Version3.0PR14Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2013-09-11
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Triggers an Emergency PackNo
Summary

0025838: Time fields are still not working properly in timezones with negative offsets

DescriptionWhen a time field is saved from a timezone with a negative offset, its value is not being properly shown in the client when an existing record is opened in form view.
Steps To ReproduceFrom a timezone with negative offset (i.e. Monreal, GMT-5):
- Open Process Request
- Start creating a new record in form view
- Set Run Later in the Timing Combo
- Set 10:00:00 in the Start Time field
- Save. The proper value will be saved in the database and the value shown to the user will be proper.
- Open the grid view, and open again the selected record in form view.
- The Start Time value has changed.
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
related to defect 00258273.0PR14Q2 closedAugustoMauch Time fields are not working properly in timezones with negative offsets 
related to defect 0038661 closedcaristu Problem with tabs with 'Time' fields 

-  Notes
(0064594)
hgbot (developer)
2014-02-26 10:09

 Repository: erp/devel/pi
Changeset: d3337dfe6180201ad46ab07dce3a5de2c6636de4
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 26 10:05:46 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/d3337dfe6180201ad46ab07dce3a5de2c6636de4 [^]

Fixes issue 25838: Time fields work properly in timezones with negative offsets

There was a problem the todays date was assigned to a datetime:

Original date: 31/12/2013 10:00:00
Todays date: 25/02/2014

The assignment order was year, month day, so the datetime was transformed like this:
Year updated: 31/12/2014 10:00:00
Month updated: 31/02/2014 does not exists, so it is converted to 03/03/2014
Day updated: 25/03/2014

This has been fixed by changing the updating order to Day, Month, Year. Before the update the date month is set to January to prevent setting a day not supported by the current month.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/main/ob-standard-view.js
---
(0064596)
hgbot (developer)
2014-02-26 10:21

 Repository: erp/devel/pi
Changeset: 44671c4c2901e88c6119b63785e8fb1b554c6a90
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 26 10:20:31 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/44671c4c2901e88c6119b63785e8fb1b554c6a90 [^]

Related to issue 25838:Avoids accessing a property of an undefined object

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0064602)
hgbot (developer)
2014-02-26 10:51

 Repository: erp/devel/pi
Changeset: 62c6d119b8f87f48a4dd49a3044b8cdc0360c219
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Wed Feb 26 10:51:11 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/62c6d119b8f87f48a4dd49a3044b8cdc0360c219 [^]

Related to issue 25838:Avoids accessing a property of an undefined object

The check (if data[this.name]) to avoid accessing a property of data[this.name], that can be undefined, has been moved from here

 if (this.getValue() !== data[this.name]) {

to here

data[this.name].getFullYear() <= 1970)

It did not make sense to make the check in the outer if clause, because that would disable setting a null value for this property from the datasource.

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0064605)
shankarb (reporter)
2014-02-26 11:59

 Code reviewed and verified in pi changeset b2b40bda6f96.
(0064638)
hudsonbot (developer)
2014-02-26 19:43

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/12811c036202 [^]
Maturity status: Test
(0064686)
hudsonbot (developer)
2014-02-28 19:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a3305b1338e [^]
Maturity status: Test
(0064687)
hudsonbot (developer)
2014-02-28 19:50

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/2a3305b1338e [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-02-26 09:51 AugustoMauch New Issue
2014-02-26 09:51 AugustoMauch Assigned To => AugustoMauch
2014-02-26 09:51 AugustoMauch Modules => Core
2014-02-26 09:51 AugustoMauch Triggers an Emergency Pack => No
2014-02-26 09:51 AugustoMauch Relationship added related to 0025827
2014-02-26 09:52 AugustoMauch Regression level => Production - Confirmed Stable
2014-02-26 09:52 AugustoMauch Regression date => 2013-09-11
2014-02-26 09:52 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
2014-02-26 09:56 AugustoMauch Issue Monitored: shankarb
2014-02-26 09:56 AugustoMauch Review Assigned To => shankarb
2014-02-26 10:09 hgbot Checkin
2014-02-26 10:09 hgbot Note Added: 0064594
2014-02-26 10:09 hgbot Status new => resolved
2014-02-26 10:09 hgbot Resolution open => fixed
2014-02-26 10:09 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/d3337dfe6180201ad46ab07dce3a5de2c6636de4 [^]
2014-02-26 10:21 hgbot Checkin
2014-02-26 10:21 hgbot Note Added: 0064596
2014-02-26 10:51 hgbot Checkin
2014-02-26 10:51 hgbot Note Added: 0064602
2014-02-26 11:59 shankarb Note Added: 0064605
2014-02-26 11:59 shankarb Status resolved => closed
2014-02-26 11:59 shankarb Fixed in Version => 3.0MP32
2014-02-26 19:43 hudsonbot Checkin
2014-02-26 19:43 hudsonbot Note Added: 0064638
2014-02-28 19:50 hudsonbot Checkin
2014-02-28 19:50 hudsonbot Note Added: 0064686
2014-02-28 19:50 hudsonbot Checkin
2014-02-28 19:50 hudsonbot Note Added: 0064687
2018-06-01 09:19 caristu Relationship added related to 0038661

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker