Anonymous | Login
Project:
RSS
  
News | My View | View Issues | Roadmap | Summary

View Issue Details[ Jump to Notes ] [ Issue History ] [ Print ]
ID
0025827
TypeCategorySeverityReproducibilityDate SubmittedLast Update
defect[Openbravo ERP] A. Platformmajorhave not tried2014-02-25 11:112014-02-25 20:14
ReporterAugustoMauchView Statuspublic 
Assigned ToAugustoMauch 
PriorityimmediateResolutionfixedFixed in Version3.0PR14Q2
StatusclosedFix in branchFixed in SCM revision7feaacbc88b1
ProjectionnoneETAnoneTarget Version3.0PR14Q2
OSAnyDatabaseAnyJava version
OS VersionDatabase versionAnt version
Product VersionSCM revision 
Review Assigned Toshankarb
Web browser
ModulesCore
Regression levelProduction - Confirmed Stable
Regression date2013-09-11
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Triggers an Emergency PackNo
Summary

0025827: Time fields are not working properly in timezones with negative offsets

DescriptionWhen a time field is saved from a timezone with a negative offset, its value is not being properly shown in the client.
Steps To ReproduceFrom a timezone with negative offset (i.e. Monreal, GMT-5):
- Open Process Request
- Start creating a new record in form view
- Set Run Later in the Timing Combo
- Set 10:00:00 in the Start Time field
- Save. The proper value will be saved in the database, but the value shown to the user will be wrong.
- Refresh. The proper value will be shown
TagsNo tags attached.
Attached Files

- Relationships [ Relation Graph ] [ Dependency Graph ]
depends on defect 0025274 closedAugustoMauch The time fields are not working properly 
depends on defect 00256023.0PR14Q2 closedAugustoMauch The time fiels are modified after save a record 
related to defect 00258383.0PR14Q2 closedAugustoMauch Time fields are still not working properly in timezones with negative offsets 

-  Notes
(0064558)
hgbot (developer)
2014-02-25 11:22

 Repository: erp/devel/pi
Changeset: 7feaacbc88b193ba517168f1ed718849d67db313
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 25 11:21:33 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7feaacbc88b193ba517168f1ed718849d67db313 [^]

Fixes issue 25827: Time fields work properly in timezones with negative offsets

Depending on who calls the formSaved function of OBTimeItem, the provided time can be already converted to the client local time or not. To know the time has a
lready been converted, the function used to check if the full year of the time was 1970. If that was the case, then the time was converted from UTC to local ti
me.

The problem is that if the user is working from a timezone with negative offset the full year will not be 1970, but 1969. This has been fixed by replacing data
[this.name].getFullYear() === 1970 with data[this.name].getFullYear() <= 1970

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0064565)
shankarb (reporter)
2014-02-25 14:04

 Code reviewed and verified in pi changeset 7feaacbc88b1.
(0064592)
hudsonbot (developer)
2014-02-25 20:14

 A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7579d638a80a [^]
Maturity status: Test

- Issue History
Date Modified Username Field Change
2014-02-25 11:11 AugustoMauch New Issue
2014-02-25 11:11 AugustoMauch Assigned To => AugustoMauch
2014-02-25 11:11 AugustoMauch Modules => Core
2014-02-25 11:11 AugustoMauch Triggers an Emergency Pack => No
2014-02-25 11:11 AugustoMauch Relationship added depends on 0025274
2014-02-25 11:11 AugustoMauch Relationship added depends on 0025602
2014-02-25 11:13 AugustoMauch Regression level => Production - Confirmed Stable
2014-02-25 11:13 AugustoMauch Regression date => 2013-09-11
2014-02-25 11:13 AugustoMauch Regression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
2014-02-25 11:19 AugustoMauch Issue Monitored: shankarb
2014-02-25 11:19 AugustoMauch Review Assigned To => shankarb
2014-02-25 11:22 hgbot Checkin
2014-02-25 11:22 hgbot Note Added: 0064558
2014-02-25 11:22 hgbot Status new => resolved
2014-02-25 11:22 hgbot Resolution open => fixed
2014-02-25 11:22 hgbot Fixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7feaacbc88b193ba517168f1ed718849d67db313 [^]
2014-02-25 14:04 shankarb Note Added: 0064565
2014-02-25 14:04 shankarb Status resolved => closed
2014-02-25 14:04 shankarb Fixed in Version => 3.0MP32
2014-02-25 20:14 hudsonbot Checkin
2014-02-25 20:14 hudsonbot Note Added: 0064592
2014-02-26 09:51 AugustoMauch Relationship added related to 0025838

Copyright © 2000 - 2009 MantisBT Group
Powered by Mantis Bugtracker