Openbravo Issue Tracking System - Openbravo ERP
View Issue Details
IDProjectCategoryView StatusDate SubmittedLast Update
0025827Openbravo ERPA. Platformpublic2014-02-25 11:112014-02-25 20:14
ReporterAugustoMauch 
Assigned ToAugustoMauch 
PriorityimmediateSeveritymajorReproducibilityhave not tried
StatusclosedResolutionfixed 
PlatformOS5OS Version
Product Version 
Target Version3.0PR14Q2Fixed in Version3.0PR14Q2 
Merge Request Status
Review Assigned Toshankarb
OBNetwork customer
Web browser
ModulesCore
Support ticket
Regression levelProduction - Confirmed Stable
Regression date2013-09-11
Regression introduced in release
Regression introduced by commithttps://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
Triggers an Emergency PackNo
Summary0025827: Time fields are not working properly in timezones with negative offsets
DescriptionWhen a time field is saved from a timezone with a negative offset, its value is not being properly shown in the client.
Steps To ReproduceFrom a timezone with negative offset (i.e. Monreal, GMT-5):
- Open Process Request
- Start creating a new record in form view
- Set Run Later in the Timing Combo
- Set 10:00:00 in the Start Time field
- Save. The proper value will be saved in the database, but the value shown to the user will be wrong.
- Refresh. The proper value will be shown
Proposed Solution
Additional Information
TagsNo tags attached.
Relationships
depends on defect 0025274 closed AugustoMauch The time fields are not working properly 
depends on defect 00256023.0PR14Q2 closed AugustoMauch The time fiels are modified after save a record 
related to defect 00258383.0PR14Q2 closed AugustoMauch Time fields are still not working properly in timezones with negative offsets 
Attached Files
Issue History
Date ModifiedUsernameFieldChange
2014-02-25 11:11AugustoMauchNew Issue
2014-02-25 11:11AugustoMauchAssigned To => AugustoMauch
2014-02-25 11:11AugustoMauchModules => Core
2014-02-25 11:11AugustoMauchTriggers an Emergency Pack => No
2014-02-25 11:11AugustoMauchRelationship addeddepends on 0025274
2014-02-25 11:11AugustoMauchRelationship addeddepends on 0025602
2014-02-25 11:13AugustoMauchRegression level => Production - Confirmed Stable
2014-02-25 11:13AugustoMauchRegression date => 2013-09-11
2014-02-25 11:13AugustoMauchRegression introduced by commit => https://code.openbravo.com/erp/devel/pi/rev/290c9b12a211 [^]
2014-02-25 11:19AugustoMauchIssue Monitored: shankarb
2014-02-25 11:19AugustoMauchReview Assigned To => shankarb
2014-02-25 11:22hgbotCheckin
2014-02-25 11:22hgbotNote Added: 0064558
2014-02-25 11:22hgbotStatusnew => resolved
2014-02-25 11:22hgbotResolutionopen => fixed
2014-02-25 11:22hgbotFixed in SCM revision => http://code.openbravo.com/erp/devel/pi/rev/7feaacbc88b193ba517168f1ed718849d67db313 [^]
2014-02-25 14:04shankarbNote Added: 0064565
2014-02-25 14:04shankarbStatusresolved => closed
2014-02-25 14:04shankarbFixed in Version => 3.0MP32
2014-02-25 20:14hudsonbotCheckin
2014-02-25 20:14hudsonbotNote Added: 0064592
2014-02-26 09:51AugustoMauchRelationship addedrelated to 0025838

Notes
(0064558)
hgbot   
2014-02-25 11:22   
Repository: erp/devel/pi
Changeset: 7feaacbc88b193ba517168f1ed718849d67db313
Author: Augusto Mauch <augusto.mauch <at> openbravo.com>
Date: Tue Feb 25 11:21:33 2014 +0100
URL: http://code.openbravo.com/erp/devel/pi/rev/7feaacbc88b193ba517168f1ed718849d67db313 [^]

Fixes issue 25827: Time fields work properly in timezones with negative offsets

Depending on who calls the formSaved function of OBTimeItem, the provided time can be already converted to the client local time or not. To know the time has a
lready been converted, the function used to check if the full year of the time was 1970. If that was the case, then the time was converted from UTC to local ti
me.

The problem is that if the user is working from a timezone with negative offset the full year will not be 1970, but 1969. This has been fixed by replacing data
[this.name].getFullYear() === 1970 with data[this.name].getFullYear() <= 1970

---
M modules/org.openbravo.client.application/web/org.openbravo.client.application/js/form/formitem/ob-formitem-time.js
---
(0064565)
shankarb   
2014-02-25 14:04   
Code reviewed and verified in pi changeset 7feaacbc88b1.
(0064592)
hudsonbot   
2014-02-25 20:14   
A changeset related to this issue has been promoted main and to the
Central Repository, after passing a series of tests.

Promotion changeset: https://code.openbravo.com/erp/devel/main/rev/7579d638a80a [^]
Maturity status: Test